From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7D2C072B5 for ; Fri, 24 May 2019 10:14:26 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id DE9B820856 for ; Fri, 24 May 2019 10:14:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE9B820856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2769E25D9; Fri, 24 May 2019 12:14:24 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8645E1DB9 for ; Fri, 24 May 2019 12:14:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 May 2019 03:14:21 -0700 X-ExtLoop1: 1 Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.22.10]) ([10.252.22.10]) by orsmga001.jf.intel.com with ESMTP; 24 May 2019 03:14:20 -0700 To: Reshma Pattan , dev@dpdk.org Cc: david.hunt@intel.com, liang.j.ma@intel.com References: <20190517181712.12027-1-reshma.pattan@intel.com> <20190524093425.28131-1-reshma.pattan@intel.com> From: "Burakov, Anatoly" Message-ID: <648b1665-20b8-c965-cf83-1945088cbb41@intel.com> Date: Fri, 24 May 2019 11:14:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190524093425.28131-1-reshma.pattan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd-power: add telemetry mode support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 24-May-19 10:34 AM, Reshma Pattan wrote: > Add new telemetry mode support for l3fwd-power. > This is a standalone mode, in this mode l3fwd-power > does simple l3fwding along with calculating > empty polls, full polls, and busy percentage for > each forwarding core. The aggregation of these > values of all cores is reported as application > level telemetry to metric library for every 10ms from the > master core. > > The busy percentage is calculated by recording the poll_count > and when the count reaches a defined value the total > cycles it took is measured and compared with minimum and maximum > reference cycles and busy rate is set according to either 0% or > 50% or 100%. > > Signed-off-by: Reshma Pattan > --- LGTM Acked-by: Anatoly Burakov -- Thanks, Anatoly