From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2570DC31E51 for ; Tue, 18 Jun 2019 09:44:50 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id B09AA2070B for ; Tue, 18 Jun 2019 09:44:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="KxLueXQJ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="KnC1EOPD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B09AA2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 751431BF75; Tue, 18 Jun 2019 11:44:48 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5E4BC1BF72 for ; Tue, 18 Jun 2019 11:44:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C77B922089; Tue, 18 Jun 2019 05:44:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 18 Jun 2019 05:44:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Hqrubk61MdKDUtp81bSGSEGREWgQOkkjhYihhy9lVkQ=; b=KxLueXQJtUjs PQYeGxhFFw2uT66b6fvA7HZW2yhuUrRt+LBEZDW/+COOMJK5iDz9FZ5vTo97Krab 6IzQ/t9YbDCK2Xq1IN1TvttHrEnzGUQIexttxTWtaOo7YNpz1faOsMIhCr2qD2gP fsQy4nqSKZerfgb6uP+ccm3qi3I1FpE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Hqrubk61MdKDUtp81bSGSEGREWgQOkkjhYihhy9lV kQ=; b=KnC1EOPDjDo86HhVNCzP3PnyS3j+JAvoNMbcvzQVZ9lCh8dzPw6Hx+1Oy gliJeDzViLroT1hWrRvNrm6buYTKalniaDdk17SbeC7H4AuABRnGasis3vy+AtCM KadbxBhuERvzf3z8w0jnPv1WKCg7v20qWDHlOu7sAcokF6OHdqbeNyOjC0snXZtu 087mSB+PYDNGrV4cs+nZnnwxGto+2+MDD4KinRRJX2IEvKCf1irqmFdbq57k4+eJ bhbWApW3y95OeDGeirLP5YDSTwsPzvQYTUCFBn127MQmPOfPgta7TEhqKPXHLPO9 nS/Kw+6bzzLxz5/eARw183b9muKdA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudeiledgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeduleefrdegjedrudeihedrvdehudenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 37E78380073; Tue, 18 Jun 2019 05:44:45 -0400 (EDT) From: Thomas Monjalon To: Reshma Pattan Cc: dev@dpdk.org, kevin.laatz@intel.com, anatoly.burakov@intel.com Date: Tue, 18 Jun 2019 12:44:42 +0300 Message-ID: <65036935.CUehPQW58O@xps> In-Reply-To: <20190517160757.28098-1-reshma.pattan@intel.com> References: <20190517160757.28098-1-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] lib/telemetry: add support to fetch global metrics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/05/2019 19:07, Reshma Pattan: > telemetry has support for fetching port based stats > from metrics library. >=20 > Metrics library also has global stats which are > not fetched by telemetry, so extend telemetry to > fetch the global metrics. >=20 > Signed-off-by: Reshma Pattan > --- I see some errors with GCC: rte_telemetry_parser.c:362:27: error: unused variable =E2=80=98p=E2=80=99 rte_telemetry.c:550:11: error: unused variable =E2=80=98i=E2=80=99 rte_telemetry.c:613:16: error: comparison of integer expressions of differe= nt signedness: =E2=80=98int=E2=80=99 and =E2=80=98uint32_t=E2=80=99