From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F54FC31E49 for ; Sun, 16 Jun 2019 09:59:08 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5BAA321707 for ; Sun, 16 Jun 2019 09:59:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="d6bCUS/r"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="SL66xcHn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BAA321707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98D161BEBE; Sun, 16 Jun 2019 11:59:05 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 2582C1BE9D for ; Sun, 16 Jun 2019 11:59:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 7710066B; Sun, 16 Jun 2019 05:59:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 16 Jun 2019 05:59:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=zMJxzWR5YXWE6V+C/8J9IX++MmUe3jnw5Lrl2Mg6+Tg=; b=d6bCUS/r2zOn VbM8bHXlUSF/sYr8iCCEwvkpQ6wZdGLy0wgiou5bKLbxggFOdrcXd+hS5SOZepwo ZWouznwGizfvQ72/q3rSRStSwFf13nz3FiiWYq67MlNy1/dLOIH84/KT6kyyfgw0 JX+hzavLdGn/BgC+gi3FACAkIKAm3lc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=zMJxzWR5YXWE6V+C/8J9IX++MmUe3jnw5Lrl2Mg6+ Tg=; b=SL66xcHnhoFHjsLJw76LwpvEY0ZG1VVUNmFgLtlanUN4H5eVq00vnWo4q hmCkMt0wr5yDjid3AgAibVoAGx6Fe3Yqmr6CJCnwb+BN3LzdhZ63NXvRG21TmBd5 o/zINMzIu7AQchI5TMsZiHWEDDMuP+OI+W5Qv74LSW7/BqQiH4pALtBMSslP9On9 AqDhqWd4+akntXweirP0VhX+77wbbr74KM+hGdDbU9rB3o7PudcW7q4V5ZnBEYfN u+XNB1OUH3GFQsyOck4H7keEpLYEYnGhPHdBZQJmvA2DuK9avvJb8ctiB+Pj3NZa oQi3oSrCn0yVUD3EnBxKLsYSZbFMg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudeihedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeefjedrudejfedrheefrddugeehnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (unknown [37.173.53.145]) by mail.messagingengine.com (Postfix) with ESMTPA id 8A068380073; Sun, 16 Jun 2019 05:58:59 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Sunil Kumar Kori , YufengX Mo Date: Sun, 16 Jun 2019 12:58:55 +0300 Message-ID: <6558949.dsWE0Pma7t@xps> In-Reply-To: <20190614171939.94095-1-ferruh.yigit@intel.com> References: <20190614171939.94095-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/06/2019 20:19, Ferruh Yigit: > Testpmd tries to calculate mbuf size based on "max Rx packet size" and > "max MTU segment number". > When driver set a "nb_mtu_seg_max" to zero, it causes division by zero > segmentation fault in testpmd. > > If the PMD set "nb_mtu_seg_max" to zero, testpmd shouldn't try to > calculate the mbuf size. > > Fixes: 33f9630fc23d ("app/testpmd: create mbuf based on max supported segments") > > Signed-off-by: Ferruh Yigit Applied, thanks