From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E831AC432C0 for ; Mon, 2 Dec 2019 16:11:26 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 89EF12053B for ; Mon, 2 Dec 2019 16:11:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89EF12053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C07C31BE3D; Mon, 2 Dec 2019 17:11:25 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 50FFC1BDFD for ; Mon, 2 Dec 2019 17:11:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 08:11:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204610522" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by orsmga008.jf.intel.com with ESMTP; 02 Dec 2019 08:11:21 -0800 To: Alfredo Cardigliano , John McNamara , Marko Kovacevic Cc: dev@dpdk.org References: <20191015082235.28639-1-cardigliano@ntop.org> <20191015082235.28639-11-cardigliano@ntop.org> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <662c5427-7417-7ae5-b40a-5a7175f58e84@intel.com> Date: Mon, 2 Dec 2019 16:11:21 +0000 MIME-Version: 1.0 In-Reply-To: <20191015082235.28639-11-cardigliano@ntop.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 10/17] net/ionic: add basic port operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add support for port start/stop and handle basic features > including mtu and link up/down. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson > --- > doc/guides/nics/features/ionic.ini | 4 + > drivers/net/ionic/ionic.h | 1 + > drivers/net/ionic/ionic_dev.h | 3 + > drivers/net/ionic/ionic_ethdev.c | 316 +++++++++++++++++++++++++++++ > drivers/net/ionic/ionic_lif.c | 268 ++++++++++++++++++++++++ > drivers/net/ionic/ionic_lif.h | 9 + > drivers/net/ionic/ionic_osdep.h | 2 + > 7 files changed, 603 insertions(+) <...> > @@ -18,6 +18,17 @@ > > static int eth_ionic_dev_init(struct rte_eth_dev *eth_dev, void *init_params); > static int eth_ionic_dev_uninit(struct rte_eth_dev *eth_dev); > +static int ionic_dev_info_get(struct rte_eth_dev *eth_dev, > + struct rte_eth_dev_info *dev_info); > +static int ionic_dev_configure(struct rte_eth_dev *dev); > +static int ionic_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); > +static int ionic_dev_start(struct rte_eth_dev *dev); > +static void ionic_dev_stop(struct rte_eth_dev *dev); Start and stop dev_ops should not return 'void' but 'int', I think you will see this when rebase to latest code. Same for a few more dev_ops. <...> > +static int > +ionic_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu) > +{ > + struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev); > + /* > + * Size = MTU + Ethernet header + VLAN + QinQ > + * Also add ETHER_CRC_LEN if the adapter is able to keep CRC > + */ > + uint32_t frame_size = mtu + RTE_ETHER_HDR_LEN + 4 + 4; > + int err; > + > + ionic_init_print_call(); > + > + /* Check that mtu is within the allowed range */ > + if (mtu < IONIC_MIN_MTU || mtu > IONIC_MAX_MTU) > + return -EINVAL; If you feed these values to dev_info min_mtu/max_mtu, this check will be done by API level already. > + > + err = ionic_lif_change_mtu(lif, mtu); > + > + if (err) > + return err; > + > + /* Update max frame size */ > + eth_dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size; 'max_rx_pkt_len' is a user provided configuration value to limit the packet size in jumbo frame case, and it shouldn't just updated to reflect the MTU. <...> > +static int > +ionic_dev_start(struct rte_eth_dev *eth_dev) > +{ > + struct rte_eth_conf *dev_conf = ð_dev->data->dev_conf; > + struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev); > + struct ionic_adapter *adapter = lif->adapter; > + struct ionic_dev *idev = &adapter->idev; > + uint32_t allowed_speeds; > + int err; > + > + ionic_init_print_call(); > + > + err = ionic_lif_start(lif); > + > + if (err) { > + ionic_drv_print(ERR, "Cannot start LIF: %d", err); > + return err; > + } > + > + if (eth_dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED) { > + uint32_t speed = ionic_parse_link_speeds(dev_conf->link_speeds); > + > + if (speed) > + ionic_dev_cmd_port_speed(idev, speed); > + } > + > + allowed_speeds = > + ETH_LINK_SPEED_FIXED | > + ETH_LINK_SPEED_10G | > + ETH_LINK_SPEED_25G | > + ETH_LINK_SPEED_40G | > + ETH_LINK_SPEED_50G | > + ETH_LINK_SPEED_100G; > + > + if (dev_conf->link_speeds & ~allowed_speeds) { > + ionic_init_print(ERR, "Invalid link setting"); Should this check be done before 'ionic_lif_start()' call? <...> > +static void > +ionic_dev_close(struct rte_eth_dev *eth_dev) > +{ > + struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev); > + int err; > + > + ionic_init_print_call(); > + > + err = ionic_lif_stop(lif); > + > + if (err) { > + ionic_drv_print(ERR, "Cannot stop LIF: %d", err); > + return; > + } 'close()' dev_ops should free all device resources. A closed eth_dev can't be opened back. Can you please add additional cleanup. <...> > diff --git a/drivers/net/ionic/ionic_osdep.h b/drivers/net/ionic/ionic_osdep.h > index 5b8baa67b..39a9cefa9 100644 > --- a/drivers/net/ionic/ionic_osdep.h > +++ b/drivers/net/ionic/ionic_osdep.h > @@ -28,6 +28,8 @@ > #define BIT_ULL(nr) (1ULL << (nr)) > #define BITS_TO_LONGS(nr) div_round_up(nr, 8 * sizeof(long)) > > +#define ETH_ALEN 6 You can use 'RTE_ETHER_ADDR_LEN' instead in the net libary