DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code
@ 2019-05-15 16:19 Fan Zhang
  2019-06-17  9:26 ` Kovacevic, Marko
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fan Zhang @ 2019-05-15 16:19 UTC (permalink / raw)
  To: dev; +Cc: maxime.coquelin, Fan Zhang, stable

This patch fixes a few same class bugs that causes the
logically dead code in vhost_crypto.

Coverity issue: 277236
Coverity issue: 277233
Coverity issue: 277220
Coverity issue: 277214

Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Cc: stable@dpdk.org

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 lib/librte_vhost/vhost_crypto.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index 0edf12d52..069b56108 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -1024,7 +1024,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
 		}
 		if (unlikely(copy_data(rte_pktmbuf_mtod(m_src, uint8_t *),
 				vc_req, &desc, chain->para.src_data_len,
-				nb_descs, vq_size)) < 0) {
+				nb_descs, vq_size) < 0)) {
 			ret = VIRTIO_CRYPTO_BADMSG;
 			goto error_exit;
 		}
@@ -1598,7 +1598,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
 			op->sym->m_dst->data_off = 0;
 
 			if (unlikely(vhost_crypto_process_one_req(vcrypto, vq,
-					op, head, desc_idx)) < 0)
+					op, head, desc_idx) < 0))
 				break;
 		}
 
-- 
2.14.5


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code
  2019-05-15 16:19 [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code Fan Zhang
@ 2019-06-17  9:26 ` Kovacevic, Marko
  2019-06-20  9:46 ` Maxime Coquelin
  2019-06-20  9:59 ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Kovacevic, Marko @ 2019-06-17  9:26 UTC (permalink / raw)
  To: Zhang, Roy Fan, dev; +Cc: maxime.coquelin, Zhang, Roy Fan, stable

> Subject: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code
> 
> This patch fixes a few same class bugs that causes the logically dead code in
> vhost_crypto.
> 
> Coverity issue: 277236
> Coverity issue: 277233
> Coverity issue: 277220
> Coverity issue: 277214
> 
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  lib/librte_vhost/vhost_crypto.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
> index 0edf12d52..069b56108 100644
> --- a/lib/librte_vhost/vhost_crypto.c
> +++ b/lib/librte_vhost/vhost_crypto.c
> @@ -1024,7 +1024,7 @@ prepare_sym_chain_op(struct vhost_crypto
> *vcrypto, struct rte_crypto_op *op,
>  		}
>  		if (unlikely(copy_data(rte_pktmbuf_mtod(m_src, uint8_t *),
>  				vc_req, &desc, chain->para.src_data_len,
> -				nb_descs, vq_size)) < 0) {
> +				nb_descs, vq_size) < 0)) {
>  			ret = VIRTIO_CRYPTO_BADMSG;
>  			goto error_exit;
>  		}
> @@ -1598,7 +1598,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t
> qid,
>  			op->sym->m_dst->data_off = 0;
> 
>  			if (unlikely(vhost_crypto_process_one_req(vcrypto,
> vq,
> -					op, head, desc_idx)) < 0)
> +					op, head, desc_idx) < 0))
>  				break;
>  		}

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code
  2019-05-15 16:19 [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code Fan Zhang
  2019-06-17  9:26 ` Kovacevic, Marko
@ 2019-06-20  9:46 ` Maxime Coquelin
  2019-06-20  9:59 ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2019-06-20  9:46 UTC (permalink / raw)
  To: Fan Zhang, dev; +Cc: stable



On 5/15/19 6:19 PM, Fan Zhang wrote:
> This patch fixes a few same class bugs that causes the
> logically dead code in vhost_crypto.
> 
> Coverity issue: 277236
> Coverity issue: 277233
> Coverity issue: 277220
> Coverity issue: 277214
> 
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   lib/librte_vhost/vhost_crypto.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
> index 0edf12d52..069b56108 100644
> --- a/lib/librte_vhost/vhost_crypto.c
> +++ b/lib/librte_vhost/vhost_crypto.c
> @@ -1024,7 +1024,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
>   		}
>   		if (unlikely(copy_data(rte_pktmbuf_mtod(m_src, uint8_t *),
>   				vc_req, &desc, chain->para.src_data_len,
> -				nb_descs, vq_size)) < 0) {
> +				nb_descs, vq_size) < 0)) {
>   			ret = VIRTIO_CRYPTO_BADMSG;
>   			goto error_exit;
>   		}
> @@ -1598,7 +1598,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
>   			op->sym->m_dst->data_off = 0;
>   
>   			if (unlikely(vhost_crypto_process_one_req(vcrypto, vq,
> -					op, head, desc_idx)) < 0)
> +					op, head, desc_idx) < 0))
>   				break;
>   		}
>   
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code
  2019-05-15 16:19 [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code Fan Zhang
  2019-06-17  9:26 ` Kovacevic, Marko
  2019-06-20  9:46 ` Maxime Coquelin
@ 2019-06-20  9:59 ` Maxime Coquelin
  2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2019-06-20  9:59 UTC (permalink / raw)
  To: Fan Zhang, dev; +Cc: stable



On 5/15/19 6:19 PM, Fan Zhang wrote:
> This patch fixes a few same class bugs that causes the
> logically dead code in vhost_crypto.
> 
> Coverity issue: 277236
> Coverity issue: 277233
> Coverity issue: 277220
> Coverity issue: 277214
> 
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   lib/librte_vhost/vhost_crypto.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied to dpdk-next-virtio/master.

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 16:19 [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code Fan Zhang
2019-06-17  9:26 ` Kovacevic, Marko
2019-06-20  9:46 ` Maxime Coquelin
2019-06-20  9:59 ` Maxime Coquelin

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox