From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC17C3A5A2 for ; Tue, 3 Sep 2019 08:47:51 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id E98B722CF8 for ; Tue, 3 Sep 2019 08:47:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E98B722CF8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1D0A71E89A; Tue, 3 Sep 2019 10:47:50 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BFF001E895 for ; Tue, 3 Sep 2019 10:47:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2019 01:47:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,462,1559545200"; d="scan'208";a="266223853" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.4]) ([10.237.221.4]) by orsmga001.jf.intel.com with ESMTP; 03 Sep 2019 01:47:45 -0700 To: David Marchand Cc: dev References: <1566214919-32250-1-git-send-email-david.marchand@redhat.com> <1566214919-32250-3-git-send-email-david.marchand@redhat.com> <064b2195-434d-d76f-a59c-8fad6d235f58@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <6fd3bec6-15e4-33ed-4bd2-88d2ecaf6706@intel.com> Date: Tue, 3 Sep 2019 09:47:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/3/2019 9:06 AM, David Marchand wrote: > On Mon, Sep 2, 2019 at 4:29 PM Ferruh Yigit wrote: >> >> On 8/19/2019 12:41 PM, David Marchand wrote: >>> The function rte_log_register_type_and_pick_level() fills a gap for >>> dynamically loaded code (especially drivers) who would not pick up >>> the log level passed at startup. >>> >>> Let's promote it to stable and export it for use by drivers via >>> a wrapper. >>> >>> Signed-off-by: David Marchand >>> --- >>> lib/librte_eal/common/include/rte_log.h | 12 ++++++++---- >>> lib/librte_eal/rte_eal_version.map | 8 +++++++- >>> 2 files changed, 15 insertions(+), 5 deletions(-) >>> >>> diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h >>> index cbb4184..c3aff00 100644 >>> --- a/lib/librte_eal/common/include/rte_log.h >>> +++ b/lib/librte_eal/common/include/rte_log.h >>> @@ -209,9 +209,6 @@ int rte_log_cur_msg_logtype(void); >>> int rte_log_register(const char *name); >>> >>> /** >>> - * @warning >>> - * @b EXPERIMENTAL: this API may change without prior notice >>> - * >>> * Register a dynamic log type and try to pick its level from EAL options >>> * >>> * rte_log_register() is called inside. If successful, the function tries >>> @@ -227,9 +224,16 @@ int rte_log_register(const char *name); >>> * - >=0: the newly registered log type >>> * - <0: rte_log_register() error value >>> */ >>> -__rte_experimental >>> int rte_log_register_type_and_pick_level(const char *name, uint32_t level_def); >> >> +1 to remove experimental from the API. >> >>> >>> +#define RTE_LOG_REGISTER(token, name, level, fallback) \ >>> +RTE_INIT(token##_init) \ >> >> Does it still need to be an init time call? >> Since it is dynamic now it can be during probe, even log name can be a paramter >> to the "struct rte_driver" and log can be registered automatically during probe, >> not sure how complex it becomes. > > This would not work with non driver components built as shared > libraries (unless they have an explicit init symbol in the dpdk init > flow). Right. > > The drivers can register multiple log types so this would have to be handled. > We would touch the struct rte_driver which is embedded in other > objects like rte_pci_driver, breaking the abi. Yes they may require multiple logs, +abi break, so forget about it. > > >> >>> +{ \ >>> + token = rte_log_register_type_and_pick_level(name, level); \ >>> + if (token < 0) \ >> >> The failure can be because component can try to register existing log name, or >> there is no enough memory, do you think does it worth to do log, or some >> additional work if component is trying to register existing log name? > > Yes, I can raise a warning log (using RTE_LOGTYPE_EAL type), since > duplicates are not supposed to happen. I was checking if we can detect the error from duplication, there can be a defect it that logic: Call trace is: rte_log_register_type_and_pick_level type = rte_log_register(name); id = rte_log_lookup(name); if (id >= 0) return id if (type < 0) return type "type > 0" for the duplication case but error check only checks if "type < 0" > > >> >>> + token = fallback; \ >> >> Does the 'fallback' needs to be provided by user, it looks like everyone will >> just copy/paste 'RTE_LOGTYPE_PMD' for drivers, and does it really needs to be >> configurable since it is fallback. > > This series only touches drivers, but I expected other components > would use this macro later. > I can add a RTE_PMD_REGISTER_LOG macro that hides the RTE_LOGTYPE_PMD > fallback value. > > >> >> Why not provide a hardcoded type for the failure case? And for that case perhaps >> create a more generic logtype, something like "RTE_LOGTYPE_FALLBACK" so that it >> can be as it is from all components? >> > > I prefer to map all drivers to a logtype that means something, like > RTE_LOGTYPE_PMD. In that manner it make sense agreed, but previously drivers were using 'RTE_LOGTYPE_PMD' instead of having their own log types, Stephen did some work to replace the 'RTE_LOGTYPE_PMD' so that it can be deprecated, starting to use it again as fallback may lead drivers using it again as log type in their drivers, may they wouldn't but this is what I concern. Something with name 'RTE_LOGTYPE_FALLBACK' clear to not use as default logtype in drivers. > > Having a "fallback" could be used for all components, but this would > have to be a static logtype and adding one is not possible without > breaking the abi (static entries are < 32 and all values are used). There is a gap between 'RTE_LOGTYPE_GSO' & 'RTE_LOGTYPE_USER1' ... > > > -- > David Marchand >