From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 439EFC432C0 for ; Wed, 27 Nov 2019 18:07:33 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 9109B20872 for ; Wed, 27 Nov 2019 18:07:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="ONU+nGxP"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="VqLc6fEE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9109B20872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D86E91BE9F; Wed, 27 Nov 2019 19:07:31 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 8FF491BE9A; Wed, 27 Nov 2019 19:07:30 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4B59B597; Wed, 27 Nov 2019 13:07:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 27 Nov 2019 13:07:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=pv3n7T0epaNX714E+BzMcuctxQdAMw6AV6SjXXN6qGM=; b=ONU+nGxPnCM+ 0+8ozPKlrM/PbUTYbctIN6X+LVxfNMUY8WPaDZwQen5aFlRhO2OOdrlzc0noax6p QyNMD7PoanCMDmahu4HmnVvvgDHc6Oc2PrSNfrIAZJIYUX78RH3R/Wj5Jmu60EIa QVyAsI8GHWyTSFrYcfAxZRdWyyVK0hs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=pv3n7T0epaNX714E+BzMcuctxQdAMw6AV6SjXXN6q GM=; b=VqLc6fEE4pj4lzyFibpNxKSvdjqNj7ZOupFpZv8tsZa14MDtpDdAgSHPa RIxOCc+85O7X9+2HeXaZbAetlDPEks7gnpVhNIM5ioPilsHMy5KLjnGvYv9RQ58/ V+pOkYNuE/DWL2reAmbmE8zW4SHovfQEbxvGDhu1tWg6RNjZInBFoe21CIs44qcI zM+81+kUkR9VNyBucvBU0e6bI1oHH/Vh7MJ5+CfGC/0CDb11oHtPHA0qLq16bTEa yX1UQOOlTYk8VqL3HgbOA58BDEe98czwbQosvhf3JD32ey3t+IfX4nrFg1I5xEnl V94A/f6EHcrUrTtU57hysa1PH+sLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeihedguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AD89680059; Wed, 27 Nov 2019 13:07:26 -0500 (EST) From: Thomas Monjalon To: Pavan Nikhilesh Cc: dev@dpdk.org, Jerin Jacob , Jerin Jacob , dpdk stable Date: Wed, 27 Nov 2019 19:07:18 +0100 Message-ID: <7192014.iqHGnQxl1n@xps> In-Reply-To: References: <20191127123647.7596-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] event/octeontx: fix partial Rx packet handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/11/2019 14:32, Jerin Jacob: > On Wed, Nov 27, 2019 at 9:36 PM wrote: > > > > From: Pavan Nikhilesh > > > > When net/octeontx is connected to event/octeontx as an event Rx adapter, > > PKI aka 'net/octeontx' can forward packets directly to SSO aka > > 'event/octeontx'. > > When pumping traffic to PKI if flow control is disabled internal FIFOs > > might be overrun causing partial l2 packets to be enqueued. > > SSO receives <31:0> TAG tag calculated by PKI, in normal cases <31:28> > > is always 0 which signifies RTE_EVENT_TYPE_ETHDEV. But in case of > > partial received packets PKI sets the <31:0> TAG as 0xFFFFFFFF which > > is an invalid event type. > > > > Add a check to see if TAG is 0xFFFFFFFF and free the partial receive > > packet. > > > > Cc: stable@dpdk.org > > Fixes: d0d654986018 ("net/octeontx: support event Rx adapter") > > Corrected the Cc: order. > > > > > Signed-off-by: Pavan Nikhilesh > > Acked-by: Jerin Jacob > Applied to dpdk-next-eventdev/master. Thanks. > > @Thomas, It is possible to pull this patch from next-eventdev? Applied, thanks