From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C877C31E44 for ; Fri, 14 Jun 2019 07:35:26 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 0CD502080A for ; Fri, 14 Jun 2019 07:35:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="ZBsGvnPr"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="1nbUtbZt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CD502080A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 430361D4C5; Fri, 14 Jun 2019 09:35:25 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 136A21D4C1 for ; Fri, 14 Jun 2019 09:35:23 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 82E68220A5; Fri, 14 Jun 2019 03:35:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 14 Jun 2019 03:35:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=k0X3R++qWNtETnkStE2vhEw54vwBsieK064lbInC3hQ=; b=ZBsGvnPraJ2N MaJJEuRT+Ihg02tZFHbZ4eFDX3yMSW8sB6aakPLC1d+iBb1bg1Dj//43sD/ih1/p 3qyWe0aEzcdcbYmpBuBGK3RaR1sq22nmH4N7+9WOZKpxAld4k3W1WXW+usiyDhi9 D0rEqtgrQR0jVzRZSX4RrUI/X0eXWRE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=k0X3R++qWNtETnkStE2vhEw54vwBsieK064lbInC3 hQ=; b=1nbUtbZtm3PQTB+yNY6BXNm3UdfiXrDWAngH9oHR+AhL37G6Iq1T9OfdA 31hTm0gnaVdRUkhaBARtjeSNCpX8yM5+2I1p6JBrouILZaMycOQV/1dAr/4AUuEJ nQ0HCa3AKmjFI6pywZQypkDa3KsU3F1iLAiMzO7Ium62i4NBdsIfz0b8JYuO7VAX yI0P++vq/iadNvYAEJn5k6bALSStUKBlsqv1IFzE5gNws4R+crvRXzTZKpOtas5A aUp3iokTC6BvcAXWNM6+/0N3E9rAwK2a7O+eYMIE5OC6WqTM+Uh0mQi01ci0xK4K UkRiB/mWp1DpbUQPF7AfikBs2yNpQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudeitddguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepuddviedrvdduuddruddvjedrleeinecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (om126211127096.13.openmobile.ne.jp [126.211.127.96]) by mail.messagingengine.com (Postfix) with ESMTPA id 126298005C; Fri, 14 Jun 2019 03:35:18 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, David Marchand , "Yigit, Ferruh" , Bruce Richardson , Gaetan Rivet Date: Fri, 14 Jun 2019 16:35:13 +0900 Message-ID: <7362312.7gMR3l8ZAv@xps> In-Reply-To: References: <20190402185105.2852-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: fix TOCTOU issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/06/2019 16:16, David Marchand: > On Tue, Apr 2, 2019 at 8:51 PM Stephen Hemminger > wrote: > > > Using access followed by open causes a static analysis warning > > about Time of check versus Time of use. Also, access() and > > open() have different UID permission checks. > > > > This is not a serious problem; but easy to fix by using errno instead. > > > > Coverity issue: 300870 > > Fixes: 4a928ef9f611 ("bus/pci: enable write combining during mapping") Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger > > > Reviewed-by: David Marchand Applied, thanks