From: Xiaoyu Min <jackmin@mellanox.com>
To: ferruh.yigit@intel.com, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v4 1/4] app/testpmd: put set vxlan/nvgre help in filters section
Date: Wed, 17 Jul 2019 20:27:07 +0800 [thread overview]
Message-ID: <7655e72dbc4cdf0247c082823ed7ea09b82a1b1b.1563365940.git.jackmin@mellanox.com> (raw)
In-Reply-To: <cover.1563365940.git.jackmin@mellanox.com>
The help string of set vxlan*, set nvgre* are in "config"" section.
But they acutally do not alter NIC or testpmd's configuration and
they will be used by "flow" command later.
Put them in "filters" section along with "flow" command seems more
reasonable.
Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
---
app/test-pmd/cmdline.c | 55 +++++++++++++++++++++---------------------
1 file changed, 28 insertions(+), 27 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 01dd45f27c..f7eb8a7776 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -733,33 +733,6 @@ static void cmd_help_long_parsed(void *parsed_result,
"show port (port_id) queue-region\n"
" show all queue region related configuration info\n\n"
- "vxlan ip-version (ipv4|ipv6) vni (vni) udp-src"
- " (udp-src) udp-dst (udp-dst) ip-src (ip-src) ip-dst"
- " (ip-dst) eth-src (eth-src) eth-dst (eth-dst)\n"
- " Configure the VXLAN encapsulation for flows.\n\n"
-
- "vxlan-with-vlan ip-version (ipv4|ipv6) vni (vni)"
- " udp-src (udp-src) udp-dst (udp-dst) ip-src (ip-src)"
- " ip-dst (ip-dst) vlan-tci (vlan-tci) eth-src (eth-src)"
- " eth-dst (eth-dst)\n"
- " Configure the VXLAN encapsulation for flows.\n\n"
-
- "vxlan-tos-ttl ip-version (ipv4|ipv6) vni (vni) udp-src"
- " (udp-src) udp-dst (udp-dst) ip-tos (ip-tos) ip-ttl (ip-ttl)"
- " ip-src (ip-src) ip-dst (ip-dst) eth-src (eth-src)"
- " eth-dst (eth-dst)\n"
- " Configure the VXLAN encapsulation for flows.\n\n"
-
- "nvgre ip-version (ipv4|ipv6) tni (tni) ip-src"
- " (ip-src) ip-dst (ip-dst) eth-src (eth-src) eth-dst"
- " (eth-dst)\n"
- " Configure the NVGRE encapsulation for flows.\n\n"
-
- "nvgre-with-vlan ip-version (ipv4|ipv6) tni (tni)"
- " ip-src (ip-src) ip-dst (ip-dst) vlan-tci (vlan-tci)"
- " eth-src (eth-src) eth-dst (eth-dst)\n"
- " Configure the NVGRE encapsulation for flows.\n\n"
-
, list_pkt_forwarding_modes()
);
}
@@ -1137,6 +1110,34 @@ static void cmd_help_long_parsed(void *parsed_result,
"flow isolate {port_id} {boolean}\n"
" Restrict ingress traffic to the defined"
" flow rules\n\n"
+
+ "set vxlan ip-version (ipv4|ipv6) vni (vni) udp-src"
+ " (udp-src) udp-dst (udp-dst) ip-src (ip-src) ip-dst"
+ " (ip-dst) eth-src (eth-src) eth-dst (eth-dst)\n"
+ " Configure the VXLAN encapsulation for flows.\n\n"
+
+ "set vxlan-with-vlan ip-version (ipv4|ipv6) vni (vni)"
+ " udp-src (udp-src) udp-dst (udp-dst) ip-src (ip-src)"
+ " ip-dst (ip-dst) vlan-tci (vlan-tci) eth-src (eth-src)"
+ " eth-dst (eth-dst)\n"
+ " Configure the VXLAN encapsulation for flows.\n\n"
+
+ "set vxlan-tos-ttl ip-version (ipv4|ipv6) vni (vni) udp-src"
+ " (udp-src) udp-dst (udp-dst) ip-tos (ip-tos) ip-ttl (ip-ttl)"
+ " ip-src (ip-src) ip-dst (ip-dst) eth-src (eth-src)"
+ " eth-dst (eth-dst)\n"
+ " Configure the VXLAN encapsulation for flows.\n\n"
+
+ "set nvgre ip-version (ipv4|ipv6) tni (tni) ip-src"
+ " (ip-src) ip-dst (ip-dst) eth-src (eth-src) eth-dst"
+ " (eth-dst)\n"
+ " Configure the NVGRE encapsulation for flows.\n\n"
+
+ "set nvgre-with-vlan ip-version (ipv4|ipv6) tni (tni)"
+ " ip-src (ip-src) ip-dst (ip-dst) vlan-tci (vlan-tci)"
+ " eth-src (eth-src) eth-dst (eth-dst)\n"
+ " Configure the NVGRE encapsulation for flows.\n\n"
+
);
}
--
2.21.0
next prev parent reply other threads:[~2019-07-17 12:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 15:37 [dpdk-dev] [PATCH 0/2] app/testpmd: support raw encap/decap actions Xiaoyu Min
2019-06-24 15:37 ` [dpdk-dev] [PATCH 1/2] " Xiaoyu Min
2019-06-24 15:37 ` [dpdk-dev] [PATCH 2/2] app/testpmd: support MPLS's TC and S bits Xiaoyu Min
2019-07-02 13:53 ` [dpdk-dev] [PATCH v2 0/3] app/testpmd: support raw encap/decap actions Xiaoyu Min
2019-07-02 13:53 ` [dpdk-dev] [PATCH v2 1/3] " Xiaoyu Min
2019-07-08 17:41 ` Ferruh Yigit
2019-07-09 4:25 ` Jack Min
2019-07-02 13:53 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: support MPLS's TC and S bits Xiaoyu Min
2019-07-02 13:53 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: add GRE key for raw encap/decap Xiaoyu Min
2019-07-10 10:43 ` [dpdk-dev] [PATCH v3 0/3] app/testpmd: support raw encap/decap actions Xiaoyu Min
2019-07-10 10:43 ` [dpdk-dev] [PATCH v3 1/3] " Xiaoyu Min
2019-07-16 17:41 ` Ferruh Yigit
2019-07-17 1:24 ` Jack Min
2019-07-17 8:20 ` Ferruh Yigit
2019-07-17 9:18 ` Jack Min
2019-07-10 10:43 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: support MPLS's TC and S bits Xiaoyu Min
2019-07-10 10:43 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: add GRE key for raw encap/decap Xiaoyu Min
2019-07-17 12:27 ` [dpdk-dev] [PATCH v4 0/4] app/testpmd: support raw encap/decap actions Xiaoyu Min
2019-07-17 12:27 ` Xiaoyu Min [this message]
2019-07-17 12:27 ` [dpdk-dev] [PATCH v4 2/4] " Xiaoyu Min
2019-07-17 12:27 ` [dpdk-dev] [PATCH v4 3/4] app/testpmd: support MPLS's TC and S bits Xiaoyu Min
2019-07-17 12:27 ` [dpdk-dev] [PATCH v4 4/4] app/testpmd: add GRE key for raw encap/decap Xiaoyu Min
2019-07-17 16:31 ` [dpdk-dev] [PATCH v4 0/4] app/testpmd: support raw encap/decap actions Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7655e72dbc4cdf0247c082823ed7ea09b82a1b1b.1563365940.git.jackmin@mellanox.com \
--to=jackmin@mellanox.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).