From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D06CA9ECF for ; Fri, 1 Nov 2019 22:50:43 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id BCB76217D9 for ; Fri, 1 Nov 2019 22:50:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="Sf1siPNs"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="unpaPCVb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCB76217D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5F501E886; Fri, 1 Nov 2019 23:50:41 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id C9D1B1E876 for ; Fri, 1 Nov 2019 23:50:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4EF294E7; Fri, 1 Nov 2019 18:50:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 01 Nov 2019 18:50:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BZ7g/8YCHgq7+grWsJap6a09gLQSqYRuS8RtUCh+t+4=; b=Sf1siPNsrtw+ 6+VLy/Nhv1666Gu7IG97pmuKU1THT0uIyCtQCuwdZ5TXQZKo8nfz2laH8knvfyYE fWPXKjhINOq2cWqgivkmk1vlxunL5PE4Ft8nJ/EMiTckRlpVfcdopmyGogfbJiNR yLnvE/Ax9uJ6vGn6DBi3tfrsX4aJjFw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=BZ7g/8YCHgq7+grWsJap6a09gLQSqYRuS8RtUCh+t +4=; b=unpaPCVbGNyOoV82iumfUsiAqberl3E0MHyojzlffjMQ1u5K+xLpxVfCu mbXZ1WxyG/WiMLTm56tIsEQVkr0s7xYYwQ5FvA8Br2KHQKYHl7Vl6C0vZqahySsz xTfDGOU7o4gwS9ChN0vKMNB218glrRE2E75tkmRRUrFUisXgifHTnva0sbDSpx81 ewdBO6lq+A2dFN+8HOhBC+jTOfgFI4FaXt263gwaKC3HAlxLGz7DBksH8ksfJRH5 A/yFXeNSiJI7nDW5PvZ6uHlWy6OQ8c8O4fiEa9mIbU2JqV3wqZkSU3eeOqkzkUDw psTRiwOsLdHaV2JJHni+aMM5/Z1FA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddtkedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedriedrudegledruddugeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id F2A6280063; Fri, 1 Nov 2019 18:50:36 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , Jerin Jacob Kollanukkaran Date: Fri, 01 Nov 2019 23:50:32 +0100 Message-ID: <7864060.WUCCvOm3Si@xps> In-Reply-To: References: <20191029050312.2715-1-pbhagavatula@marvell.com> <56162614.NpA4zj6keT@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v15 3/7] ethdev: add validation to offloads set by PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 31/10/2019 17:44, Pavan Nikhilesh Bhagavatula: > >29/10/2019 16:37, pbhagavatula@marvell.com: > >> From: Pavan Nikhilesh > >> +{ > >> + uint64_t offloads_diff = req_offloads ^ set_offloads; > >> + uint64_t offloads_req_diff, offloads_set_diff; > >> + uint64_t offload; > >> + uint8_t err = 0; > >> + > >> + /* Check if any offload is advertised but not enabled. */ > > > >Not sure "advertised" is the right word here. > > Don't PMDs advertise their capabilities/offloads through dev_info?. Yes