From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82D62C7618B for ; Tue, 23 Jul 2019 11:34:35 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 1BD4A20644 for ; Tue, 23 Jul 2019 11:34:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BD4A20644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B99D1BFDB; Tue, 23 Jul 2019 13:34:34 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CF1FC1BFD4 for ; Tue, 23 Jul 2019 13:34:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2019 04:34:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,298,1559545200"; d="scan'208";a="188823300" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga001.fm.intel.com with ESMTP; 23 Jul 2019 04:34:30 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.45]) by IRSMSX107.ger.corp.intel.com ([169.254.10.251]) with mapi id 14.03.0439.000; Tue, 23 Jul 2019 12:34:29 +0100 From: "Parthasarathy, JananeeX M" To: "Richardson, Bruce" , Thomas Monjalon CC: "dev@dpdk.org" , Michael Santana Francisco , Aaron Conole , Hari Kumar Vemula , "Pattan, Reshma" , "Mcnamara, John" , "Kovacevic, Marko" , David Marchand Thread-Topic: [dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide Thread-Index: AQHVNcpGI4iV1YtytEyIkT5COIJx+abClAsAgBOsu4CAAFvTAIAAEK+AgAFtwgA= Date: Tue, 23 Jul 2019 11:34:29 +0000 Message-ID: <7AE31235A30B41498D1C31348DC858BD67B6AD31@IRSMSX103.ger.corp.intel.com> References: <1549103306-9644-1-git-send-email-hari.kumarx.vemula@intel.com> <7AE31235A30B41498D1C31348DC858BD67B6A60E@IRSMSX103.ger.corp.intel.com> <6911600.pdS3C77OGP@xps> <20190722135316.GC289@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190722135316.GC289@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, >-----Original Message----- >From: Bruce Richardson [mailto:bruce.richardson@intel.com] >Sent: Monday, July 22, 2019 7:23 PM >To: Thomas Monjalon >Cc: Parthasarathy, JananeeX M ; >dev@dpdk.org; Michael Santana Francisco ; Aaron >Conole ; Hari Kumar Vemula >; Pattan, Reshma >; Mcnamara, John ; >Kovacevic, Marko ; David Marchand > >Subject: Re: [dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide > >On Mon, Jul 22, 2019 at 02:53:34PM +0200, Thomas Monjalon wrote: >> 22/07/2019 14:39, Parthasarathy, JananeeX M: >> >From: Michael Santana Francisco [mailto:msantana@redhat.com] >> > >On Mon, Jul 8, 2019 at 4:18 PM Aaron Conole >wrote: >> > >> Thomas Monjalon writes: >> > >> >> +Building and running the unit tests >> > >> >> +----------------------------------- >> > >> >> + >> > >> >> +* Create the meson build output folder using the following >command:: >> > >> >> + >> > >> >> + $ meson >> > >> >> + >> > >> >> +* Enter into build output folder, which was created by above >command:: >> > >> >> + >> > >> >> + $ cd build >> > >> > >> > >> > Should be the same as above: >> > >> > Will change accordingly. >> > >> > >> > >> > >> >> + >> > >> >> +* Compile DPDK using command:: >> > >> >> + >> > >> >> + $ ninja >> > >> > >> > >> > Do we really need to repeat above basic steps? >> > >> > Would be easier to just reference another guide about meson. >> > >> > I think doc/build-sdk-meson.txt should be moved to .rst. >> > >> >> > >> +1 >> > >> > This doc helps to run UT, having basic steps in same page will help us= er to >go through together and execute the same. >> > Just for few lines moving back and forth to different pages might be b= it >confusing. >> > Anyway still if you would prefer to remove these then only 2 sections = will >be available in this doc. >> > Please let us know if it is ok. >> >> I think it is better to avoid repetition. >> >> >> > >> >> +* Multiple paths:: >> > >> >> + >> > >> >> + $ CFLAGS=3D-I/path1 -I/path2 meson build >> > >> > >> > >> > Some quotes are missing to set multiple paths. >> > >> > Is meant here? >> >> I am just saying that space-separated value require some quotes. >> >> > >> >> +Below are some examples that show how to export libraries and >> > >> >> +their header paths. >> > >> >> + >> > >> >> +To specify a single library at a time:: >> > >> >> + >> > >> >> + $ export LIBRARY_PATH=3D/root/wireless_libs/zuc/ >> > >> >> + $ CFLAGS=3D-I/root/wireless_libs/zuc/include meson build >> > >> >> + >> > >> >> +To specify multiple libraries at a time:: >> > >> >> + >> > >> >> + $ export LIBRARY_PATH=3D/path/zuc/:/path/libsso_kasumi/buil= d/ >> > >> >> + $ CFLAGS=3D-I/path/zuc/include \ >> > >> >> + -I/path/libsso_kasumi/include \ >> > >> >> + meson build >> > >> > >> > >> > Why export is used for LIBRARY_PATH and not CFLAGS? >> > >> > I think both variables can be exported or prepend the meson >command? >> > >> > CFLAGS given in meson command works and also CFLAGS can be >exported. >> > LIBRARY_PATH cannot be prepended to meson command. We tried but it >is not reflecting the required values. >> > Environment variables set using export is considered and not as comman= d >line args of meson command. >> >> Please we need to understand why LIBRARY_PATH is not working when >> preprended in the meson command. >> Do you have more informations? >> > >Rather than using the environment, one can also use "-Dc_args=3D'...' >-Dc_link_args=3D'...'" when calling meson. > >Otherwise, I agree with Thomas, we should find out why the LIBRARY_PATH >doesn't work when passed in directly. I'm not aware of any reason it shoul= dn't >work. > >/Bruce As per our earlier analysis, =20 LDFLAGS was not supported earlier in meson command. find_library() is used to check whether the external dependency library exi= sts or not in order to configure the build. This function uses the standard system path to check existence of library, = or else LIBRARY_PATH can be used as environment variable for custom paths. LIBRARY_PATH is not supported directly (not a build configure option). Only recently we can observe that LDFLAGS support is included in meson and = linker options can be provided using LDFLAGS. $ CFLAGS=3D-fsomething LDFLAGS=3D-Wl,--linker-flag meson Although LDFLAGS can be used and build configuration gets updated in LINK_A= RGS, 'dependencies' option of static_library and shared_library() should be an o= bject which is return value from dependency()/find_library(). Due to use of find_library() currently, we need to set the environment vari= able. Regards M.P.Jananee