From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7304C433B4 for ; Tue, 20 Apr 2021 02:26:21 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 30F74611F0 for ; Tue, 20 Apr 2021 02:26:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30F74611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D1E041448; Tue, 20 Apr 2021 04:26:20 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id C0F2840688 for ; Tue, 20 Apr 2021 04:26:18 +0200 (CEST) Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FPSCT09kVzmdRZ; Tue, 20 Apr 2021 10:23:17 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Tue, 20 Apr 2021 10:26:11 +0800 To: Thomas Monjalon CC: , , , , , , References: <1616830818-3127-1-git-send-email-humin29@huawei.com> <1616830818-3127-2-git-send-email-humin29@huawei.com> <1675114.mf6Gbu22uX@thomas> From: "Min Hu (Connor)" Message-ID: <7cd793c6-7a1e-f3dd-cf53-9b399ca03068@huawei.com> Date: Tue, 20 Apr 2021 10:26:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <1675114.mf6Gbu22uX@thomas> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 1/3] examples/flow_classify: fix check of port and core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/4/20 9:08, Thomas Monjalon дµÀ: > 27/03/2021 08:40, Min Hu (Connor): >> fix check of port and core in flow_classify example. >> >> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") >> Cc: stable@dpdk.org >> >> Signed-off-by: Min Hu (Connor) >> --- >> RTE_ETH_FOREACH_DEV(port) >> - if (rte_eth_dev_socket_id(port) > 0 && >> + if (rte_eth_dev_socket_id(port) >= 0 && >> rte_eth_dev_socket_id(port) != (int)rte_socket_id()) { >> printf("\n\n"); >> printf("WARNING: port %u is on remote NUMA node\n", > > Please explain which case is broken and why. > If I understand well, we don't detect remote NUMA if not running on first socket. > Hi, the code is this: ************************************************************************* /* * Check that the port is on the same NUMA node as the polling thread * for best performance. */ RTE_ETH_FOREACH_DEV(port) if (rte_eth_dev_socket_id(port) > 0 && rte_eth_dev_socket_id(port) != (int)rte_socket_id()) { printf("\n\n"); printf("WARNING: port %u is on remote NUMA node\n", port); printf("to polling thread.\n"); printf("Performance will not be optimal.\n"); } printf("\nCore %u forwarding packets. ", rte_lcore_id()); printf("[Ctrl+C to quit]\n"); ************************************************************************* According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. For example in flow_classify: ./build/flow_classify -w 0000:7d:00.1 -l 93 Here: 0000:7d:00.1 is on numa node 0. core 93 is on numa node 3. the two are not in same numa node, but no warning gives out in old codes. Well, using this patch, we can get the waring. Thanks, Thomas. > > . >