DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Harman Kalra <hkalra@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Vamsi Attunuru <vattunuru@marvell.com>,
	 dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality
Date: Mon, 17 Feb 2020 15:19:53 +0000
Message-ID: <7d55c814-0a93-055b-dda6-c18041ec8d1a@intel.com> (raw)
In-Reply-To: <20200217150648.GB23753@outlook.office365.com>

On 2/17/2020 3:06 PM, Harman Kalra wrote:
> On Mon, Feb 17, 2020 at 02:54:13PM +0000, Ferruh Yigit wrote:
>> On 2/17/2020 2:35 PM, Harman Kalra wrote:
>>> On Mon, Feb 17, 2020 at 01:21:13PM +0000, Ferruh Yigit wrote:
>>>> External Email
>>>>
>>>> ----------------------------------------------------------------------
>>>> On 2/15/2020 8:35 AM, Harman Kalra wrote:
>>>>> PTP functionality has been broken after a change in kernel
>>>>> where enum npc_kpu_lc_ltype is change to allow adjustment of
>>>>> LTYPE_MASK to detect all types of IP headers.
>>>>> Syncing the required changes in DPDK to fix the issue.
>>>>
>>>> Hi Harman,
>>>>
>>>> Can you please provide references for,
>>>> - What is the kernel commit causing the mentioned change?
>>>> - After this change which version of the kernel supported by the PMD?
>>>
>>> Hi Ferruh
>>> The kernel change I was refering to was in our internel kernel repo
>>> and those kernel changes have not been upstreamed yet. Currently its part
>>> of our marvell SDK version SDK-10.3.1.x.
>>
>> Got it, what is the dependency of the PMD to the Linux kernel? And does the PMD
>> works with upstream kernels?
> 
> Yes, for basic functionality PMD works fine with upstreamed kernel but for
> supporting some advanced features like PTP, kernel changes are yet to be
> upstreamed. Our kernel driver for octeontx2 PMD:
> https://github.com/torvalds/linux/tree/master/drivers/net/ethernet/marvell/octeontx2/af
> Kernel upstreaming activity is not in same pace as DPDK.

Is the marvell SDK code in a public repo? If so can you provide the details of
the kernel changes in that repo? It is good to have some reference on the matter.

> 
> Thanks
> Harman
>>
>>>
>>> Thanks
>>> Harman
>>>
>>>>
>>>>>
>>>>> Fixes: b5dc3140448e ("net/octeontx2: support base PTP")
>>>>> Cc: stable@dpdk.org
>>>>>
>>>>> Signed-off-by: Harman Kalra <hkalra@marvell.com>
>>>>> ---
>>>>>  drivers/common/octeontx2/hw/otx2_npc.h | 4 ++--
>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/common/octeontx2/hw/otx2_npc.h b/drivers/common/octeontx2/hw/otx2_npc.h
>>>>> index a0536e0ae..3dfc137a3 100644
>>>>> --- a/drivers/common/octeontx2/hw/otx2_npc.h
>>>>> +++ b/drivers/common/octeontx2/hw/otx2_npc.h
>>>>> @@ -201,7 +201,8 @@ enum npc_kpu_lb_ltype {
>>>>>  };
>>>>>  
>>>>>  enum npc_kpu_lc_ltype {
>>>>> -	NPC_LT_LC_IP = 1,
>>>>> +	NPC_LT_LC_PTP = 1,
>>>>> +	NPC_LT_LC_IP,
>>>>>  	NPC_LT_LC_IP_OPT,
>>>>>  	NPC_LT_LC_IP6,
>>>>>  	NPC_LT_LC_IP6_EXT,
>>>>> @@ -209,7 +210,6 @@ enum npc_kpu_lc_ltype {
>>>>>  	NPC_LT_LC_RARP,
>>>>>  	NPC_LT_LC_MPLS,
>>>>>  	NPC_LT_LC_NSH,
>>>>> -	NPC_LT_LC_PTP,
>>>>>  	NPC_LT_LC_FCOE,
>>>>>  };
>>>>>  
>>>>>
>>>>
>>


  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-15  8:35 [dpdk-dev] " Harman Kalra
2020-02-15 14:12 ` Jerin Jacob
2020-02-17 13:21 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-02-17 14:35   ` [dpdk-dev] [EXT] " Harman Kalra
2020-02-17 14:54     ` Ferruh Yigit
2020-02-17 15:06       ` Harman Kalra
2020-02-17 15:19         ` Ferruh Yigit [this message]
2020-02-17 15:30           ` Harman Kalra
2020-02-17 16:17             ` Ferruh Yigit
2020-02-17 16:37               ` Harman Kalra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d55c814-0a93-055b-dda6-c18041ec8d1a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=stable@dpdk.org \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git