From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 524FFC432C0 for ; Tue, 19 Nov 2019 17:38:27 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 6E8F422302 for ; Tue, 19 Nov 2019 17:38:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="sg/s+cVF"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="xZNrlHY4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E8F422302 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF64CA69; Tue, 19 Nov 2019 18:38:24 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 335E5235 for ; Tue, 19 Nov 2019 18:38:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B7F6F740; Tue, 19 Nov 2019 12:38:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 19 Nov 2019 12:38:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Eh23EhKp7XgTuq/OuFO3UELZG6gv6YfTTuR89G6Jq9A=; b=sg/s+cVF0Fam xQwpGHZClRNHruxIiLBFIbtDqlhebYBZLVpari6O988gYZ+J+aIsLObsutv9ul4T Z0085POjlPhodQG0fU2XkUEDGdQBcqP6lzZ/SNMTCZvY/67foCkwQT3y1bZIw2cP jBBPrsD664ujHSyev3v1bXc48m9TfME= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Eh23EhKp7XgTuq/OuFO3UELZG6gv6YfTTuR89G6Jq 9A=; b=xZNrlHY4NTZN+yLwvn6/Z81rFePdufHIbWLzzFIS9ObfCW0uj7CJ1cce9 90zwVlZh2JeDO/eQDuZyVGUvbdMkkzcwMNYpxlvHefFZvqtpsHTZMMDwT2iVzxSD gVeGV3fmszSw4YNqTvc55USw9HevSoBv4aBG4VSsd5uvcikY7GwHRkuijFKxMufA Tj6hzCN7pC+y4UvE4DkEKIqEm1LOQNMEfWsRCGYhkIdFJAMqDw4jMcMTnOK0ZNkf T05GHaBsdXqDHlQvN0EujSxlD7XN8tbJoFiOyJhlwWEDon23q5eX9M40w24kdjl1 bX1vq99gGCk7tanrsgkqPkKQeVURg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudegkedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 56DAC80059; Tue, 19 Nov 2019 12:38:19 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, john.mcnamara@intel.com, ray.kinsella@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com Date: Tue, 19 Nov 2019 18:38:16 +0100 Message-ID: <8286083.4ZIB1RLW8s@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 03/10] buildtools: add ABI update shell script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/11/2019 17:25, Anatoly Burakov: > In order to facilitate mass updating of version files, add a shell > script that recurses into lib/ and drivers/ directories and calls > the ABI version update script. > > Signed-off-by: Anatoly Burakov > Acked-by: Bruce Richardson > --- /dev/null > +++ b/buildtools/update-abi.sh > @@ -0,0 +1,42 @@ > +#!/bin/sh For such script, I think -e is mandatory, so we do not miss any error. It would just require merge following check in the "if": > +# check version string format > +echo $abi_version | grep -q -e "^[[:digit:]]\{1,2\}\.[[:digit:]]\{1,2\}$" > +if [ "$?" -ne 0 ]; then > + # output to stderr > + >&2 echo "ABI version must be formatted as MAJOR.MINOR version" > + exit 1 > +fi