From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12A4C49ED7 for ; Fri, 13 Sep 2019 20:38:46 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 47A9D206A4 for ; Fri, 13 Sep 2019 20:38:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47A9D206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=solarflare.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1720F1F037; Fri, 13 Sep 2019 22:38:45 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6F0BA1EFFA for ; Fri, 13 Sep 2019 22:38:43 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 0F98E340072; Fri, 13 Sep 2019 20:38:42 +0000 (UTC) Received: from [192.168.1.192] (188.242.181.57) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Sep 2019 21:38:18 +0100 To: Ferruh Yigit , "John W. Linville" , Xiaolong Ye , Qi Zhang , Igor Russkikh , "Pavel Belous" , Allain Legacy , Matt Peters , "Ravi Kumar" , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , "Somnath Kotur" , Chas Williams , "Rahul Lakkireddy" , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , "Zyta Szpak" , Liron Himi , Tomasz Duszynski , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Rastislav Cernay , Jan Remes , Alejandro Lucero , Jerin Jacob , Nithin Dabilpuram , "Kiran Kumar K" , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Thomas Monjalon CC: References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com> <1568030331-16526-1-git-send-email-arybchenko@solarflare.com> <1568030331-16526-5-git-send-email-arybchenko@solarflare.com> <66e72de6-11d8-91de-2a72-cea881389d10@intel.com> From: Andrew Rybchenko Message-ID: <82b12b7a-37ad-f570-1874-57792cdca099@solarflare.com> Date: Fri, 13 Sep 2019 23:38:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <66e72de6-11d8-91de-2a72-cea881389d10@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [188.242.181.57] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24908.002 X-TM-AS-Result: No-5.658100-8.000000-10 X-TMASE-MatchedRID: QfHZjzml1E/A46G+uSzVzSLVdThWsHxY69aS+7/zbj+qvcIF1TcLYM7/ vP2uWVRBK/S70kzmfv7rL7s+y7z25R1YpEPWJiyzqJSK+HSPY+/pVMb1xnESMrZk7gsuflVKj78 +1uscT5KM8D+wdieK6sQfEd6vmVeUyEmFyV1v7QwFZev51JnVPXpDIEzkG1RbFujNgNeS9UC/cG KoXiQzpXkO10HjLgnpQpBj3QW86BnPLOaarwAhUwDZzaMAAwI7V447DNvw38btfoYnKQ4rWKPFj JEFr+olA6QGdvwfwZa3sNbcHjySQd0H8LFZNFG76sBnwpOylLPY37VAJxHb3IWAmzvDc83tZHfN UT1cb2Wo5o8m/Wbpiy7QKG86qX3DhA4m97SoAhtqhzTpCBxnRMXt1Ttyv3V05OH+o0fUU/yigEH y7J4S6ylkreA5r24aYnCi5itk3iprD5+Qup1qU37cGd19dSFd X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.658100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24908.002 X-MDID: 1568407122-D0a4YJnyxIZx Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/13/19 7:56 PM, Ferruh Yigit wrote: > On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: >> Enabling/disabling of promiscuous mode is not always successful and >> it should be taken into account to be able to handle it properly. >> >> When correct return status is unclear from driver code, -EAGAIN is used. >> >> Signed-off-by: Andrew Rybchenko > <...> > >> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c >> index aa716f3195..1da22ff866 100644 >> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c >> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c >> @@ -750,37 +750,43 @@ static void >> eth_dev_change_flags(char *if_name, uint32_t flags, uint32_t mask) >> { >> struct ifreq ifr; >> + int ret = 0; >> int s; >> >> s = socket(PF_INET, SOCK_DGRAM, 0); >> if (s < 0) >> - return; >> + return -errno; >> >> strlcpy(ifr.ifr_name, if_name, IFNAMSIZ); >> - if (ioctl(s, SIOCGIFFLAGS, &ifr) < 0) >> + if (ioctl(s, SIOCGIFFLAGS, &ifr) < 0) { >> + ret = -errno; >> goto out; >> + } >> ifr.ifr_flags &= mask; >> ifr.ifr_flags |= flags; >> - if (ioctl(s, SIOCSIFFLAGS, &ifr) < 0) >> + if (ioctl(s, SIOCSIFFLAGS, &ifr) < 0) { >> + ret = -errno; >> goto out; >> + } >> out: >> close(s); >> + return ret; >> } > ../drivers/net/af_xdp/rte_eth_af_xdp.c: In function ‘eth_dev_change_flags’: > ../drivers/net/af_xdp/rte_eth_af_xdp.c:758:10: warning: ‘return’ with a value, > in function returning void [-Wreturn-type] > 758 | return -errno; > | ^ Thanks, but this one is more tricky from build point of view to enable AF_XDP PMD build. Failed to build even with 5.0.0 kernel and headers on Ubuntu 18.04. So, I will rely on your and automation build checks. Will try to fix in the next version.