DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ciara Power <ciara.power@intel.com>,
	wenzhuo.lu@intel.com, jingjing.wu@intel.com,
	bernard.iremonger@intel.com
Cc: dev@dpdk.org, ivan.boule@6wind.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix device mcast list error handling
Date: Wed, 4 Dec 2019 16:48:39 +0000
Message-ID: <838c0d07-9449-cb1a-2f14-e633a72c1676@intel.com> (raw)
In-Reply-To: <20191204163815.44495-1-ciara.power@intel.com>

On 12/4/2019 4:38 PM, Ciara Power wrote:
> The multicast set list function now has a return value, which is checked
> by the calling functions. A rollback occurs on detection of failure, to
> realign local config with the device config.
> 
> The error print statement in the function had included the port_id and
> mc_addr_nb values in the wrong order, these are now swapped.
> 
> Fixes: 8fff667578a7 ("app/testpmd: new command to add/remove multicast MAC addresses")
> Cc: ivan.boule@6wind.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 16:38 [dpdk-dev] " Ciara Power
2019-12-04 16:48 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838c0d07-9449-cb1a-2f14-e633a72c1676@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    --cc=ivan.boule@6wind.com \
    --cc=jingjing.wu@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git