From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1035C4321A for ; Fri, 28 Jun 2019 08:02:53 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 7074F2133F for ; Fri, 28 Jun 2019 08:02:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7074F2133F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ericsson.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F4C31B99D; Fri, 28 Jun 2019 10:02:52 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id 5611458C6; Fri, 28 Jun 2019 10:02:51 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 990DE4000D; Fri, 28 Jun 2019 10:02:50 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 8590140018; Fri, 28 Jun 2019 10:02:50 +0200 (CEST) Received: from [192.168.1.59] (host-90-232-200-177.mobileonline.telia.com [90.232.200.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id BB9AF4000D; Fri, 28 Jun 2019 10:02:46 +0200 (CEST) To: Jerin Jacob Kollanukkaran , Anoob Joseph , Nikhil Rao , Erik Gabriel Carrillo , Abhinandan Gujjar , Bruce Richardson , Pablo de Lara Cc: Narayana Prasad Raju Athreya , "dev@dpdk.org" , Lukas Bartosik , Pavan Nikhilesh Bhagavatula , Hemant Agrawal , Nipun Gupta , Harry van Haaren , Liang Ma , "techboard@dpdk.org" References: From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: <848c585a-9f62-60eb-5069-862295551d2d@ericsson.com> Date: Fri, 28 Jun 2019 10:02:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2019-06-28 05:37, Jerin Jacob Kollanukkaran wrote: >>> >>> I have only concern about moving this as library inside eventdev that >>> till we have mature version of helper library the eventdev library ABI >>> will not stable(i.e .so file version needs to be incremented as when a >>> change needed). Which align with Mattias thoughts for some other >>> reason:. How about moving this code to >>> 1) example/common or >>> 2) to specific application itself, once at least two applications >>> starts using it then move to Eventdev library. >>> >>> Thoughts? >> >> [Anoob] Either location is not a problem if there is a consensus. Earlier the >> suggestion was to move it to library (when the patch was submitted with >> changes added in app). > > > If there NO objections then lets move to example/common. > That sounds like a good idea to me. I wish I had more time to devote to eventmode, so I could be more constructive than basically just saying "it's a hard problem" and "the proposed solution seems not generic-enough by far" - but I don't at the moment.