From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Chas Williams <chas3@att.com>
Cc: dev@dpdk.org, stable@dpdk.org, Declan Doherty <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: do not inherit slave device configuration
Date: Tue, 19 Nov 2019 12:18:47 +0000 [thread overview]
Message-ID: <873a52fd-7108-5428-1ce1-1bb82c023bb0@intel.com> (raw)
In-Reply-To: <1574154221-8628-1-git-send-email-arybchenko@solarflare.com>
On 11/19/2019 9:03 AM, Andrew Rybchenko wrote:
> Bonding device should control bonded devices configuration.
>
> Also avoid usage of slave's data->dev_conf.
>
> Fixes: 2efb58cbab6e ("bond: new link bonding library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 707a0f3cdd..4f0e83205d 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -1679,6 +1679,7 @@ int
> slave_configure(struct rte_eth_dev *bonded_eth_dev,
> struct rte_eth_dev *slave_eth_dev)
> {
> + struct rte_eth_conf dev_conf;
> struct bond_rx_queue *bd_rx_q;
> struct bond_tx_queue *bd_tx_q;
> uint16_t nb_rx_queues;
> @@ -1693,34 +1694,34 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
> /* Stop slave */
> rte_eth_dev_stop(slave_eth_dev->data->port_id);
>
> + memset(&dev_conf, 0, sizeof(dev_conf));
> +
> /* Enable interrupts on slave device if supported */
> if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
> - slave_eth_dev->data->dev_conf.intr_conf.lsc = 1;
> + dev_conf.intr_conf.lsc = 1;
I assume the original intention is making incremental changes to the existing
slave configuration, if so we should copy the 'slave_eth_dev->data->dev_conf' to
'dev_conf' before start updating it.
next prev parent reply other threads:[~2019-11-19 12:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 9:03 [dpdk-dev] [PATCH] net/bonding: do not inherit slave device configuration Andrew Rybchenko
2019-11-19 12:18 ` Ferruh Yigit [this message]
2019-11-19 12:40 ` [dpdk-dev] [dpdk-stable] " Andrew Rybchenko
2019-12-03 10:17 ` Ferruh Yigit
2019-12-08 15:44 ` Chas Williams
2019-12-09 7:16 ` Andrew Rybchenko
2019-12-09 13:36 ` Chas Williams
2019-12-09 14:31 ` Andrew Rybchenko
2019-12-09 14:45 ` Chas Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873a52fd-7108-5428-1ce1-1bb82c023bb0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).