From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E20C0650E for ; Wed, 3 Jul 2019 10:13:24 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 534EC2184C for ; Wed, 3 Jul 2019 10:13:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 534EC2184C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A1C0A1B949; Wed, 3 Jul 2019 12:13:23 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 2473B1B197; Wed, 3 Jul 2019 12:13:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 03:13:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,446,1557212400"; d="scan'208";a="166483909" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga003.jf.intel.com with ESMTP; 03 Jul 2019 03:13:19 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.46]) by IRSMSX151.ger.corp.intel.com ([169.254.4.183]) with mapi id 14.03.0439.000; Wed, 3 Jul 2019 11:13:19 +0100 From: "Iremonger, Bernard" To: Akhil Goyal , "Ananyev, Konstantin" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto Thread-Index: AQHVIS5toZxp/+I0hUaF5UkhVK8CcKaZdXeAgB9E9ICAABH1oA== Date: Wed, 3 Jul 2019 10:13:18 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260DC128E@IRSMSX108.ger.corp.intel.com> References: <1559819547-20742-1-git-send-email-bernard.iremonger@intel.com> <1560351121-21234-2-git-send-email-bernard.iremonger@intel.com> <2601191342CEEE43887BDE71AB97725801688E4E2C@IRSMSX104.ger.corp.intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTcxMWRkNDItY2YxNy00N2U4LTkzMTgtNWY3NDBhY2UwZmUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSENwa2NIcHZKRnEwcEdtaVNFR2FCY0tad1wvYWZJdXhcL1FSMlRVUUVtVXB0ckhmY0pzYWJOcFlsbDdadjFxU2F0In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Wednesday, July 3, 2019 11:05 AM > To: Ananyev, Konstantin ; Iremonger, > Bernard ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for > inline crypto >=20 > Hi Bernard, >=20 > > > > > > Inline crypto installs a flow rule in the NIC. This flow rule must > > > be installed before the first inbound packet is received. > > > > > > The create_session() function installs the flow rule, > > > create_session() has been refactored into create_inline_session() > > > and create_lookaside_session(). The create_inline_session() function > > > uses the socket_ctx data and is now called at initialisation in > > > sa_add_rules(). > > > > > > The max_session_size() function has been added to calculate memory > > > requirements. > > > > > > The cryprodev_init() function has been refactored to drop calls to > > > rte_mempool_create() and to drop calculation of memory requirements. > > > > > > The main() function has been refactored to call max_session_size() > > > and to call session_pool_init() and session_priv_pool_init() earlier. > > > The ports are started now before adding a flow rule in main(). > > > The sa_init(), sp4_init(), sp6_init() and rt_init() functions are > > > now called after the ports have been started. > > > > > > The rte_ipsec_session_prepare() function is called in > > > fill_ipsec_session() for inline which is called from the ipsec_sa_ini= t() > function. > > > > > > Fixes: ec17993a145a ("examples/ipsec-secgw: support security > > > offload") > > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample > > > application") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Bernard Iremonger > > > --- > > > > Acked-by: Konstantin Ananyev > > Tested-by: Konstantin Ananyev > > >=20 > This patch need to be rebased. >=20 > However, I will try to work on your v5 in next few days if I get time. If= I don't > get time to fix that, will need you to send a rebased version of this pat= ch. >=20 > Thanks, > Akhil >=20 v6 is the latest version I will send a v7 rebased on 19.08.rc1 Regards, Bernard