DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: "Eads, Gage" <gage.eads@intel.com>
To: Phil Yang <phil.yang@arm.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "nd@arm.com" <nd@arm.com>,
	"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
	"gavin.hu@arm.com" <gavin.hu@arm.com>
Subject: Re: [dpdk-dev] [PATCH] eal/stack: fix 'pointer-sign' warning
Date: Fri, 14 Jun 2019 19:49:30 +0000
Message-ID: <9184057F7FC11744A2107296B6B8EB1E68CED6A0@FMSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <1560531283-5229-1-git-send-email-phil.yang@arm.com>

> clang raise 'pointer-sign' warnings in __atomic_compare_exchange when
> passing 'uint64_t *' to parameter of type 'int64_t *' converts between
> pointers to integer types with different sign.
> 
> Fixes: 7e6e609939a8 ("stack: add C11 atomic implementation")
> 
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> 
> ---
>  lib/librte_stack/rte_stack_lf_c11.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_stack/rte_stack_lf_c11.h
> b/lib/librte_stack/rte_stack_lf_c11.h
> index a316e9a..e3b9eff 100644
> --- a/lib/librte_stack/rte_stack_lf_c11.h
> +++ b/lib/librte_stack/rte_stack_lf_c11.h
> @@ -97,7 +97,7 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list,
>  	return NULL;
>  #else
>  	struct rte_stack_lf_head old_head;
> -	uint64_t len;
> +	int64_t len;

This works, but I'd prefer to keep 'len' unsigned. How about changing the definition of 'len' in struct rte_stack_lf_list to uint64_t, and in rte_stack_lf_generic.h casting it to rte_atomic64_t* when its address is passed to the rte_atomic64_...() functions?

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 16:54 Phil Yang
2019-06-14 19:49 ` Eads, Gage [this message]
2019-06-17  7:49   ` Phil Yang (Arm Technology China)
2019-06-17  7:41 ` [dpdk-dev] [PATCH v2] " Phil Yang
2019-06-18 15:43   ` Eads, Gage
2019-06-27 16:04     ` Thomas Monjalon

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9184057F7FC11744A2107296B6B8EB1E68CED6A0@FMSMSX108.amr.corp.intel.com \
    --to=gage.eads@intel.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=nd@arm.com \
    --cc=phil.yang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox