From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3511DC31E48 for ; Wed, 12 Jun 2019 16:13:07 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C20152064A for ; Wed, 12 Jun 2019 16:13:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="MQOhZUW6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C20152064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 15B371D0C8; Wed, 12 Jun 2019 18:13:06 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140077.outbound.protection.outlook.com [40.107.14.77]) by dpdk.org (Postfix) with ESMTP id D4E7F1D0C6 for ; Wed, 12 Jun 2019 18:13:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YLN4QP7za38cj1g0ur8fjai6cs8aD9heF/N6f6rlemw=; b=MQOhZUW6/9AqM+z8IwMIPmiv8hLDnP9WCNph/9qUSKXCUHi8l1LQPBTGATMQBm620SI4TL0fGOalnbKRN5DZFyMUQ2VVdyDOiMjjwkSld6JOYp76g6yakbNU7r9tZsbZkeJYXVSDljZ9ZahUXXgcdCd4+KGNJwimD3ldmgvelj0= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3778.eurprd05.prod.outlook.com (52.133.50.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.11; Wed, 12 Jun 2019 16:13:03 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::c5e8:f7ec:d77:5269]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::c5e8:f7ec:d77:5269%4]) with mapi id 15.20.1987.010; Wed, 12 Jun 2019 16:13:03 +0000 From: Matan Azrad To: Stephen Hemminger , Shahaf Shuler CC: "dev@dpdk.org" Thread-Topic: RFC - vdev_netvsc automatic blacklisting Thread-Index: AQHVGw9KGCRaWlcdwUWhNccsU0sDp6aWBGnAgACIx4CAAPaQ4IAAiw2AgAAt1sA= Date: Wed, 12 Jun 2019 16:13:02 +0000 Message-ID: References: <20190604125409.078adf75@hermes.lan> <20190611072627.7694128c@hermes.lan> <20190612062637.57e9ab6e@hermes.lan> In-Reply-To: <20190612062637.57e9ab6e@hermes.lan> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 528e3011-b6bb-4e9f-4dbb-08d6ef50d8c4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3778; x-ms-traffictypediagnostic: AM0PR0502MB3778: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0066D63CE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(136003)(346002)(366004)(396003)(199004)(189003)(55016002)(66556008)(25786009)(6246003)(9686003)(53936002)(2906002)(68736007)(229853002)(33656002)(8936002)(110136005)(6636002)(26005)(7696005)(66476007)(64756008)(73956011)(316002)(81156014)(76116006)(66946007)(81166006)(99286004)(8676002)(305945005)(66446008)(7736002)(74316002)(86362001)(256004)(5660300002)(71190400001)(5024004)(186003)(66066001)(71200400001)(52536014)(478600001)(6116002)(486006)(76176011)(6506007)(4326008)(11346002)(3846002)(446003)(102836004)(476003)(6436002)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3778; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +860Mb7xMrUxvwNBwo+6Biv12zelYgztvhIMmw0Yn2d2yAGV6J0Ksj8HKSt8SNBEDs0JyzdvjomiXZKuBDn2h31GmwPM+4NicboN8z7YQrggHj2H4NxZG21+WtmvRhNfeI7uZPcvhhtdKYorKsyhAzqMmhv7HNqzjIZ0yPJCmJRmfMGh75h5WL3ARrAxDgOX7MHQ2fkg6hf2tI33nPYEFcVJRHdQHUuM4CAEoZtrEl5HI+0503g5kwt7VWHbEuVcVP3otd1c1RdOSmVGW9ZftdPwEmlR46sizIyr5lRJH+C2y43ppNMVSA6HafMFaBxY2/rdqxauIFTPgHWu2MmJNYJ3p6IZPBzYhZhTCREJhWekdxHMrUnT8jlx/jAywXtvcNww9u1deSqZB6ee67GBtwcWJZO+JnEchJm/I7AqaL0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 528e3011-b6bb-4e9f-4dbb-08d6ef50d8c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2019 16:13:03.1510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3778 Subject: Re: [dpdk-dev] RFC - vdev_netvsc automatic blacklisting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi + Shahaf From: Stephen Hemminger=20 > On Wed, 12 Jun 2019 05:15:47 +0000 > Matan Azrad wrote: >=20 > > From: Stephen Hemminger > > > > Hi Stephen > > > > > > > > From: Stephen Hemminger > > > > > When using DPDK on Azure it is common to have one non-DPDK > > > interface. > > > > > If that non-DPDK interface is present vdev_netvsc correctly skip = it. > > > > > But if the non-DPDK has accelerated networking the Mellanox > > > > > driver will still get associated with DPDK (and break connectivit= y). > > > > > > > > > > The current process is to tell users to do whitelist or > > > > > blacklist the PCI > > > > > device(s) not used for DPDK. But vdev_netvsc already is doing a > > > > > lot of looking at devices and VF devices. > > > > > > > > > > Could vdev_netvsc just do this automatically by setting devargs > > > > > for the VF to blacklist? > > > > > > > > > > > > There is way to blacklist a device by setting it a rout\IP\IPv6, > > > > from the > > > VDEV_NETVSC doc: > > > > "Not specifying either iface or mac makes this driver attach > > > > itself to all > > > unrouted NetVSC interfaces found on the system. Specifying the > > > device makes this driver attach itself to the device regardless the d= evice > routes." > > > > > > > > So, we are expecting that used VFs will be with a rout and DPDK > > > > VFs will not > > > be with a rout. > > > > > > > > Doesn't it enough? > > > > > > > > > > > > Matan > > > > > > I am talking about if eth0 has a route, it gets skipped but the > > > associated MLX SR-IOV device does not. When the MLX device is then > > > configured for DPDK, it breaks it for use by kernel; and therefore > connectivity with the VM is lost. > > > > Ok, I think I got you. > > You want to blacklist the PCI device which its netvsc net-device is det= ected > as routed. Do you? > > > > If so, > > > > I don't think that probing the pci device hurts the connectivity, only = the > configuration should hurt it. > > > > It means that the application configures the device and hurt it. > > Doesn't it an application issue? > > > > Matan >=20 > Actually probing does hurt, it corrupts the MLX driver. > In theory, the driver supports bifurcated but in practice it is greedy an= d grabs > all flows. I can't see promiscuous configuration in the probing code. Looks like it is an application configuration. Shahaf , are you agree? Matan