From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 266B9C3A5A4 for ; Sun, 1 Sep 2019 13:52:55 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8F70C206A3 for ; Sun, 1 Sep 2019 13:52:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="eMsRGMYP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F70C206A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52BF11C217; Sun, 1 Sep 2019 15:52:53 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60082.outbound.protection.outlook.com [40.107.6.82]) by dpdk.org (Postfix) with ESMTP id D8F4E1C1C8 for ; Sun, 1 Sep 2019 15:52:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MO14m2CpmvsXxbJGoPLAjjWAQgL1KRqbsnxsWttS06yo60QE5db/nKyu6CWxGPojtkoYRK/upJ2YYAWfr0m1OtceXZXjDHlAZ14mdHh9o4NFW8eXLznULanHkg4j1ro3wa8l/Zen7hXyAoSwYdwSgsDreefbmZQDrymXtksRen6stCh+cFf+AA4f3kjQkgS6kSjhO32H610+E0KNuguv+wP94UbFO34SaH1Vius63P160kloL8z8d4sLbEhifm5gjVt5WJF85nuKo0iUmRu/k7gA3QzKXnJLkZAP7w3G0tOyirxTkx3aLxxpg4LQRFdn22Nu+OiwYMhPKS+WNjU8mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rn/gubLoVrKn3CrW/2T+FVuoAZbscQhK6pLCQ0RoUH0=; b=FBpXUFq/YPM8N12xNNzIhAjHn20GD4vgMQM7DWNCqlaKSqxi2gdsUrPxXVvTwRY3BiM9N8tBXXs6VZlruVUVpMoGX6wWkX4Ze15Dd+dsg+QRBDETzyZls2DvJfOXHQosqdiZG057zv2OaBbSkl0eN7Lau4f/CflY5mgCXROOmkPLjIj9uBhe5x0aQJO8FPXetfVHB/HdLKcoMQuEJQXPctbWrDZ4kNfuQikUoAeC+BpH1eBekSc15bD5Ik8re6M4ub/qHiQ2VdOWA/xjgoEvKp7/nG8XGR60zihoTlkONOFV9MYxazhU5zq1lahyQDpzYrcJaLMVf6clEb9rKLSuxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rn/gubLoVrKn3CrW/2T+FVuoAZbscQhK6pLCQ0RoUH0=; b=eMsRGMYPpwAV8hVK2elYtZrkL46/L7GGmU+TuLzgCGJbsMlNr8mRzOhp2wnrqzLCSbXOcbg8aHEoD4QFtBu11UYQuhttlQWsHrDnb1R0UK4PGob7RLw3xNjZ8GYdZ46rebXn+U0iq9VQQQRjdacbPGmFIkdIakflC9KpCvWDfGg= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3873.eurprd05.prod.outlook.com (52.133.48.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.21; Sun, 1 Sep 2019 13:52:50 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::7deb:8e17:1363:e00e]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::7deb:8e17:1363:e00e%7]) with mapi id 15.20.2220.021; Sun, 1 Sep 2019 13:52:50 +0000 From: Matan Azrad To: Christian Ehrhardt , dev CC: Luca Boccassi , Thomas Monjalon , Frank Heimes , Raslan Darawsheh Thread-Topic: [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64 Thread-Index: AQHVUcpNLtwE2Uj5bkKfGvZsqK2JRqcW9Lew Date: Sun, 1 Sep 2019 13:52:50 +0000 Message-ID: References: <20190813112843.27072-1-christian.ehrhardt@canonical.com> <20190813112843.27072-2-christian.ehrhardt@canonical.com> In-Reply-To: <20190813112843.27072-2-christian.ehrhardt@canonical.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e4df2862-cd8f-44c4-5f16-08d72ee3adad x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3873; x-ms-traffictypediagnostic: AM0PR0502MB3873:|AM0PR0502MB3873: x-ms-exchange-purlcount: 1 x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0147E151B5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(396003)(39860400002)(136003)(366004)(199004)(189003)(81166006)(81156014)(6506007)(7696005)(6436002)(76176011)(14454004)(6306002)(9686003)(25786009)(110136005)(316002)(54906003)(55016002)(966005)(33656002)(476003)(52536014)(486006)(99286004)(186003)(53936002)(26005)(11346002)(446003)(102836004)(107886003)(6246003)(4326008)(478600001)(8676002)(66446008)(64756008)(66556008)(66476007)(66946007)(76116006)(86362001)(3846002)(66066001)(2906002)(6116002)(5660300002)(305945005)(74316002)(7736002)(229853002)(45080400002)(71190400001)(71200400001)(256004)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3873; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Cxr/qeyE/gjCwhnUgmVWmT6bWlf8lCltSu4OMybOwKlqk+LJMc4hWqITN4rmjWPoKFdNFDALo0aD7adpSuPUvRPMeKSva/xtSkZ7CXHYv79faDg8yBUovrjiBRjuPjSPDDxaQh+IQ3pB3B0eQh55V/Ab8gwY9Fevg6APg9HusyWm1n2qKXvZU0Nz2I0VT2KKDi+OkwR20/b6PtELAwx0ZmLqtPE1/9/heaoLGO5B6ojakQe4Kg7AX8SCVJu+d9nDV24VAlOZtTvjMl4l+3qhNfRAMawDT+Mim4KHJvFdjRkcJcHEx52kDrnX5z3ByuCIrgJV40MZ0RAJvR9ZWgoUZ0DxRImR0RZY2l6nmyHvMdBILZ6SbcFQRmOnXA5Ng/m7B2qS8eUF5VG2XRj9qmktVA1bA6ec4GVNt7iT06rbq6g= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4df2862-cd8f-44c4-5f16-08d72ee3adad X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2019 13:52:50.1509 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AzWel2IkAaBgptoo/Jm9aw2M/guzeZ4pfYLbOfOxfW2dresJZsSoomFBYE5QAFSHkS12VQlGR/hwz1D1P8JUNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3873 Subject: Re: [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > From: dev On Behalf Of Christian Ehrhardt > The AltiVec header file breaks boolean type: >=20 > error: incompatible types when initializing type '__vector _bool int' {ak= a > '_vector(4) __bool int'} using type 'int' >=20 > If __APPLE_ALTIVEC__ is defined, then bool type is redefined and conflict= s > with stdbool.h. >=20 > There is no good solution to fix it for the whole project without breakin= g > something else, so a workaround is inserted in mlx5 PMD. > This workaround is not compatible with C++ but there is no C++ in DPDK. >=20 > Related to: > https://eur03.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit.d= p > dk.org%2Fdpdk%2Fcommit%2F%3Fid%3D725f5dd0bfb50192a2d2341d4cc690 > 84c2c4e03d&data=3D02%7C01%7Cmatan%40mellanox.com%7Ccaefd20ac0 > 39441c69a508d71fe16f1b%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C > 0%7C637012925402095536&sdata=3DRP9wpAJeUdQGfEvzqlDubKsj9hHw7 > 5fEgs0JVIMTfPc%3D&reserved=3D0 >=20 > Change-Id: Iceb058c07086def4176c5ab199ca4dd5018d0340 No need the Change-Id ... > Signed-off-by: Christian Ehrhardt Besides that, Acked-by: Matan Azrad Thanks > --- > drivers/net/mlx4/mlx4_utils.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/drivers/net/mlx4/mlx4_utils.h b/drivers/net/mlx4/mlx4_utils.= h > index a49190252..74b9d2ecd 100644 > --- a/drivers/net/mlx4/mlx4_utils.h > +++ b/drivers/net/mlx4/mlx4_utils.h > @@ -15,6 +15,16 @@ >=20 > #include "mlx4.h" >=20 > +/* > + * Compilation workaround for PPC64 when AltiVec is fully enabled, e.g. > std=3Dc11. > + * Otherwise there would be a type conflict between stdbool and altivec. > + */ > +#if defined(__PPC64__) && !defined(__APPLE_ALTIVEC__) #undef bool > +/* redefine as in stdbool.h */ > +#define bool _Bool > +#endif > + > extern int mlx4_logtype; >=20 > #ifndef NDEBUG > -- > 2.22.0