From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16DF4C31E46 for ; Wed, 12 Jun 2019 05:15:51 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 9378A2086A for ; Wed, 12 Jun 2019 05:15:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="HMOogX9Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9378A2086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 67A211C5F4; Wed, 12 Jun 2019 07:15:49 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40081.outbound.protection.outlook.com [40.107.4.81]) by dpdk.org (Postfix) with ESMTP id 5368B1C5B3 for ; Wed, 12 Jun 2019 07:15:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQ7R1Ir29G/0Uq9CdzKAzqe8JuC9mLrwlFt49irAIh8=; b=HMOogX9Ykw42ztrmatwBYp7tLaiIT8CGYUCRoXpoKqaVZ3+pzuZDq985v5mBI86+7sH8MoCWNHMHLBWG9AHLGyUd++g4HdjjlVyPv2d70jiF/f5TbFXH7gX/0fMBDuzMA67FEdxOMKIYCvs+hBsbBP9cv08mnTZB90JJWmeL4xo= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB4066.eurprd05.prod.outlook.com (52.133.41.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.14; Wed, 12 Jun 2019 05:15:47 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::c5e8:f7ec:d77:5269]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::c5e8:f7ec:d77:5269%4]) with mapi id 15.20.1987.010; Wed, 12 Jun 2019 05:15:47 +0000 From: Matan Azrad To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: RFC - vdev_netvsc automatic blacklisting Thread-Index: AQHVGw9KGCRaWlcdwUWhNccsU0sDp6aWBGnAgACIx4CAAPaQ4A== Date: Wed, 12 Jun 2019 05:15:47 +0000 Message-ID: References: <20190604125409.078adf75@hermes.lan> <20190611072627.7694128c@hermes.lan> In-Reply-To: <20190611072627.7694128c@hermes.lan> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.125.11.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0c329c4b-5733-4b29-79eb-08d6eef5073a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4066; x-ms-traffictypediagnostic: AM0PR0502MB4066: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0066D63CE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(366004)(376002)(39860400002)(346002)(189003)(199004)(2906002)(33656002)(68736007)(316002)(14454004)(11346002)(486006)(478600001)(71200400001)(446003)(66066001)(476003)(86362001)(53936002)(229853002)(6436002)(71190400001)(4326008)(25786009)(8676002)(9686003)(305945005)(74316002)(5660300002)(55016002)(3846002)(6246003)(6116002)(66946007)(76176011)(81166006)(8936002)(81156014)(102836004)(256004)(66476007)(66556008)(99286004)(66446008)(76116006)(6506007)(7736002)(52536014)(186003)(73956011)(5024004)(64756008)(26005)(6916009)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4066; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 23DdNpFXobUof9d30SWtRh/GRn/OhzAHNzwS3sNBV6VRhW08T5vw1dzsmHkKd3c1Lk7+FUKSYGn6w59O9cyPxTF8cMjm5ZH+kvQXUxAxjKQKDVEeTsOIHNq1C5++Jzrdw3jBqvrPxGo+M4Rw/gCDxPUuDNsurDFsKv7NPp2G0o2oZQn7wPsHPi9VigD93rzpObyQsUnJpBwpuEHSbqVNfb1Ma24mcG/BebaI2ojlbv+DQfRCDJ2h7HuXu1YB7nw+Cal93TqZGlQRQeB6wSleytePdXf7GQRSxUzBO+gWlOWoKamVQ7wiISzjtlebk70T7I3ax66avlN5547MERtbRZJd0FuJFxDHXT+EHV0sJPSoOXlbUq5JN+Aly5VluhL3erpBZtc4rYPVMioDLMtwrR187FZ5M4OYGBiCKLy1tFY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c329c4b-5733-4b29-79eb-08d6eef5073a X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2019 05:15:47.3785 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4066 Subject: Re: [dpdk-dev] RFC - vdev_netvsc automatic blacklisting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger=20 > > Hi Stephen > > > > From: Stephen Hemminger > > > When using DPDK on Azure it is common to have one non-DPDK > interface. > > > If that non-DPDK interface is present vdev_netvsc correctly skip it. > > > But if the non-DPDK has accelerated networking the Mellanox driver > > > will still get associated with DPDK (and break connectivity). > > > > > > The current process is to tell users to do whitelist or blacklist > > > the PCI > > > device(s) not used for DPDK. But vdev_netvsc already is doing a lot > > > of looking at devices and VF devices. > > > > > > Could vdev_netvsc just do this automatically by setting devargs for > > > the VF to blacklist? > > > > > > There is way to blacklist a device by setting it a rout\IP\IPv6, from t= he > VDEV_NETVSC doc: > > "Not specifying either iface or mac makes this driver attach itself to = all > unrouted NetVSC interfaces found on the system. Specifying the device > makes this driver attach itself to the device regardless the device route= s." > > > > So, we are expecting that used VFs will be with a rout and DPDK VFs wil= l not > be with a rout. > > > > Doesn't it enough? > > > > > > Matan >=20 > I am talking about if eth0 has a route, it gets skipped but the associate= d MLX > SR-IOV device does not. When the MLX device is then configured for DPDK, = it > breaks it for use by kernel; and therefore connectivity with the VM is lo= st. Ok, I think I got you. You want to blacklist the PCI device which its netvsc net-device is detecte= d as routed. Do you? If so, I don't think that probing the pci device hurts the connectivity, only the = configuration should hurt it. It means that the application configures the device and hurt it. Doesn't it an application issue?=20 Matan