From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A60ECDE20 for ; Wed, 11 Sep 2019 06:58:44 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 87EF621928 for ; Wed, 11 Sep 2019 06:58:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="JYibibZp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="JYibibZp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87EF621928 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 682C61EAD1; Wed, 11 Sep 2019 08:58:42 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30057.outbound.protection.outlook.com [40.107.3.57]) by dpdk.org (Postfix) with ESMTP id C56291E958 for ; Wed, 11 Sep 2019 08:58:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZboA5P8uNkJD4RFYKJ5r6IuO981yyW8u5s6LBWsi+M=; b=JYibibZptCL2CrsdsBxi4Ec4WUulquG35E0+UxuGeyfyQTaMemKbYTpSnfvNpIOUP3ENvqG6fJn8nMhXv9bjBajaOul3WVCK+17XZw5NfUE6iYz4w2yZEYhboLLEmU7QtQ5kb4PzO+jcO4jXFjnjLyzewIweDClWexQthjGeF6U= Received: from VI1PR08CA0178.eurprd08.prod.outlook.com (2603:10a6:800:d1::32) by DB7PR08MB3802.eurprd08.prod.outlook.com (2603:10a6:10:77::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.18; Wed, 11 Sep 2019 06:58:36 +0000 Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::208) by VI1PR08CA0178.outlook.office365.com (2603:10a6:800:d1::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14 via Frontend Transport; Wed, 11 Sep 2019 06:58:36 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.14 via Frontend Transport; Wed, 11 Sep 2019 06:58:34 +0000 Received: ("Tessian outbound 5e45193c6ce5:v29"); Wed, 11 Sep 2019 06:58:31 +0000 X-CR-MTA-TID: 64aa7808 Received: from 119d8c3ee41b.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.8.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3A7317C5-27C3-4434-A1E1-FADB0CDBF1B0.1; Wed, 11 Sep 2019 06:58:26 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2056.outbound.protection.outlook.com [104.47.8.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 119d8c3ee41b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Sep 2019 06:58:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m+fqTk2p53mIcrSOrZku37VNfBua4nU/76/y++7vuL3OBL5mSBICoDfb+svrzRqYH6Wak5PSvHXSbutft8IpFzpWF9ZDKd8ak0l7LVLUQ0Bj5AH4s5oWgbG+yQTffcgM0tRsUHOWg90WFCB68ELy5aqntk2Sfs6MBtmdKyvwndDj97+aeYzwmTIstcesZl9Bye7E/i9REX65zJGMMt/CfTCyQ6JmyWXc/A95Hfweo9uk4Ys/KCce7p5w7YORhJcPO6WxbKMe9jh84vNI5RA1cjMMEOXIDrcktHX6RLiWjnZl83PvEsCY4ySJA6up58qSEoy53d3bAinNOG+3913Ugw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZboA5P8uNkJD4RFYKJ5r6IuO981yyW8u5s6LBWsi+M=; b=njdjIP+QoGzuamccVZX66SEbp5fqVxJV822br9Sk5lQNZ1csg1OWSKpIXUXUOFwifpL596bhb2wUnLsHBqXQ9k2BSwWpuvJk+HanJMu986F+gCqiPmhRkf8XEs+YxLcZhRvaPc9T/08Zz5gRErUl8wZmEdAnrs4A8dWZTziXWYKbXsqeQHySFlPKH1k/UI4zboh/ooHJLzj+yA+MrIeY6bDGI29jUvbqjZuDUFeJxAb8H8a8IbS23DhnQOOyNIwJzQxKsupl6NmPuNrUhr2StzUOuTYqeMWYGHUZnW+zpUA+vglDXCdwID0p6EUcBk9Uoq/wUglMlhvrZZnHNc04GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZboA5P8uNkJD4RFYKJ5r6IuO981yyW8u5s6LBWsi+M=; b=JYibibZptCL2CrsdsBxi4Ec4WUulquG35E0+UxuGeyfyQTaMemKbYTpSnfvNpIOUP3ENvqG6fJn8nMhXv9bjBajaOul3WVCK+17XZw5NfUE6iYz4w2yZEYhboLLEmU7QtQ5kb4PzO+jcO4jXFjnjLyzewIweDClWexQthjGeF6U= Received: from AM0PR08MB3986.eurprd08.prod.outlook.com (20.178.118.90) by AM0PR08MB4930.eurprd08.prod.outlook.com (10.255.28.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.18; Wed, 11 Sep 2019 06:58:25 +0000 Received: from AM0PR08MB3986.eurprd08.prod.outlook.com ([fe80::8194:f229:b0d2:b5df]) by AM0PR08MB3986.eurprd08.prod.outlook.com ([fe80::8194:f229:b0d2:b5df%7]) with mapi id 15.20.2263.015; Wed, 11 Sep 2019 06:58:24 +0000 From: "Ruifeng Wang (Arm Technology China)" To: Honnappa Nagarahalli , "Ananyev, Konstantin" , "Kantecki, Tomasz" CC: "dev@dpdk.org" , "Gavin Hu (Arm Technology China)" , nd , nd , nd Thread-Topic: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd Thread-Index: AQHVZJ2RE3+uO/G+WUmOLRh3JRpdcqcedEgAgAQfuaCAAhDKgIAABz/wgAFQ/wCAAAtF8A== Date: Wed, 11 Sep 2019 06:58:24 +0000 Message-ID: References: <20190906102615.36942-1-ruifeng.wang@arm.com> <2601191342CEEE43887BDE71AB977258019192657B@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258019196218E@irsmsx105.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0cadbdf6-2e8c-4af2-9895-da342192e7c3.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 8e7156c1-6c46-4bc2-2b95-08d7368576c3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR08MB4930; X-MS-TrafficTypeDiagnostic: AM0PR08MB4930:|AM0PR08MB4930:|DB7PR08MB3802: X-MS-Exchange-PUrlCount: 1 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 0157DEB61B X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(13464003)(189003)(199004)(33656002)(6436002)(6116002)(486006)(76176011)(54906003)(110136005)(14454004)(86362001)(316002)(99286004)(2906002)(25786009)(81156014)(4326008)(81166006)(8936002)(8676002)(66476007)(66556008)(64756008)(76116006)(3846002)(66446008)(66946007)(7696005)(53936002)(74316002)(53546011)(305945005)(9686003)(6306002)(55016002)(6246003)(14444005)(7736002)(71190400001)(71200400001)(229853002)(478600001)(5660300002)(66066001)(6506007)(966005)(52536014)(102836004)(256004)(55236004)(186003)(26005)(11346002)(476003)(446003)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB4930; H:AM0PR08MB3986.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: nOAM00/LDQMdgr7L9+HPdOXbLV5HgpWQpOD6W1ZjUmiChUhTL2ICROT0bGU++xkpnnUVV+CYpWr/iEIZputmU7fWSPSUR7U8j0c7r88lze7jOxnKakd7QO3wre90hCWjQgT8DD0DuBfAAma9vbR5fTPIDJ5USz5Bcw0NLit9e7axjcQIuzoq5xSz8tGYAo4Qw9JJuSV0tdeUdzGGpm2diAVaTBD+/1crPDt3kjTuObLsT/PPgR6uKk9U9s0LBtP1HTHtt/LC4hdmi6kU/Wt3xrGWOzgBYeaJvAFUG7sTtYIfyD6kidq8M6Nbb7x5/+5cSDsWbcjF7yoBkSZcMhDlUCAbKcJLdPCZle5hBQNS/ImTU5zvONoGHDKExD1FwoIHoxjxjc+LRFSaEs3EKlqNVdQQcQ2FGrZY4Q6hvW5d2Bs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4930 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(136003)(39860400002)(396003)(189003)(199004)(13464003)(110136005)(186003)(54906003)(52536014)(5660300002)(76130400001)(70206006)(7696005)(76176011)(99286004)(70586007)(478600001)(66066001)(966005)(47776003)(229853002)(26826003)(6246003)(22756006)(4326008)(6306002)(9686003)(25786009)(55016002)(97756001)(356004)(33656002)(8746002)(8936002)(3846002)(11346002)(446003)(63350400001)(14444005)(476003)(126002)(486006)(6116002)(63370400001)(74316002)(7736002)(23726003)(305945005)(36906005)(86362001)(316002)(50466002)(14454004)(81156014)(81166006)(26005)(46406003)(6506007)(53546011)(2906002)(336012)(102836004)(8676002)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3802; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 2a4fdee8-8ae6-44c8-6b05-08d7368570f6 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB7PR08MB3802; NoDisclaimer: True X-Forefront-PRVS: 0157DEB61B X-Microsoft-Antispam-Message-Info: uaB214Ascwr86N/Hpc/4AjyBSIlBGJoFQPuuhTRM17cCkE4g/y+mSnqtzhzh7yQ69iHUwxiimBUuv7t82imkLnIN354yBtQhKCypV22CrDrP0zjRxIbbqF/brZycmj+R5wH4ViC45y9Dipunh0lhWoGZrwGaY3idtOafhs9Kbyf6MDGC8jVd9hq+wWabMUR8tavxEY+BWEiT4Jpu0L1pewY2PxpQUARJuUvG/K9bRmHlMaQ5ehg2reFQJqb66osXyCoxH/FA0lSD8tb2cXFyeaMQnaQJdwS/DFuE8GCN2Y37ojL/9oKZddvPgAEYCUoP/ZdX1QQ4DOcjDjssWjGdaHYVyLnzShE010xWsdgWUguwn+TXCkQ5COSvkkgvSaPt8Dnqc7BqjxEKFySMLEcPSXI/GOLZu2UDzroJU84wQU8= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2019 06:58:34.6065 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e7156c1-6c46-4bc2-2b95-08d7368576c3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3802 Subject: Re: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Wednesday, September 11, 2019 13:38 > To: Ruifeng Wang (Arm Technology China) ; > Ananyev, Konstantin ; Kantecki, Tomasz > > Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; > Honnappa Nagarahalli ; nd > ; nd > Subject: RE: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd >=20 > > > > > > > > > > > > > > > > > > > > > > > > > > > Lock-free mode is supported by hash library and LPM library. > > > > > > Now we add an option for l3fwd example to enable the lock-free > > mode. > > > > > > Necessary preparation steps are added to use lock-free LPM mode= . > > > > > > > > > > Can I ask about the purpose of these changes? > > > > > Right now in l3fwd both lpm and hash tables are static and hard- > coded. > > > > > we initialize them at startup and then just do read from them. > > > > > Do you plan to enhance l3fwd with ability to dynamically update > > > > > tables contents? > > > > > Though fir that we first have to get rid of hard-coded values > > > > > (config file or > > > so). > > > > > Konstantin > > > > > > > > > Thanks for your questions. > > > > Currently, we have no plan to enhance l3fwd with ability to > > > > dynamically > > > update table contents. > > > > Lock-free method is being integrated into Hash library and LPM > > > > library. Lock-free algorithms are not only about control plane > > > > (adding or deleting routes), they affect the data path performance = as > well. > > > > Since l3fwd application is showcasing data path performance, we > > > > need to show the impact of including the quiescent state reporting > > > > on data > > path. > > > > This change also serves as an example of using the RCU APIs. > > > > > > > > > But what you suggest doesn't provide the complete picture. > > > With dynamic updates in place (via control path) the data-path > > > impact might be completely different then without. > > > Again without dynamic updates how can you test that your data-path > > > lock- free approach does work as expected? > > > Also it can't even be used as a reference implementation for users, > > > as half of the functionality they need to implement is simply missing= . > > > My opinion - we either need to leave l3fwd as it is (static routes), > > > or implement a proper control path with ability to dynamically > > > update routes before starting to introduce some synchronization > > > schemes (RCU or whatever). > > > > > > Konstantin > > > > > > > Agree that dynamic control path updates should be included for a whole > > picture. > > I will add dynamic update to l3fwd and reroll the patch series. > > Thanks. > I think we should have an agreement on what exactly we mean by > 'dynamically update routes'. > IMO, we should not disturb the existing static routes as there might be > automated tests running in the labs. I suggest that we should add/delete > new routes/hash entries which are different from the existing routes/hash > entries. This should be sufficient to showcase the functionality as well = as > measure the impact. >=20 Yes, existing static routes should be kept intact. To perform regular route/hash entries add/delete, a dedicated lcore will be= needed. An interactive prompt is not an option since we need automatic add/delete. We can skip master core for data path main loop. And perform unrelated rout= e/hash entries add/delete regularly on master core. The impact is that command lines used in tests will need update since maste= r core will no longer do data path work. > > > > > > > > > > > > > > > > > > Patch 2/2 has dependency on RCU QSBR integration with LPM > library: > > > > > > http://patches.dpdk.org/project/dpdk/list/?series=3D6288 > > > > > > > > > > > > > > > > > > Ruifeng Wang (2): > > > > > > examples/l3fwd: add lock-free option for l3fwd > > > > > > examples/l3fwd: integrate RCU QSBR for LPM mode > > > > > > > > > > > > doc/guides/sample_app_ug/l3_forward.rst | 3 ++ > > > > > > examples/l3fwd/Makefile | 1 + > > > > > > examples/l3fwd/l3fwd.h | 4 +- > > > > > > examples/l3fwd/l3fwd_em.c | 10 +++- > > > > > > examples/l3fwd/l3fwd_lpm.c | 72 > > > +++++++++++++++++++++++-- > > > > > > examples/l3fwd/main.c | 27 ++++++++-- > > > > > > examples/l3fwd/meson.build | 1 + > > > > > > 7 files changed, 108 insertions(+), 10 deletions(-) > > > > > > > > > > > > -- > > > > > > 2.17.1 > > >=20