Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel

[Slava Ovsiienko <viacheslavo@mellanox.com>]

Hi, Xiaoyu

There is a couple of small points to note:
1) It would be good to have the testpmd flow create command sample with new tunnels in commit log.
2) is it OK: "mlx5_flow_tunnel_ip_check(items, &last_item); " ?
    It looks like a bug, should the second parameter be "&item_flags" ? (if so - please, fix all
   calls of mlx5_flow_tunnel_ip_check()) 

WBR,
Slava

> -----Original Message-----
> From: Xiaoyu Min <jackmin@mellanox.com>
> Sent: Wednesday, July 10, 2019 13:15
> To: Raslan Darawsheh <rasland@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>;
> Yongseok Koh <yskoh@mellanox.com>; John McNamara
> <john.mcnamara@intel.com>; Marko Kovacevic
> <marko.kovacevic@intel.com>
> Cc: dev@dpdk.org
> Subject: [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel
> 
> Enabled IP-in-IP tunnel type support on DV/DR flow engine.
> This includes the following combination:
>  - IPv4 over IPv4
>  - IPv4 over IPv6
>  - IPv6 over IPv4
>  - IPv6 over IPv6
> 
> MLX5 NIC supports IP-in-IP tunnel via FLEX Parser so need to make sure fw
> using FLEX Paser profile 0.
> 
>   mlxconfig -d <mst device> -y set FLEX_PARSER_PROFILE_ENABLE=0
> 
> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
> ---
> v2:
>   * updated release note
> v3:
>   * rebased on 19.08-rc1
> ---
>  doc/guides/nics/mlx5.rst               | 15 ++++++++++-
>  doc/guides/rel_notes/release_19_08.rst |  1 +
>  drivers/net/mlx5/mlx5_flow.c           | 35 ++++++++++++++++++++++++
>  drivers/net/mlx5/mlx5_flow.h           |  6 ++++-
>  drivers/net/mlx5/mlx5_flow_dv.c        | 37 ++++++++++++++++++++++++++
>  5 files changed, 92 insertions(+), 2 deletions(-)
>