From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wang, Xiao W" <xiao.w.wang@intel.com>
Subject: Re: [PATCH v3 2/4] net/virtio: skip device probe in vdpa
	mode
Date: Mon, 2 Apr 2018 04:08:33 +0000
Message-ID: <B7F2E978279D1D49A3034B7786DACF406F85C261@SHSMSX101.ccr.corp.intel.com>
References: <20180321132108.52464-4-xiao.w.wang@intel.com>
 <20180331022929.42172-3-xiao.w.wang@intel.com>
 <1496487c-f3ea-dc34-dee7-dbaf40d54a97@redhat.com> <2836028.8kLeaZ6SVA@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Wang, Zhihong" <zhihong.wang@intel.com>, "yliu@fridaylinux.org"
 <yliu@fridaylinux.org>, "Tan, Jianfeng" <jianfeng.tan@intel.com>, "Bie,
 Tiwei" <tiwei.bie@intel.com>, "Liang, Cunming" <cunming.liang@intel.com>,
 "Daly, Dan" <dan.daly@intel.com>, "gaetan.rivet@6wind.com"
 <gaetan.rivet@6wind.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Maxime Coquelin
 <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id F32322BE5
 for <dev@dpdk.org>; Mon,  2 Apr 2018 06:08:38 +0200 (CEST)
In-Reply-To: <2836028.8kLeaZ6SVA@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Saturday, March 31, 2018 9:16 PM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>
> Cc: Wang, Xiao W <xiao.w.wang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; dev@dpdk.org; Wang, Zhihong
> <zhihong.wang@intel.com>; yliu@fridaylinux.org; Tan, Jianfeng
> <jianfeng.tan@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>; Liang, Cunmin=
g
> <cunming.liang@intel.com>; Daly, Dan <dan.daly@intel.com>;
> gaetan.rivet@6wind.com; Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: Re: [PATCH v3 2/4] net/virtio: skip device probe in vdpa mode
>=20
> Hi,
>=20
> 31/03/2018 13:13, Maxime Coquelin:
> > On 03/31/2018 04:29 AM, Xiao Wang wrote:
> > > If we want a virtio device to work in vDPA (vhost data path accelerat=
ion)
> > > mode, we could add a "vdpa=3D1" devarg for this device to specify the=
 mode.
> > >
> > > This patch let virtio pmd skip device probe when detecting this param=
eter.
> >
> > As we discussed, I would prefer a generic solution at EAL level.
>=20
> Please could you explain the requirement and the context?
> Can we use RTE_ETH_DEV_DEFERRED state and device ownership?
>=20
> Without knowing what's behind, I would say that a PMD should
> never skip a device by itself, but let other entities decide
> what to do with the probed device (thanks to probe notifications).
>=20

IFCVF's vendor ID and device ID are the same as that of virtio net pci devi=
ce,
with its specific subsystem vendor ID and device ID. The context is
IFCVF can be driven by both virtio pmd and IFCVF driver, so we add this
devarg to specify if we want the device to work in vDPA mode or not.
For vdpa-mode IFCVF, virtio pmd should not take over it, so we let it skip.

BRs,
Xiao