From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE035C31E44 for ; Fri, 14 Jun 2019 05:31:56 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 793B020851 for ; Fri, 14 Jun 2019 05:31:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 793B020851 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37B681D4AD; Fri, 14 Jun 2019 07:31:55 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4AD801D4A1 for ; Fri, 14 Jun 2019 07:31:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 22:31:51 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 13 Jun 2019 22:31:51 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 22:31:51 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 13 Jun 2019 22:31:51 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.33]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.83]) with mapi id 14.03.0439.000; Fri, 14 Jun 2019 13:31:49 +0800 From: "Mo, YufengX" To: Sunil Kumar Kori , "thomas@monjalon.net" , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] lib/librte_ethdev: add in default value of rte_eth_dev_info Thread-Index: AQHVFGc+1ZQ3twyec0eikaXODL6VgqaauwHg Date: Fri, 14 Jun 2019 05:31:49 +0000 Message-ID: References: <1558946129-5816-1-git-send-email-skori@marvell.com> <1558946129-5816-2-git-send-email-skori@marvell.com> In-Reply-To: <1558946129-5816-2-git-send-email-skori@marvell.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] lib/librte_ethdev: add in default value of rte_eth_dev_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Sunil Kumar Kori This series' patches have been merged on dpdk/master. They cause testpmd co= re dumped on intel nics. ./usertools/dpdk-devbind.py -b igb_uio 0000:xx:00.0 0000:xx:00.1 ./x86_64-native-linuxapp-gcc/app/testpmd -v -c 0x3f -n 4 -- -i Running environment as the following: * OS: fedora 20/22/27/30 3.16.4/4.4.14/5.1.0 * Compiler: gcc version 5.3.1 gcc version 7.3.1 gcc version 4.8.3 * Hardware platform: Broadwell-EP Xeon E5-2600 Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz * NIC hardware: fortville_spirit Ethernet Controller XL710 for 40GbE QSFP+ 1583 version: 1.5.16 firmware-version: 6.01 0x800034a4 1.1747.0 fortville(25G 2 ports nic) Ethernet Controller XXV710 for 25GbE SFP28 158b driver: i40e version: 2.1.14-k firmware-version: 6.01 0x80003554 1.1747.0 fortville(10G 2 ports nic) Ethernet Controller X710 for 10GbE SFP+ 1572 driver: i40e version: 2.1.14-k firmware-version: 6.01 0x800035b0 1.1747.0 niantic Device_str: 82599ES 10-Gigabit SFI/SFP+ Network Connection firmware: 0x61bf0001 ixgbe: 4.3.13 ixgbevf: 2.12.1-k > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sunil Kumar Kori > Sent: Monday, May 27, 2019 4:35 PM > To: thomas@monjalon.net; Yigit, Ferruh ; arybchen= ko@solarflare.com; Lu, Wenzhuo ; > Wu, Jingjing ; Iremonger, Bernard > Cc: dev@dpdk.org; Sunil Kumar Kori > Subject: [dpdk-dev] [PATCH 1/2] lib/librte_ethdev: add in default value o= f rte_eth_dev_info >=20 > rte_eth_dev_info structure exposes, nb_seg_max & nb_mtu_seg_max > to provide maximum number of supported segments for a given platform. >=20 > Defining UINT16_MAX as default value of above mentioned variables to > expose support of infinite/maximum segments. >=20 > Based on above values, application can decide best size for buffers > while creating mbuf pool. >=20 > Signed-off-by: Sunil Kumar Kori > --- > lib/librte_ethdev/rte_ethdev.c | 2 ++ > lib/librte_ethdev/rte_ethdev.h | 2 ++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethde= v.c > index d7cfa3d..6933757 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -2543,6 +2543,8 @@ struct rte_eth_dev * > .nb_max =3D UINT16_MAX, > .nb_min =3D 0, > .nb_align =3D 1, > + .nb_seg_max =3D UINT16_MAX, > + .nb_mtu_seg_max =3D UINT16_MAX, > }; >=20 > RTE_ETH_VALID_PORTID_OR_RET(port_id); > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethde= v.h > index 1f35e1d..6bd30b1 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -2333,6 +2333,8 @@ int rte_eth_dev_set_rx_queue_stats_mapping(uint16_t= port_id, > * .nb_max =3D UINT16_MAX, > * .nb_min =3D 0, > * .nb_align =3D 1, > + * .nb_seg_max =3D UINT16_MAX, > + * .nb_mtu_seg_max =3D UINT16_MAX, > * }; > * > * device =3D dev->device > -- > 1.8.3.1