Re: [dpdk-dev] [PATCH v8 4/6] examples/ntb: enable an example for ntb

["Li, Xiaoyun" <xiaoyun.li@intel.com>]

Hi

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Friday, June 28, 2019 01:30
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Wiles, Keith <keith.wiles@intel.com>;
> Liang, Cunming <cunming.liang@intel.com>; Maslekar, Omkar
> <omkar.maslekar@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v8 4/6] examples/ntb: enable an example for ntb
> 
> > -----Original Message-----
> > From: Li, Xiaoyun
> > Sent: Wednesday, June 26, 2019 3:12 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>; Wiles, Keith
> > <keith.wiles@intel.com>; Liang, Cunming <cunming.liang@intel.com>;
> > Maslekar, Omkar <omkar.maslekar@intel.com>
> > Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>
> > Subject: [PATCH v8 4/6] examples/ntb: enable an example for ntb
> >
> > Enable an example for rawdev ntb. Support interactive mode to send
> > file on one host and receive file from another host. The command line
> > would be 'send [filepath]' and 'receive [filepath]'.
> >
> > But since the FIFO is not enabled right now, use rte_memcpy as the
> > enqueue and dequeue functions and only support transmitting file no more
> than 4M.
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Reviewed-by: Jingjing Wu <jingjing.wu@intel.com>
> 
> The test app looks fine currently.
> Just one thought, if this example is temporary, can we just move this patch to
> test instead of example. As when the FIFO is done, this one be modified, right?

The file transmission will be reserved in next release, just support any size in next because of the introduce of FIFO.
And will add new cmdline to iofwd ntb device and eth device in next release. So example is a more appropriate choice.

> 
> Thanks
> Jingjing