DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: "Yu, Jin" <jin.yu@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Liu, Changpeng" <changpeng.liu@intel.com>,
	"Bie, Tiwei" <tiwei.bie@intel.com>,
	"Wang, Zhihong" <zhihong.wang@intel.com>,
	Lin Li <lilin24@baidu.com>, Xun Ni <nixun@baidu.com>,
	Yu Zhang <zhangyu31@baidu.com>
Subject: Re: [dpdk-dev] [PATCH v6 04/10] vhost: add two new messages to support a shared buffer
Date: Mon, 9 Sep 2019 03:06:20 +0000
Message-ID: <B9FBC361811A3D4DBB02350807E29F7B0B957106@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <e5e75f01-0e28-cb4d-e468-f33e4a694d11@redhat.com>

> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Saturday, September 7, 2019 1:23 AM
> To: Yu, Jin <jin.yu@intel.com>; dev@dpdk.org
> Cc: Liu, Changpeng <changpeng.liu@intel.com>; Bie, Tiwei
> <tiwei.bie@intel.com>; Wang, Zhihong <zhihong.wang@intel.com>; Lin Li
> <lilin24@baidu.com>; Xun Ni <nixun@baidu.com>; Yu Zhang
> <zhangyu31@baidu.com>
> Subject: Re: [PATCH v6 04/10] vhost: add two new messages to support a
> shared buffer
> 
> 
> 
> On 8/29/19 4:12 PM, JinYu wrote:
> > This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD
> and
> > VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer
> > between qemu and backend.
> >
> > Signed-off-by: Lin Li <lilin24@baidu.com>
> > Signed-off-by: Xun Ni <nixun@baidu.com>
> > Signed-off-by: Yu Zhang <zhangyu31@baidu.com>
> > Signed-off-by: Jin Yu <jin.yu@intel.com>
> > ---
> >  lib/librte_vhost/vhost.h      |   7 +
> >  lib/librte_vhost/vhost_user.c | 242
> ++++++++++++++++++++++++++++++++++
> >  lib/librte_vhost/vhost_user.h |   4 +-
> >  3 files changed, 252 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index
> > 884befa85..39f645b97 100644
> > --- a/lib/librte_vhost/vhost.h
> > +++ b/lib/librte_vhost/vhost.h
> > @@ -286,6 +286,12 @@ struct guest_page {
> >  	uint64_t size;
> >  };
> >
> > +struct inflight_mem_info {
> > +	int		fd;
> > +	void		*addr;
> > +	uint64_t	size;
> > +};
> > +
> >  /**
> >   * Device structure contains all configuration information relating
> >   * to the device.
> > @@ -303,6 +309,7 @@ struct virtio_net {
> >  	uint32_t		nr_vring;
> >  	int			dequeue_zero_copy;
> >  	struct vhost_virtqueue	*virtqueue[VHOST_MAX_QUEUE_PAIRS * 2];
> > +	struct inflight_mem_info inflight_info;
> 
> Could it be a pointer and allocated only if the feature has been negotiated?
Ok, will fix it.
> 
> >  #define IF_NAME_SZ (PATH_MAX > IFNAMSIZ ? PATH_MAX : IFNAMSIZ)
> >  	char			ifname[IF_NAME_SZ];
> >  	uint64_t		log_size;
> > diff --git a/lib/librte_vhost/vhost_user.c
> > b/lib/librte_vhost/vhost_user.c index c9e29ece8..647929234 100644
> > --- a/lib/librte_vhost/vhost_user.c
> > +++ b/lib/librte_vhost/vhost_user.c
> > @@ -49,6 +49,15 @@
> >  #define VIRTIO_MIN_MTU 68
> >  #define VIRTIO_MAX_MTU 65535
> >
> > +#define INFLIGHT_ALIGNMENT	64
> > +#define INFLIGHT_VERSION	0xabcd
> > +#define VIRTQUEUE_MAX_SIZE	1024
> > +
> > +#define CLOEXEC		0x0001U
> > +
> > +#define ALIGN_DOWN(n, m) ((n) / (m) * (m)) #define ALIGN_UP(n, m)
> > +ALIGN_DOWN((n) + (m) - 1, (m))
> > +
> >  static const char *vhost_message_str[VHOST_USER_MAX] = {
> >  	[VHOST_USER_NONE] = "VHOST_USER_NONE",
> >  	[VHOST_USER_GET_FEATURES] = "VHOST_USER_GET_FEATURES",
> @@ -78,6
> > +87,8 @@ static const char *vhost_message_str[VHOST_USER_MAX] = {
> >  	[VHOST_USER_POSTCOPY_ADVISE]  =
> "VHOST_USER_POSTCOPY_ADVISE",
> >  	[VHOST_USER_POSTCOPY_LISTEN]  =
> "VHOST_USER_POSTCOPY_LISTEN",
> >  	[VHOST_USER_POSTCOPY_END]  = "VHOST_USER_POSTCOPY_END",
> > +	[VHOST_USER_GET_INFLIGHT_FD] =
> "VHOST_USER_GET_INFLIGHT_FD",
> > +	[VHOST_USER_SET_INFLIGHT_FD] =
> "VHOST_USER_SET_INFLIGHT_FD",
> >  };
> >
> >  static int send_vhost_reply(int sockfd, struct VhostUserMsg *msg); @@
> > -160,6 +171,16 @@ vhost_backend_cleanup(struct virtio_net *dev)
> >  		dev->log_addr = 0;
> >  	}
> >
> > +	if (dev->inflight_info.addr) {
> > +		munmap(dev->inflight_info.addr, dev->inflight_info.size);
> > +		dev->inflight_info.addr = NULL;
> > +	}
> > +
> > +	if (dev->inflight_info.fd > 0) {
> > +		close(dev->inflight_info.fd);
> > +		dev->inflight_info.fd = -1;
> > +	}
> > +
> >  	if (dev->slave_req_fd >= 0) {
> >  		close(dev->slave_req_fd);
> >  		dev->slave_req_fd = -1;
> > @@ -1165,6 +1186,225 @@ virtio_is_ready(struct virtio_net *dev)
> >  	return 1;
> >  }
> >
> > +static int
> > +mem_create(const char *name, unsigned int flags) { #ifdef
> > +__NR_memfd_create
> > +	return syscall(__NR_memfd_create, name, flags); #else
> > +	return -1;
> > +#endif
> > +}
> 
> Maybe you could use memfd_create, as done in:
> lib/librte_eal/linux/eal/eal_memalloc.c
> 
Ok, I will see.


  reply index

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190806182500.22320>
2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 00/10] vhost: support inflight share memory protocol feature JinYu
2019-08-29 14:12   ` [dpdk-dev] [PATCH v6 01/10] vhost: add the inflight description JinYu
2019-09-06 16:37     ` Maxime Coquelin
2019-08-29 14:12   ` [dpdk-dev] [PATCH v6 02/10] vhost: add packed ring JinYu
2019-09-06 16:42     ` Maxime Coquelin
2019-08-29 14:12   ` [dpdk-dev] [PATCH v6 03/10] vhost: add the inflight structure JinYu
2019-09-06 16:45     ` Maxime Coquelin
2019-09-09  3:04       ` Yu, Jin
2019-08-29 14:12   ` [dpdk-dev] [PATCH v6 04/10] vhost: add two new messages to support a shared buffer JinYu
2019-09-06 17:22     ` Maxime Coquelin
2019-09-09  3:06       ` Yu, Jin [this message]
2019-08-29 14:12   ` [dpdk-dev] [PATCH v6 05/10] vhost: checkout and cleanup the resubmit inflight information JinYu
2019-09-09 10:20     ` Maxime Coquelin
2019-09-11  2:50       ` Yu, Jin
2019-09-11  8:43         ` Maxime Coquelin
2019-09-11  9:07           ` Yu, Jin
2019-08-29 14:12   ` [dpdk-dev] [PATCH v6 06/10] vhost: add the APIs to operate inflight ring JinYu
2019-09-11 13:19     ` Kevin Traynor
2019-09-12  9:26     ` Maxime Coquelin
2019-09-16  1:21       ` Yu, Jin
2019-08-29 14:12   ` [dpdk-dev] [PATCH v6 07/10] vhost: add APIs for user getting " JinYu
2019-09-12  9:28     ` Maxime Coquelin
2019-09-16  1:20       ` Yu, Jin
2019-08-29 14:12   ` [dpdk-dev] [PATCH v6 08/10] vhost: fix vring functions to support packed ring JinYu
2019-08-29 14:12   ` [dpdk-dev] [PATCH v6 09/10] vhost: add an API for judging vq format JinYu
2019-08-29 14:12   ` [dpdk-dev] [PATCH v6 10/10] vhost: add vhost-user-blk example which support inflight JinYu
2019-08-30  6:07   ` [dpdk-dev] [PATCH v6 00/10] vhost: support inflight share memory protocol feature Gavin Hu (Arm Technology China)
2019-09-06 16:35   ` Maxime Coquelin
2019-09-09  4:51     ` Yu, Jin

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9FBC361811A3D4DBB02350807E29F7B0B957106@SHSMSX101.ccr.corp.intel.com \
    --to=jin.yu@intel.com \
    --cc=changpeng.liu@intel.com \
    --cc=dev@dpdk.org \
    --cc=lilin24@baidu.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=nixun@baidu.com \
    --cc=tiwei.bie@intel.com \
    --cc=zhangyu31@baidu.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox