From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E01C31E77 for ; Mon, 10 Jun 2019 14:32:04 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id CC6CA207E0 for ; Mon, 10 Jun 2019 14:32:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC6CA207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 28BC21C067; Mon, 10 Jun 2019 16:32:02 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id BA6631C035 for ; Mon, 10 Jun 2019 16:31:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2019 07:31:58 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 10 Jun 2019 07:31:57 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 10 Jun 2019 07:31:57 -0700 Received: from fmsmsx115.amr.corp.intel.com ([169.254.4.97]) by FMSMSX109.amr.corp.intel.com ([169.254.15.58]) with mapi id 14.03.0415.000; Mon, 10 Jun 2019 07:31:57 -0700 From: "Carrillo, Erik G" To: Anoob Joseph , Jerin Jacob , "Rao, Nikhil" , "Gujjar, Abhinandan S" , "Richardson, Bruce" , "De Lara Guarch, Pablo" CC: Narayana Prasad , "dev@dpdk.org" , Lukasz Bartosik , Pavan Nikhilesh , Hemant Agrawal , "Nipun Gupta" , "Van Haaren, Harry" , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "Ma, Liang J" Thread-Topic: [PATCH 32/39] eventdev: add routine to launch eventmode workers Thread-Index: AQHVGjLtu56PyxAMAkWUTtITb3ilvaaU+kDA Date: Mon, 10 Jun 2019 14:31:57 +0000 Message-ID: References: <1559583160-13944-1-git-send-email-anoobj@marvell.com> <1559583160-13944-33-git-send-email-anoobj@marvell.com> In-Reply-To: <1559583160-13944-33-git-send-email-anoobj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmY0ZDA5YjctMWZkZi00N2FmLWI2NGMtYjNmZTc3NjQzOGZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ3BFTzAwTjI2clR6eDFxWXY0S09EXC80V0VaK21rMUExcUt6VWx0SDBpMjJRQkhzRmhXak16bTR5SFwvVzFaTHZYIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 32/39] eventdev: add routine to launch eventmode workers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, I've listed a few notes in-line. > -----Original Message----- > From: Anoob Joseph > Sent: Monday, June 3, 2019 12:33 PM > To: Jerin Jacob ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Narayana Prasad > ; dev@dpdk.org; Lukasz Bartosik > ; Pavan Nikhilesh ; > Hemant Agrawal ; Nipun Gupta > ; Van Haaren, Harry > ; Mattias R=F6nnblom > ; Ma, Liang J > Subject: [PATCH 32/39] eventdev: add routine to launch eventmode workers >=20 > With eventmode, workers could be drafted differently according to the > capabilities of the underlying event device. The added function would > receive an array of such workers and probes the eventmode properties to > choose the worker. >=20 > Signed-off-by: Anoob Joseph > Signed-off-by: Lukasz Bartosik > --- <...snipped...> > + > +/* Event mode packet tx types */ > +enum rte_eventmode_helper_tx_types { > + RTE_EVETNMODE_HELPER_TX_TYPE_INVALID =3D 0, A couple of characters are transposed in the above. > + RTE_EVENTMODE_HELPER_TX_TYPE_MAX =3D 16 > +}; > + > struct rte_eventmode_helper_conf { > enum rte_eventmode_helper_pkt_transfer_mode mode; > /**< Packet transfer mode of the application */ @@ -41,6 > +55,20 @@ struct rte_eventmode_helper_event_link_info { > /**< Lcore to be polling on this port */ }; > I believe anonymous unions and structures should be annotated with RTE_STD_= C11 below and in other places throughout the series. > +/* Workers registered by the application */ struct > +rte_eventmode_helper_app_worker_params { > + union { > + struct { > + uint64_t burst : 4; > + /**< Specify status of rx type burst */ > + }; > + uint64_t u64; > + } cap; > + /**< Capabilities of this worker */ > + void (*worker_thread)(void *mode_conf); > + /**< Worker thread */ > +}; > + > /* Common helper functions for command line parsing */ >=20 > /** > @@ -157,6 +185,27 @@ uint8_t __rte_experimental > rte_eventmode_helper_get_tx_queue(struct rte_eventmode_helper_conf > *mode_conf, > uint8_t eventdev_id); >=20 The doxygen documentation for __rte_experimental functions in general shoul= d have: * @warning = =20 * @b EXPERIMENTAL: this API may change without prior notice as well. > +/** > + * Launch eventmode worker > + * > + * The application can request the eventmode helper subsystem to launch > +the > + * worker based on the capabilities of event device and the options > +selected > + * while initializing the eventmode. > + * > + * @param mode_conf > + * Configuration of the mode in which app is doing packet handling > + * @param app_wrkr > + * List of all the workers registered by application, along with it's > + * capabilities > + * @param nb_wrkr_param > + * Number of workers passed by the application > + * > + */ > +void __rte_experimental > +rte_eventmode_helper_launch_worker(struct > rte_eventmode_helper_conf *mode_conf, > + struct rte_eventmode_helper_app_worker_params > *app_wrkr, > + uint8_t nb_wrkr_param); > + > #ifdef __cplusplus > } > #endif <...snipped...> Regards, Erik