Re: [dpdk-dev] [PATCH 24/39] eventdev: add Rx adapter init in eventmode

["Carrillo, Erik G" <erik.g.carrillo@intel.com>]

> -----Original Message-----
> From: Anoob Joseph <anoobj@marvell.com>
> Sent: Monday, June 3, 2019 12:32 PM
> To: Jerin Jacob <jerinj@marvell.com>; Rao, Nikhil <nikhil.rao@intel.com>;
> Carrillo, Erik G <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Narayana Prasad
> <pathreya@marvell.com>; dev@dpdk.org; Lukasz Bartosik
> <lbartosik@marvell.com>; Pavan Nikhilesh <pbhagavatula@marvell.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Nipun Gupta
> <nipun.gupta@nxp.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Mattias Rönnblom
> <mattias.ronnblom@ericsson.com>; Ma, Liang J <liang.j.ma@intel.com>
> Subject: [PATCH 24/39] eventdev: add Rx adapter init in eventmode
> 
> Adding rx adapter conf. The helper init routine would be initializing the rx
> adapter according to the conf.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> Signed-off-by: Lukasz Bartosik <lbartosik@marvell.com>
> ---

<...Snipped...>

> diff --git a/lib/librte_eventdev/rte_eventmode_helper_internal.h
> b/lib/librte_eventdev/rte_eventmode_helper_internal.h
> index 2a6cd90..9c68605 100644
> --- a/lib/librte_eventdev/rte_eventmode_helper_internal.h
> +++ b/lib/librte_eventdev/rte_eventmode_helper_internal.h
> @@ -35,6 +35,12 @@
>  /* Max event devices supported */
>  #define EVENT_MODE_MAX_EVENT_DEVS RTE_EVENT_MAX_DEVS
> 
> +/* Max Rx adapters supported */
> +#define EVENT_MODE_MAX_RX_ADAPTERS RTE_EVENT_MAX_DEVS
> +
> +/* Max Rx adapter connections */
> +#define EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER 16
> +
>  /* Max event queues supported per event device */  #define
> EVENT_MODE_MAX_EVENT_QUEUES_PER_DEV
> RTE_EVENT_MAX_QUEUES_PER_DEV
> 
> @@ -50,12 +56,33 @@ struct eventdev_params {
>  	uint8_t ev_queue_mode;
>  };
> 

Should the struct below be named "rx_adapter_connection_info" since you add "tx_adapter_connection_info" in a later patch?

> +/* Rx adapter connection info */
> +struct adapter_connection_info {
> +	uint8_t ethdev_id;
> +	uint8_t eventq_id;
> +	int32_t ethdev_rx_qid;
> +};
> +
> +/* Rx adapter conf */
> +struct rx_adapter_conf {
> +	int32_t eventdev_id;
> +	int32_t adapter_id;
> +	uint32_t rx_core_id;
> +	uint8_t nb_connections;
> +	struct adapter_connection_info
> +
> 	conn[EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER];
> +};
> +

<...Snipped...>

Regards,
Erik