From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF8BC76191 for ; Thu, 18 Jul 2019 10:52:30 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id AF8F22173B for ; Thu, 18 Jul 2019 10:52:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="SkzPIta0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="DWJEU/f+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF8F22173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 562BD1DBF; Thu, 18 Jul 2019 12:52:28 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 1D96B1DBE for ; Thu, 18 Jul 2019 12:52:26 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6IAqQE9001016; Thu, 18 Jul 2019 03:52:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=uOV+jdc30oKetx/29DL0MmYdWH+k+CwuIoIQFHg//jo=; b=SkzPIta0N5oPLRuNPwgHHy2iqsOKgury2babpTUlAZfjbsxY2LmZz/uOkkdZRI11CZvF KXg7BwIR99IVU7Y+ko1Pp/xPVGoUPZBGiirKM7rfGNSAwmVPXZL+zEJ/Bx2UOb2p0+Kl H4SC4x8yoasG7v35cnT4LLsUtzp8EO9GisIY40OdtO3K4EufeFPlsUgSGZUPIHMx+4BX cquAGcQDmxPQ1BwAZoWyyD3PBGskmaipy5y5EXy9gvMTev3tFhYFVyLgmXdP3JKWZ5ha 4tGKloeWqqlScmprkF5SQE4oEjpaBH38TK+Nmak/aUfaXbjhHpsT3a5S1Wkl9Pn6QZCQ xA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2ts0a2bm08-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2019 03:52:26 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 18 Jul 2019 03:52:24 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.54) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 18 Jul 2019 03:52:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BRzxE6xza+niMmsuD/id7QpB1Rf+fLZ+AzPUMz6lqVwpCoxj3ky28bcKtH8zYb2DK0kGvS0UFDIsPB9sIgMf0JOgXqNiix5Xs2MO0RUeJAp2PtRpJ/v9xSYa5X3grpU1f6w/YhwJoLud4j2UQAL3XIizDVS68fmWWklyT/2ZT97opZu9ktwJiHrEtWI+8s5VvU0kWnmgfB+9M6qw5i0kXmqgoo+koc9TqIJG0sEJstD/TkeVAA8+ez746DAoMQvkxCN/OwoINNiPPbJYDykJOZudPTNOkVMF7yFVnKQofBg3VXYs4A+fJ8w7RfAIO44M5h+qKaG6Z0k9RhebM6s+Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uOV+jdc30oKetx/29DL0MmYdWH+k+CwuIoIQFHg//jo=; b=RLwvY5KJu7yOIxiwZBKPKwF0NqePp4KKA4aMnY6Vh4YlE95vsVqlfWW95VYVSjFk+yjGq6MHUp746uqPWn0azqRna1o6A6R3NexfE1UX26tkQXwty97yYPYWbjB+bIBPLkQ8gO59If9B78wa8562tT8ZEQe3Id9DSvpkwH+eqlTU6HQk76Dx5R24D6wdhHd6V6QOWouDp0jALje6X8BMMEwI4vjxlNMXw3KExQZu0Jjzg8J6lC3AYdWX55pYBW47hmNzQNFjhaxSs5LOIbdgS6vglCgJBk05N1ilT0JsPZN6u2rhxAKsRDRgO+SDHpXRjK4H544tvCSjBdHApHPNVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uOV+jdc30oKetx/29DL0MmYdWH+k+CwuIoIQFHg//jo=; b=DWJEU/f+VmwGDdGaDHv8N/LjACngooqj3FSbH+bYK2jTyxqVLcrTiZL9UlGirNzmxPXFSLyQNOmCkG2Zw8PEXucwUJMLJBpv3LX4RWaB9Xqb0GONolh1PVaYsCACobsQS7HMr1FzA2KbUVCn/3rrfRr24LDwbINFcuN9XBlJDhQ= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB1988.namprd18.prod.outlook.com (10.161.155.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12; Thu, 18 Jul 2019 10:52:22 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72%6]) with mapi id 15.20.2073.012; Thu, 18 Jul 2019 10:52:22 +0000 From: Shally Verma To: "Nowak, DamianX" , "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto Thread-Index: AQHVPUbadrKdxQ51eEG6ykcn6BOLRKbQMt6w Date: Thu, 18 Jul 2019 10:52:21 +0000 Message-ID: References: <20190717125111.11288-1-arkadiuszx.kusztal@intel.com> <6976F642F4CB7B4C9D17DE41C99F326055D090CE@hasmsx107.ger.corp.intel.com> In-Reply-To: <6976F642F4CB7B4C9D17DE41C99F326055D090CE@hasmsx107.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.169.231.225] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cca038c8-feb9-4bf5-1916-08d70b6e02f4 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN6PR1801MB1988; x-ms-traffictypediagnostic: BN6PR1801MB1988: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 01026E1310 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(39840400004)(136003)(396003)(346002)(199004)(189003)(13464003)(66556008)(66476007)(66446008)(64756008)(52536014)(81166006)(81156014)(8936002)(26005)(446003)(2906002)(11346002)(186003)(476003)(86362001)(66066001)(305945005)(66946007)(2501003)(76116006)(71190400001)(71200400001)(478600001)(99286004)(8676002)(54906003)(110136005)(316002)(7736002)(5660300002)(74316002)(55016002)(9686003)(68736007)(6246003)(6116002)(3846002)(6436002)(486006)(25786009)(33656002)(53936002)(229853002)(14444005)(256004)(102836004)(76176011)(14454004)(53546011)(6506007)(4326008)(6306002)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB1988; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: SMdoyGF6HjaR0m1r650CIY3rMSliIvQMGyACqmSyLahialUvutwAsbi6C8QtS704DiaYnghyolYVs1PQX76hW2AhQ3hEWGES5ePvTNrJYNi9IixOt2AAg/XI9Eb42lOYrFWpH3c+Y9GOrV3P+UwhRjJNWgYwFQSdBonBN3TOOjuLE7DGQxpxnvyaBIsqZbkkysXR/Z8rgY205/lczjqmgcN/zsYXQyFJmpRB4at9mSm4SR6WTnfLkOTqz+qcIWf3s/HgAeSNyhXIFNBKLmXC7rLFmxlpLsqWaH+WoFhB/ZZnchxP5EYPd+C7Ucw/sz7BbAkQZAuEnSA1v7fMxqhXJ9DTBxXjM3PRzh/Y1zq9U8Qca23jnbQHgmeqnSxaSiQxK2xKMvmwf7RndJX6QNWUxZtvs/oeN/KbSkfvlKd/oFs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: cca038c8-feb9-4bf5-1916-08d70b6e02f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 10:52:21.8305 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shallyv@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB1988 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-18_05:2019-07-18,2019-07-18 signatures=0 Subject: Re: [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Nowak, DamianX > Sent: Thursday, July 18, 2019 2:28 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona ; Shally > Verma > Subject: [EXT] RE: [PATCH v4 00/11] Rework API for RSA algorithm in > asymmetric crypto >=20 > External Email >=20 > ---------------------------------------------------------------------- > > -----Original Message----- > > From: Kusztal, ArkadiuszX > > Sent: Wednesday, July 17, 2019 14:51 > > To: dev@dpdk.org > > Cc: akhil.goyal@nxp.com; Trahe, Fiona ; > > shallyv@marvell.com; Nowak, DamianX ; > > Kusztal, ArkadiuszX > > Subject: [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric > > crypto > > > > Split into smaller commits, in order from least disputable ones. > > Open things beside this: > > 1. Creating padding struct > > 2. Padding parameters (seedlen, optional label etc) 3. Leading zeroes > > questions. > > 4. Random number requirements. > > 5. Capabilities. > > 6. Verify signature field when none padding. > > > > v4: > > - change API comments from length -> array allocation to avoid > > ambiguity > > > > v3: > > - split into smaller patches > > - removed padding struct changes > > - rebased against patches from CRT patches from Ayuj Verma > > > > v2: > > - Field for singature verification when padding none selected was > > added > > - Removed details from RFC > > - Simplified padding struct > > - Added padding none test case > > > > This patchset depends on following patches: > > [1] > > test/crypto: move rsa enqueue/dequeue into separate functions > > (http://patchwork.dpdk.org/patch/56342/) > > [2] > > test/crypto: add tests for RSA key type CRT > > (http://patchwork.dpdk.org/patch/56343/) > > > > Arek Kusztal (11): > > cryptodev: change RSA API comments about primes > > cryptodev: add cipher field to RSA op > > crypto/openssl: add cipher field to openssl RSA implementation > > test: add cipher field to RSA test > > cryptodev: add information about message format when signing with RSA > > cryptodev: remove RSA PKCS1 BT0 padding > > openssl: remove RSA PKCS1_5 BT0 padding > > test: remove RSA PKCS1_5 BT0 padding from test cases > > cryptodev: add RSA padding none description > > test: add pkcs1_5 padding simulation > > test: add RSA PKCS1_5 padding case when no padding selected > > > > app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++----= -- > > app/test/test_cryptodev_asym_util.h | 54 > > +++++++++++++++++++++++++++ > > drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++--- > > lib/librte_cryptodev/rte_crypto_asym.h | 64 > > ++++++++++++++++++++++++-------- > > 4 files changed, 149 insertions(+), 34 deletions(-) > > > > -- > > 2.1.0 >=20 > Series-acked-by: Damian Nowak I had ack'd some. But others which are Nack'd , we need more time for them. So, from my end, which are Ack'd good to go but other need to wait. Thanks Shally