dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Shally Verma <shallyv@marvell.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
	"Nowak, DamianX" <damianx.nowak@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto
Date: Thu, 18 Jul 2019 13:18:06 +0000	[thread overview]
Message-ID: <BN6PR1801MB2052C44309A69E49DB4B7280ADC80@BN6PR1801MB2052.namprd18.prod.outlook.com> (raw)
In-Reply-To: <06EE24DD0B19E248B53F6DC8657831551B281083@hasmsx109.ger.corp.intel.com>



> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Thursday, July 18, 2019 6:39 PM
> To: Shally Verma <shallyv@marvell.com>; Nowak, DamianX
> <damianx.nowak@intel.com>; dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: [EXT] RE: [PATCH v4 00/11] Rework API for RSA algorithm in
> asymmetric crypto
> 
> External Email
> 
> ----------------------------------------------------------------------
> > > >
> > > > Split into smaller commits, in order from least disputable ones.
> > > > Open things beside this:
> > > > 1. Creating padding struct
> > > > 2. Padding parameters (seedlen, optional label etc) 3. Leading
> > > > zeroes questions.
> > > > 4. Random number requirements.
> > > > 5. Capabilities.
> > > > 6. Verify signature field when none padding.
> > > >
> > > > v4:
> > > > - change API comments from length -> array allocation to avoid
> > > > ambiguity
> > > >
> > > > v3:
> > > > - split into smaller patches
> > > > - removed padding struct changes
> > > > - rebased against patches from CRT patches from Ayuj Verma
> > > >
> > > > v2:
> > > > - Field for singature verification when padding none selected was
> > > > added
> > > > - Removed details from RFC
> > > > - Simplified padding struct
> > > > - Added padding none test case
> > > >
> > > > This patchset depends on following patches:
> > > > [1]
> > > > test/crypto: move rsa enqueue/dequeue into separate functions
> > > > (http://patchwork.dpdk.org/patch/56342/)
> > > > [2]
> > > > test/crypto: add tests for RSA key type CRT
> > > > (http://patchwork.dpdk.org/patch/56343/)
> > > >
> > > > Arek Kusztal (11):
> > > >   cryptodev: change RSA API comments about primes
> > > >   cryptodev: add cipher field to RSA op
> > > >   crypto/openssl: add cipher field to openssl RSA implementation
> > > >   test: add cipher field to RSA test
> > > >   cryptodev: add information about message format when signing
> > > > with
> > RSA
> > > >   cryptodev: remove RSA PKCS1 BT0 padding
> > > >   openssl: remove RSA PKCS1_5 BT0 padding
> > > >   test: remove RSA PKCS1_5 BT0 padding from test cases
> > > >   cryptodev: add RSA padding none description
> > > >   test: add pkcs1_5 padding simulation
> > > >   test: add RSA PKCS1_5 padding case when no padding selected
> > > >
> > > >  app/test/test_cryptodev_asym.c           | 53 ++++++++++++++++++++--
> ----
> > > >  app/test/test_cryptodev_asym_util.h      | 54
> > > > +++++++++++++++++++++++++++
> > > >  drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++---
> > > >  lib/librte_cryptodev/rte_crypto_asym.h   | 64
> > > > ++++++++++++++++++++++++--------
> > > >  4 files changed, 149 insertions(+), 34 deletions(-)
> > > >
> > > > --
> > > > 2.1.0
> > >
> > > Series-acked-by: Damian Nowak <damianx.nowak@intel.com>
> > I had ack'd some. But others which are Nack'd , we need more time for
> them.
> > So, from my end, which are Ack'd good to go but other need to wait.
> 
> As I generally agree that we need far more time to get all things done, I
> would like to know what is current situation:
> 
> We should apply
> 1) Cipher field
I assume I acked it with some improvement requirement on description. Let me know if I did not.

> 2) Remove BT0
> 
> We should still discuss (possibly 19.11)
> 1) Signature input format
> 2) None padding
> 
[Shally] Yes but sorry I don't recall if it covers all patches I Nack'd . I , specifically, Acked some ,which are good to go.

> Is this correct?
> 

> 
> 
> >
> > Thanks
> > Shally

      reply	other threads:[~2019-07-18 13:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 12:51 [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 01/11] cryptodev: change RSA API comments about primes Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 02/11] cryptodev: add cipher field to RSA op Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 03/11] crypto/openssl: add cipher field to openssl RSA implementation Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 04/11] test: add cipher field to RSA test Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 05/11] cryptodev: add information about message format when signing with RSA Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 06/11] cryptodev: remove RSA PKCS1 BT0 padding Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 07/11] openssl: remove RSA PKCS1_5 " Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 08/11] test: remove RSA PKCS1_5 BT0 padding from test cases Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 09/11] cryptodev: add RSA padding none description Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 10/11] test: add pkcs1_5 padding simulation Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 11/11] test: add RSA PKCS1_5 padding case when no padding selected Arek Kusztal
2019-07-17 16:00 ` [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto Trahe, Fiona
2019-07-18  8:57 ` Nowak, DamianX
2019-07-18 10:52   ` Shally Verma
2019-07-18 13:09     ` Kusztal, ArkadiuszX
2019-07-18 13:18       ` Shally Verma [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR1801MB2052C44309A69E49DB4B7280ADC80@BN6PR1801MB2052.namprd18.prod.outlook.com \
    --to=shallyv@marvell.com \
    --cc=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=damianx.nowak@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).