From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDFCAC76186 for ; Wed, 17 Jul 2019 07:32:20 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 704092173B for ; Wed, 17 Jul 2019 07:32:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="IclGv1Cp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="gujuoJ/s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 704092173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 04068137C; Wed, 17 Jul 2019 09:32:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id AAEE4F04 for ; Wed, 17 Jul 2019 09:32:17 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6H7UG4g020199; Wed, 17 Jul 2019 00:32:16 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Qexhb+JDyNxrvKJpr0NHKD4FA9p5jLHk5DPP+7TsgrA=; b=IclGv1Cp7QzazUPAIbMeg0A9Dbg6JybxDxYDbEy0pUddArtwfVtdtN/Clh95La0fC3jh n/by49OBXB+dd6NG5iXrEPpNGN3ZUnEsTuJyBJj97sAG+aHj4XxwtGEMD1479e5MyNn5 YjUAnIiGxHKeeDwojG/gVg0tc2hkuEIEGKCaGi4oVsN36F5tH9tsefBxLVBa4PDJBExn WELSK0ispiVdfR0I2BN4qhrEcX6R/VOyNKn3xUPt7c1DYcSHq4Vpn59rFRne0oxkPLtz FJZc5XNFOhKg0TQ7+7XMujNG/ETnLYOx1D4eSzD69aTfIV6vh3m9za2bvTDF9dAjL7ay fQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2ts0a26n00-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 17 Jul 2019 00:32:16 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 17 Jul 2019 00:32:13 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.51) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 17 Jul 2019 00:32:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MMln5TJ0AAMtIiNeKhEL6PqzGSJEiedfRqzNi+LhDpkVmlfxAY4co09rc8/kKEzsc2qVtt0zcFN8vEQoi1MH/rgA+bYVmwbDsUGCVJ1FWYzIt92eXrRa74UXxBZQAsErWf/dvuitSrNZPQB2jaM50LAQAJIEZIPYRkfS0XbTRxuWeeqDYzm8yR/DskFgnseJNwQ9i3LCAX+3OMxqgXrcQhzDX6Doa7Gr/Vj6hhTQCMMGjqC2IwKdt4OCrKYd+WhdoD1z8CmnR9sqgrdzlMFtUG4s0WZRRyP8PKS0v4x8bFu+muwa9irHB5gD73BUW8jAvZuBgGsLzfOBsIjesxmgVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qexhb+JDyNxrvKJpr0NHKD4FA9p5jLHk5DPP+7TsgrA=; b=IyGZxReCrv6Q+bMOYwYMfJOHdFDZ57nDVWHaHELIyu6smVORxjdd9glupfts1+MJrcswXqEKUDklsjwYE03hLbCx7WDp7/qGi7gWlsPvSkZyL7G2M0IQ6+wCE7s39mm8gQXCzVm2qTVhy0qnJDJd/RK1V/Me9EFASxTkhrWs60Rh0SOhwwOP40OJtcVnALNo59AJPwN0Z9kEqJB7uhprgMqyishiYxjiTI5twAGzDkJN/hi9ww9t7Qwbl7dZwnM8AEl429LIiP1gV/GzTGPHh4P9PuFNOu8P8R/RSJ3vxw6U14jIlQjuft+Pzwr3xzJGeEjJBNu6Ep21M5DmmBoYVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qexhb+JDyNxrvKJpr0NHKD4FA9p5jLHk5DPP+7TsgrA=; b=gujuoJ/s9uHSLjTQcX4mxNy0LyfbRDaiyK2ZxcKfmjDPcdJjXXc8zZ7+l3+sUBKZY3aCUnAC3lhEHZnghdFZkR+XdCzhHOn6tjbOLnR66k1+3VmrPiLqmB3T1JSEYZwjCWm5YfUpZ6MmKXCaN/ZPM1IDj7NJ552lkPe0o7IBAR8= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB1873.namprd18.prod.outlook.com (10.161.156.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Wed, 17 Jul 2019 07:32:11 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72%6]) with mapi id 15.20.2073.012; Wed, 17 Jul 2019 07:32:11 +0000 From: Shally Verma To: Arek Kusztal , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "fiona.trahe@intel.com" Thread-Topic: [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments about primes Thread-Index: AQHVPAe/R/ZBMnh6OEuFBLKN6gft7qbOaPDA Date: Wed, 17 Jul 2019 07:32:11 +0000 Message-ID: References: <20190716185304.12592-1-arkadiuszx.kusztal@intel.com> <20190716185304.12592-2-arkadiuszx.kusztal@intel.com> In-Reply-To: <20190716185304.12592-2-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.169.231.225] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b1af6829-fa18-4e75-6b7c-08d70a88e1fc x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN6PR1801MB1873; x-ms-traffictypediagnostic: BN6PR1801MB1873: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:311; x-forefront-prvs: 01018CB5B3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(39860400002)(366004)(136003)(346002)(13464003)(199004)(189003)(66066001)(76116006)(54906003)(110136005)(66476007)(74316002)(316002)(64756008)(66446008)(305945005)(53546011)(33656002)(6506007)(102836004)(53936002)(99286004)(7736002)(68736007)(55016002)(66556008)(25786009)(2501003)(478600001)(3846002)(52536014)(486006)(6436002)(9686003)(26005)(7696005)(6246003)(86362001)(5660300002)(81166006)(71200400001)(14454004)(81156014)(71190400001)(186003)(8676002)(11346002)(66946007)(229853002)(4326008)(446003)(2906002)(14444005)(256004)(76176011)(476003)(8936002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB1873; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: V9QFlmo7f9r+jc5JXHdH6wvNGmJgbb/aSM5svtigjyQpkTkaEcuYg2MEwklLZUc28SfprL+i05icyYuNc//0WH8+u70HdSn/krFhcV7AW9TZrmvI4hQdFndALx9IdJsnzUE0VmIDxqldEiO3hJoJbG4k2xjzxy8RUlY7K1QNuyxylAXo6IvaW5izktKS1VQSV+tzW8VOWPiZpJgq39HcTJ3COUoO2kn1frEE71FoaZdK0clmNGVw9DHh3zjPn2CTJUgHabNIlkvPtwrJYXw1q9mujNBgizVb6teiAiBJwLgv1DtIW3NEeTtDtSlZDe9ciiD1Z3U9LDuDI28VyjJ/D+tUNJdhr6mLakZDKZO+Gu+XHoZUqOFVeco0BWyO3e9l2AzB9tPZi976y13oB/YS2q7/PT3FACHZuN/wPiOJF80= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b1af6829-fa18-4e75-6b7c-08d70a88e1fc X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2019 07:32:11.7381 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shallyv@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB1873 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-17_02:2019-07-16,2019-07-17 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments about primes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments about > primes >=20 > External Email >=20 > ---------------------------------------------------------------------- > RSA modulus cannot be prime as its security basing on integer factorizati= on. >=20 [Shally] I think you mean here that "RSA modulus input cannot be prime as i= t is multiple of 2 primes" > Signed-off-by: Arek Kusztal > --- Other than minor rephrasing requirement on commit log, change is=20 Acked-by: Shally Verma > lib/librte_cryptodev/rte_crypto_asym.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > b/lib/librte_cryptodev/rte_crypto_asym.h > index 8672f21..02ec304 100644 > --- a/lib/librte_cryptodev/rte_crypto_asym.h > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > @@ -199,8 +199,8 @@ struct rte_crypto_rsa_priv_key_qt { > */ > struct rte_crypto_rsa_xform { > rte_crypto_param n; > - /**< n - Prime modulus > - * Prime modulus data of RSA operation in Octet-string network > + /**< n - Modulus > + * Modulus data of RSA operation in Octet-string network > * byte order format. > */ >=20 > @@ -409,7 +409,7 @@ struct rte_crypto_rsa_op_param { > * over-written with generated signature. > * > * Length of the signature data will be equal to the > - * RSA prime modulus length. > + * RSA modulus length. > */ >=20 > enum rte_crypto_rsa_padding_type pad; > -- > 2.1.0