From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C96A7C76186 for ; Wed, 17 Jul 2019 10:07:57 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 603932173E for ; Wed, 17 Jul 2019 10:07:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="jvbeh8Qv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="M/OefKnS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 603932173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 47CE71B53; Wed, 17 Jul 2019 12:07:56 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 858D6137C for ; Wed, 17 Jul 2019 12:07:54 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6HA529H026281; Wed, 17 Jul 2019 03:07:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=lOuFeFws8ictFKm1Rs0c1vpELj491e5fbYE9niq8hZQ=; b=jvbeh8QvNnHcGGOP2s7cS4v4HGbGGKyCmwQ2JtVotn6Z4nfEjP6cUfMmROu2mRFMFSqU 9UpgaL9V+J5agrd0BsCnHvxGYshvfHz5EhpnQAW8RtNCjjILGQXzeNMtuVQXn7U5EMoz zkAbgm3XAHde4C1tbZXFngUkzess/COjVEPJXVBPeR5COLrOibV4+MHOJ5afx39FaZvF AqAFf/4Wgllz4Cf21GFNkBPzSs/GIh5HCImFC03FiSPoS6lwTxNRGHwl1vHZSy6QP9t1 lMTVbz7qyAW3vzWB5eB15Vwe3EMpqClZfwEyF/EmCKekVcCcyt3xpm6fnblAXY5ECYud RA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2ts07vfq9r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 17 Jul 2019 03:07:53 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 17 Jul 2019 03:07:52 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.54) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 17 Jul 2019 03:07:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NUPIdkT4EHnDLSiA5lcfqyxkn9VMYmTBS/lwquhIgHFEgEUTGh1H/tV6R9iK5NgAP/DONU3crny6uUhWfwmLKqBAKqfqK+/uaU0sBbu5fUJ0zuQVtb6if7TgDqfUm6oMLZmcOWs2VXuhHf0QLLQyi3YyYcNOnFcL1x44GHh2uWfydVgfM2ggyB7QYeXk63yd0tYnben+QI+tXYWj9bujmcNDQeJ70yZ8h1aoXAs1ZDWPpX0LR2aVeKgbGd+a48r3x6ivAPpqM2IvHxWaw2RWEdCbzc+abd14LNuvPUHylZORUuc/7LTWpFiPLW5V/LGXyDo50K1j+VymsfeaaFzbxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lOuFeFws8ictFKm1Rs0c1vpELj491e5fbYE9niq8hZQ=; b=SYfgh1JlZUW9KaN7fkN+n+Q2gXOSDr1i+19c9VMRfS9ZZ0/mNt0wFXRTsOBt4ZLmj9YVkV1q50/ez/CTa7Cw/MXYhsSjnxmWj1YQSFJLAz4+bNNCBuYBIquQpQy02aVu2mwldxIiKOAMhUOaXntvc3C7ks5MWiR1iAm+xFHvRP9cK5SpU65xd7YKAait8UX2S/ggjV8Fo3+hbkWmiYi1F9nN6+syWyViUY6Mv/JlpCs4fpLf2Y+wCZMh0uVkUiQRAO+Qour85qphDHpTO6IYvTPtJMxjWH8nHNQ/Jrnq24o3d3ujGArxuIXObW1CzLIDGfF83JGGFI6EQcqHueecyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lOuFeFws8ictFKm1Rs0c1vpELj491e5fbYE9niq8hZQ=; b=M/OefKnSjtrvge8PShaXJa4bKjvLcPeNFDustljiTk78JKa1+9IQ6wZiAKTDFA6pqZGedVdLTeGTFYcTUy1E7tXRH3c+/tha+JfHNwAkPHfsi2pJ/PUyz/fj3rF2BY/oZYkXGPcKKr838r+o7TeStoDWxCXyxuEQYQpSgsRr5K4= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB1905.namprd18.prod.outlook.com (10.161.154.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Wed, 17 Jul 2019 10:07:46 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72%6]) with mapi id 15.20.2073.012; Wed, 17 Jul 2019 10:07:46 +0000 From: Shally Verma To: Arek Kusztal , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "fiona.trahe@intel.com" Thread-Topic: [EXT] [PATCH v3 05/11] cryptodev: add information about message format when signing with RSA Thread-Index: AQHVPAfEf7YDgxEmGUOqPJpMjp1Wf6bOlMgw Date: Wed, 17 Jul 2019 10:07:46 +0000 Message-ID: References: <20190716185304.12592-1-arkadiuszx.kusztal@intel.com> <20190716185304.12592-6-arkadiuszx.kusztal@intel.com> In-Reply-To: <20190716185304.12592-6-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.169.231.225] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 74345549-6c84-4e0b-08b5-08d70a9e9dd2 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN6PR1801MB1905; x-ms-traffictypediagnostic: BN6PR1801MB1905: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 01018CB5B3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(376002)(366004)(396003)(346002)(13464003)(189003)(199004)(2501003)(305945005)(5660300002)(55016002)(52536014)(9686003)(74316002)(2906002)(6436002)(53936002)(25786009)(256004)(110136005)(81166006)(71190400001)(71200400001)(316002)(8676002)(8936002)(54906003)(81156014)(7736002)(14454004)(4326008)(6246003)(33656002)(66946007)(66066001)(186003)(86362001)(102836004)(99286004)(76116006)(76176011)(53546011)(6506007)(15650500001)(7696005)(68736007)(66446008)(11346002)(229853002)(446003)(486006)(476003)(66476007)(64756008)(6116002)(478600001)(3846002)(26005)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB1905; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +cuIyutRfF9OusuUrgf1ffmDAEuhwDy5KcpyU/T2y4yrnpYpPKjxfGSczlsjzR6NSDZW9NyYUxj5/urxih/5a4vnU5XOE4OAPPLhwAEKPmUPJKwN4EeGy5HL097D5qA0/Vj6voENUL9aoMGjfp2/4OvbmxXUxzo2rCVq1iScd2UbZicEGPXkBbRNIY1s54kSiSkx4TOJboYu7OIAV+p7lA6JUixIAr3ix/9rPqaXJSwYPMjGuPRNQfBhUu6Im7tvQ7VjaRP8XvvdteVyLvQOcQNJWzEZim4vQP8HUPEcsDMrI2ol2EeduteihlDiMI2v3KAj0BAEXOdHRJG8XPFHYwaoBZk+FrqtG7BiwA2bBmT2RO9A0NTh+ocyN3qPujwc6ZI6SPadTVLX1UNo+CeydSLr3XlV1ecZu3++skwZjFQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 74345549-6c84-4e0b-08b5-08d70a9e9dd2 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2019 10:07:46.2584 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shallyv@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB1905 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-17_03:2019-07-17,2019-07-17 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 05/11] cryptodev: add information about message format when signing with RSA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 05/11] cryptodev: add information about message > format when signing with RSA >=20 > External Email >=20 > ---------------------------------------------------------------------- > This patch adds information about format of the message should have > before sending it to the signing operation when using RSA algorithm. >=20 > Signed-off-by: Arek Kusztal > --- > lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > b/lib/librte_cryptodev/rte_crypto_asym.h > index 16c86c9..ad484de 100644 > --- a/lib/librte_cryptodev/rte_crypto_asym.h > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > @@ -408,6 +408,15 @@ struct rte_crypto_rsa_op_param { > * When RTE_CRYPTO_ASYM_OP_DECRYPT op_type used length in > bytes > * of this field needs to be greater or equal to the length of > * corresponding RSA key in bytes. > + * > + * When RTE_CRYPTO_ASYM_OP_SIGN op_type used and following > padding > + * type: > + * - padding PKCS1_5: > + * data provided should contain `algorithmIdentifier` in DER encoded > + * format concatenated with message digest (as per spec rfc8017 9.2) [Shally] I have reservations here and I think I asked this before too. For = PKCSV1.5, Currently there it only support output format as defined RSASP1 s= ection 5.2.1 . Means PMD does not apply EMSA-PKCS1-v1_5-ENCODE (M, emLen) defined in rfc8017 Sec= 9.2 which includes applying hash on input message and other things. So,=20 Are we extending spec here ? > + * - padding PSS > + * data provided should contain message digest of the message > + * to be signed > */ >=20 >=20 > -- > 2.1.0