From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E9EC43218 for ; Tue, 11 Jun 2019 08:58:56 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id EE5F920657 for ; Tue, 11 Jun 2019 08:58:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="AGdVRIql"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="TT+CD/I5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE5F920657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBD3A1C34C; Tue, 11 Jun 2019 10:58:35 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id EA6DD1C345 for ; Tue, 11 Jun 2019 10:58:31 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5B8tpEn020924; Tue, 11 Jun 2019 01:58:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Y2qnnTmum/avbWNfHLoIJItNIpbdjRuSo+rHx5QgPfc=; b=AGdVRIqlI5xYfdE2H9vCIpDBBi/mFQtES5gImdtjcP+aoo1oxVkrsxgcR3iCufZJA8eb xZr+v7Wb9l57mNbXXKQdbPxGDwMRT/TNGRd9rKZ5WPnFUGLCUDmeeIFmam3C9nmaRkk4 qsOjTjt27sRCYTA0NfvmzHojZMEWETWbiwaYiggPetOEMTUWPzPdNkqpbwEWKYFQ3w2a fPhCWtn10H5IvdsccE4y8pOBsJts0MjPyZQ5UXVj41njquZgtwH2tkY+LGIZ4LIJJKLz gUzooSJpBPgN9xGe/HS13gNx6uVkjThZBFchxjN5WGvEoQ1aoa8jo21UkXQaePpBZ6Hu 8g== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2t20h321dc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 11 Jun 2019 01:58:31 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 11 Jun 2019 01:58:30 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.59) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 11 Jun 2019 01:58:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y2qnnTmum/avbWNfHLoIJItNIpbdjRuSo+rHx5QgPfc=; b=TT+CD/I5ZaUh8evE3VTmQp1WdU21fFdiAjQM4qs5G5vfbAdqyzvhuTtRu1BhvDwTm6gkQ77fR3dVx/VElhTDta5rc11p9xM+IecKqB6+7S6YwmgkpMaXBAdAumdS3fSsNr4GcixfDEbUEJm+S0rHVSOSeLT8nLSm595V+FNKRJU= Received: from BN8PR18MB2691.namprd18.prod.outlook.com (20.179.72.94) by BN8PR18MB2835.namprd18.prod.outlook.com (20.179.74.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.17; Tue, 11 Jun 2019 08:58:25 +0000 Received: from BN8PR18MB2691.namprd18.prod.outlook.com ([fe80::b86e:d3b3:34b4:377e]) by BN8PR18MB2691.namprd18.prod.outlook.com ([fe80::b86e:d3b3:34b4:377e%5]) with mapi id 15.20.1965.017; Tue, 11 Jun 2019 08:58:25 +0000 From: Sunil Kumar Kori To: Anoob Joseph , Jerin Jacob Kollanukkaran , Nikhil Rao , "Erik Gabriel Carrillo" , Abhinandan Gujjar , Bruce Richardson , Pablo de Lara CC: Narayana Prasad Raju Athreya , "dev@dpdk.org" , Lukas Bartosik , "Pavan Nikhilesh Bhagavatula" , Hemant Agrawal , Nipun Gupta , Harry van Haaren , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Liang Ma , "Anoob Joseph" Thread-Topic: [EXT] [dpdk-dev] [PATCH 26/39] eventdev: add default conf for event devs field in conf Thread-Index: AQHVGi0W0cXT7jI+ykG/IoqGxfIBvKaWLGMA Date: Tue, 11 Jun 2019 08:58:25 +0000 Message-ID: References: <1559580584-5728-1-git-send-email-anoobj@marvell.com> <1559580584-5728-27-git-send-email-anoobj@marvell.com> In-Reply-To: <1559580584-5728-27-git-send-email-anoobj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: db82d446-83bc-4f31-aa4b-08d6ee4af6ed x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN8PR18MB2835; x-ms-traffictypediagnostic: BN8PR18MB2835: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:935; x-forefront-prvs: 006546F32A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(396003)(376002)(39860400002)(346002)(189003)(199004)(13464003)(446003)(186003)(52536014)(74316002)(476003)(107886003)(99286004)(53936002)(26005)(7736002)(11346002)(25786009)(6506007)(7696005)(76116006)(305945005)(6116002)(4326008)(64756008)(81156014)(76176011)(3846002)(71200400001)(102836004)(66946007)(81166006)(71190400001)(66574012)(66446008)(6246003)(66556008)(66476007)(256004)(14444005)(73956011)(9686003)(55236004)(478600001)(2906002)(5660300002)(86362001)(486006)(8936002)(68736007)(33656002)(110136005)(14454004)(54906003)(7416002)(229853002)(55016002)(66066001)(6436002)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR18MB2835; H:BN8PR18MB2691.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: mneq2eG66ihFHQWj6Fo1tYuuFeYB0bkXgsZozoC81aDuNlEPM+ZndT53f6CsdP3Xo5ZvaqmjwJqT3e8fjuZnzMiEKziX7+AqXnbbIu3ztSZffOZyUB4gLZmeFjVjStpBNPqELVzBRmFzeSGzV8HIaNK7Q4AjexljUw5M0Nq2DqPVjsoszon/QKBSusTrFVoN1U+RrpGpYzsAQ9jGpthqfb098gN7HA95+JTeRRv9ga8LOVpmh6f+fPm8fCt9nzOMxZzR8/m2a6ZcJXmuolnn+Zr1XRFqQouxJGkbObLtinnpc9BDHhM75SWWmkyl23W6+oiG9lo7syUTdm2byDt5tJCx20v1X8XB2qC3IRq0kibyMUkRabhv9pEBx+Vrziy55XQSjS3h/llV0c32Xc0OGEjxlXx8HK9RkWnfGAG7oD0= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: db82d446-83bc-4f31-aa4b-08d6ee4af6ed X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2019 08:58:25.6785 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: skori@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2835 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-11_04:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH 26/39] eventdev: add default conf for event devs field in conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Regards Sunil Kumar Kori >-----Original Message----- >From: dev On Behalf Of Anoob Joseph >Sent: Monday, June 3, 2019 10:20 PM >To: Jerin Jacob Kollanukkaran ; Nikhil Rao >; Erik Gabriel Carrillo ; >Abhinandan Gujjar ; Bruce Richardson >; Pablo de Lara > >Cc: Narayana Prasad Raju Athreya ; dev@dpdk.org; >Lukas Bartosik ; Pavan Nikhilesh Bhagavatula >; Hemant Agrawal >; Nipun Gupta ; Harry >van Haaren ; Mattias R=F6nnblom >; Liang Ma ; Anoob >Joseph >Subject: [EXT] [dpdk-dev] [PATCH 26/39] eventdev: add default conf for eve= nt >devs field in conf > >External Email > >---------------------------------------------------------------------- >Generate a default conf for event devs, if it's not specified in the conf.= This >routine will check the available event devices and it's properties and set= s the >conf accordingly. > >Signed-off-by: Anoob Joseph >Signed-off-by: Lukasz Bartosik >--- > lib/librte_eventdev/rte_eventmode_helper.c | 67 >++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > >diff --git a/lib/librte_eventdev/rte_eventmode_helper.c >b/lib/librte_eventdev/rte_eventmode_helper.c >index 4dbb94a..1729561 100644 >--- a/lib/librte_eventdev/rte_eventmode_helper.c >+++ b/lib/librte_eventdev/rte_eventmode_helper.c >@@ -179,6 +179,63 @@ rte_eventmode_validate_user_params(struct >eventmode_conf *em_conf) } > > static int >+rte_eventmode_helper_set_default_conf_eventdev(struct eventmode_conf >+*em_conf) { >+ int i, ret; >+ int nb_eventdev; >+ struct eventdev_params *eventdev_config; >+ struct rte_event_dev_info dev_info; >+ >+ /* Get the number of event devices */ >+ nb_eventdev =3D rte_event_dev_count(); >+ >+ if (nb_eventdev =3D=3D 0) { >+ RTE_EM_HLPR_LOG_ERR("No event devices detected"); >+ return -1; >+ } >+ >+ for (i =3D 0; i < nb_eventdev; i++) { >+ >+ /* Get the event dev conf */ >+ eventdev_config =3D &(em_conf->eventdev_config[i]); >+ >+ /* Read event device info */ >+ ret =3D rte_event_dev_info_get(i, &dev_info); >+ >+ if (ret < 0) { >+ RTE_EM_HLPR_LOG_ERR( >+ "Failed reading event device info (err:%d)", >+ ret); >+ return ret; >+ } >+ >+ /* Check if enough ports are available */ >+ if (dev_info.max_event_ports < 2) { >+ RTE_EM_HLPR_LOG_ERR("Not enough ports >available"); "Not Enough event ports available" instead of "Not enough ports available".= Otherwise it looks confusing with eth ports. >+ return -1; >+ } >+ >+ /* Save number of queues & ports available */ >+ eventdev_config->eventdev_id =3D i; >+ eventdev_config->nb_eventqueue =3D >dev_info.max_event_queues; >+ eventdev_config->nb_eventport =3D dev_info.max_event_ports; >+ eventdev_config->ev_queue_mode =3D >+ RTE_EVENT_QUEUE_CFG_SINGLE_LINK; >+ >+ /* One port is required for eth Rx adapter */ >+ eventdev_config->nb_eventport -=3D 1; >+ >+ /* One port is reserved for eth Tx adapter */ >+ eventdev_config->nb_eventport -=3D 1; >+ >+ /* Update the number of eventdevs */ >+ em_conf->nb_eventdev++; >+ } >+ >+ return 0; >+} >+ >+static int > rte_eventmode_helper_validate_conf(struct eventmode_conf *em_conf) { > int ret; >@@ -188,6 +245,16 @@ rte_eventmode_helper_validate_conf(struct >eventmode_conf *em_conf) > if (ret !=3D 0) > return ret; > >+ /* >+ * See if event devs are specified. Else probe the event devices >+ * and initialize the conf with all ports & queues available >+ */ >+ if (em_conf->nb_eventdev =3D=3D 0) { >+ ret =3D >rte_eventmode_helper_set_default_conf_eventdev(em_conf); >+ if (ret !=3D 0) >+ return ret; >+ } >+ > return 0; > } > >-- >2.7.4