From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6638C31E44 for ; Mon, 17 Jun 2019 04:33:00 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 565332189D for ; Mon, 17 Jun 2019 04:33:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="HXFa9ljv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="YMsREDfl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 565332189D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E05FC1BD78; Mon, 17 Jun 2019 06:32:58 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 3E5961BD6A for ; Mon, 17 Jun 2019 06:32:57 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5H4UnwR032094; Sun, 16 Jun 2019 21:32:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=OZd2g7kSG3TblinVfN787zi54JjHjUrZHY23MMY3ITw=; b=HXFa9ljv7b8+IG/WjccoabNOhl5TeCRt/K1meWxTSV9pvF1lMsaqliEYW9seUjveNufq IrKK9ABbhdfHGYomfUeHV0LIUyXgTyAbVDc2Shlw8DmdnJN5h9mNhc4igKwj0tLyca4v JI0yvaLIpb/tUjV+A9pj/p/gauPjwYtFU+AcRstJ1G/cw5+gbcgyhUWXEHwRwMlbmn+w O24YJjTgk8bvWzZcyCTS1bzVpIEMw2azN7jXz8XJF1H5qNQ4+eC5Nu6bvkLnfWJGHJev DpsLtkH1pt211Hwyg77wyGtRuWoTWX9LvxrmtN16VHlnOp/7EdwGBNYwqa7CIPH7sp4t eQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2t4x1n5wpu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 16 Jun 2019 21:32:56 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sun, 16 Jun 2019 21:32:55 -0700 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.56) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sun, 16 Jun 2019 21:32:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OZd2g7kSG3TblinVfN787zi54JjHjUrZHY23MMY3ITw=; b=YMsREDflufErPiphJYSECwC8cqY36Xe6qnNMv388vQ493RuwNTVIZMg2keNwf8aX4TxZt8PVxxwqvU5PoTgcUnaQm2FkbxVf2OqDk7cwojZ+L3h6mS9t4wcWOHDOQ+OPeKww6uaeM2Oe6SlV2Rt7GgxYXaPaX9glPO45Yr0xda0= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2520.namprd18.prod.outlook.com (20.179.93.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.12; Mon, 17 Jun 2019 04:32:52 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::75fd:a528:a1bf:bef4]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::75fd:a528:a1bf:bef4%3]) with mapi id 15.20.1987.014; Mon, 17 Jun 2019 04:32:52 +0000 From: Jerin Jacob Kollanukkaran To: Nikhil Rao CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] eventdev: change Rx adapter callback and stats structure Thread-Index: AdUkxOjOOOH98123Q1GwNfQ96MF6uA== Date: Mon, 17 Jun 2019 04:32:52 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c18c12b7-6d47-4dbe-9148-08d6f2dcdc8c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2520; x-ms-traffictypediagnostic: BYAPR18MB2520: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:383; x-forefront-prvs: 0071BFA85B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39850400004)(346002)(376002)(136003)(199004)(189003)(13464003)(3846002)(486006)(476003)(6116002)(81156014)(81166006)(25786009)(52536014)(8676002)(478600001)(256004)(6916009)(74316002)(14444005)(8936002)(73956011)(66476007)(4326008)(76116006)(86362001)(66556008)(9686003)(64756008)(5660300002)(53936002)(305945005)(66066001)(6246003)(7736002)(229853002)(186003)(68736007)(99286004)(102836004)(6436002)(2906002)(14454004)(53546011)(66946007)(66446008)(6506007)(71190400001)(7696005)(71200400001)(316002)(55016002)(33656002)(26005)(55236004); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2520; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: cY8j7r7PTHtcmC5ED0k6z/C4Bq9WT/2J17OyeDj4tHVQEGsnlbVNyTtrk5jbYwnaKRDZzR4rtnMxqRv8jNXEaHFHWLLH5BbYKJNgULhIgN/HZv9Vnnmy8JISbVqqpz9yJiROVf9mICm/x4advJOMxQAOP8MusDl2fGQtBv6gESfb/tbZbecSLTlt08iq52KysRddRBXG2K1MRV9zTt4d03kfFVLTo4FywS2/x2YyAQtum27/Btp54gdTJ2ARy3SX1r5impIkTSPzs2IzH4oBaFNP4MbyUNhFfQdIN0RckuYq/66/v1PozZS7RxWk2nhkketoCmytdXAoGK2N0yKJGAMSQ02Pq+oWgbSIWlkZHbNVh9yeT9aJicHrNZEQehBqAAfPLokxeF9x4Q+SWhMYBbdXQ3/gog0W/OJMSjb28a0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c18c12b7-6d47-4dbe-9148-08d6f2dcdc8c X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2019 04:32:52.4391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2520 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-17_03:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v2] eventdev: change Rx adapter callback and stats structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Nikhil Rao > Sent: Friday, June 14, 2019 4:58 AM > To: Jerin Jacob Kollanukkaran > Cc: nikhil.rao@intel.com; dev@dpdk.org > Subject: [EXT] [PATCH v2] eventdev: change Rx adapter callback and stats > structure >=20 > ---------------------------------------------------------------------- > Replace the mbuf pointer array in the event eth Rx adapter callback with = an > event array. Using an event array allows the application to change attrib= utes > of the events enqueued by the SW adapter. >=20 > The callback can drop packets and populate a callback argument with the > number of dropped packets. Add a Rx adapter stats field to keep track of = the > total number of dropped packets. >=20 > Signed-off-by: Nikhil Rao > --- > lib/librte_eventdev/rte_event_eth_rx_adapter.h | 82 +++++++++++++----- > -------- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 39 +++++++----= - > MAINTAINERS | 2 +- > doc/guides/rel_notes/release_19_08.rst | 13 +++- > lib/librte_eventdev/Makefile | 2 +- 1) Update version =3D 7 in lib/librte_eventdev/meson.build 2) remove the following lib/librte_eventdev/Makefile:CFLAGS +=3D -DALLOW_EXPERIMENTAL_API lib/librte_eventdev/meson.build:allow_experimental_apis =3D true 3) Update the "git comment and release notes" to express the fact that ex= perimental Status has been removed. See following change set for reference. commit 60df5711972e97d81cbfb811c9246f87cc69409a Author: Harry van Haaren Date: Thu Apr 5 14:15:46 2018 +0100 service: remove experimental tags > lib/librte_eventdev/rte_eventdev_version.map | 4 +- > 6 files changed, 80 insertions(+), 62 deletions(-) >=20 > v1: > * add implementation to RFC >=20 > v2: > * Bump library version > * Combine patch 1 & 2 into a single patch (single library version bump) > * Mention API change in release notes > * Remove __rte_experimental tag > * Remove EXPERIMENTAL status for eventdev >=20 > @@ -819,6 +806,26 @@ static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b) > ev++; > } >=20 > + if (dev_info->cb_fn) { > + > + dropped =3D 0; > + nb_cb =3D dev_info->cb_fn(eth_dev_id, > + rx_queue_id, > + ETH_EVENT_BUFFER_SIZE, > + buf->count, > + ev, > + num, > + dev_info->cb_arg, > + &dropped); I think, the above variables can squash to 80 characters limit to reduce th= e lines. Other than, Above nits, The patch looks good to me.