From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE41C76188 for ; Fri, 19 Jul 2019 03:37:35 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 374882173B for ; Fri, 19 Jul 2019 03:37:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="IP2nlBvo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="h22XyeYE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 374882173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 977D52BC7; Fri, 19 Jul 2019 05:37:33 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 3DF091B53 for ; Fri, 19 Jul 2019 05:37:32 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6J3Pgdw031059; Thu, 18 Jul 2019 20:37:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=pWAH1uZxhX1Q/fuguU8nwhUN/Qm7NSjDl0gNv2N1/5Q=; b=IP2nlBvoJBEWYDhwCpk88lZf9L6ZmSTxvW4nLkBa7WHdS0ySTZXCOSsC6KTC0Ax2Icv8 Ff+7c7rJxrIMgKJpVJbE948gOe6pQZurlGjz1Cpk82LFtZgARuolcwWe7u4zAVUDJ1Bg 5YlmGg38VphT50virb09+rLLPgeezwqIcdJn4FzYYqwnvZ8yeG+mUmX7W/Nx8+is6p30 F8Y/vYpBj3ThLoJQHRKPkEcWPY9QY7qfH+giyaS8EYG8u8ZhNQRL+wkDs6Tqyn3cuXQH ymhB+PjyOC3M1EOsq+39GbVClWaKA4Oh266hSK62cwOopGhvZ379kyQTzbMiZLUDawZq 1A== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2ts07vqu4d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2019 20:37:29 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 18 Jul 2019 20:37:29 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.53) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 18 Jul 2019 20:37:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VbMxOrW/KZGYLbjWq4W2fGQb+8apQz9w1ExNwx4dzBvGOgm0kCmoVUmAIasIUm0uZTFDezJJ86EDefTMcZjlzexl6OwuZ+41AGBjvpa8PEj16hr2mXDfk2TQbhbDglCxM9WG5PmMdfSyyvlK0wwwcm1pw0HY/e6G9nDiO/8x03AHgSeMGU1Z/5ElReEZqoaShZ6OJyX1j7QfqDToPUdnLSUl9G9OWs13iwYbeOdCY5QOpBoQv8gG2SfXCqPvGmxUhPBZw3JA7v5D5vZ8vpUm/+Zhvz3ICsdcu1g/l3Pdg9+bMs1F7/SHD6FnIZYrWCYOwjaT0q9/5QpI0jBLMSx9YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pWAH1uZxhX1Q/fuguU8nwhUN/Qm7NSjDl0gNv2N1/5Q=; b=g8odoPEdERyTQJjyCYH/XFovt02d6IKMp5azZxG/CF4+0F8YDL3dZJV/Th/ZFGJRpahxWcajl9i1HfEML/8oNp1SvEE+yHBQI7oobgizj8NFcJ7FM1kZoawSTqM8LsFb3or3voSuzANXDyA6usvcKraIE6Nr7E1GR92I9xx3/zAZ2o0qbOZW4LDZCJ/I2x3MMjAisGHWRCy61oRLfBLHIxGCn4owSf2zhWkbl8OESNeS+duHKAnDjwh/P8V7jB07Rd7k0OFchC61dXjEa/OjewH3n2l7M7SArT1QM6vmmmWnxo7vtmDuQmdc9sDVbSGos1wDnLQUTATXEoXM/+pZkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pWAH1uZxhX1Q/fuguU8nwhUN/Qm7NSjDl0gNv2N1/5Q=; b=h22XyeYE/IvDNdTZFdIgcr9b4DT//zxgYjrALUbNW3O74OL/GmAIqBptGW+TWmshWk+0XkmQP/iFGFJOUE1/LbKPEICMKBbGz0dx8jTF0mnqWBbVRUafYCady3xIZ50EleISGfaB5ZQfp/p4LnP0ZqpP0Km0yk31MAMjkZ3hqik= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2744.namprd18.prod.outlook.com (20.179.56.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.11; Fri, 19 Jul 2019 03:37:27 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2073.012; Fri, 19 Jul 2019 03:37:26 +0000 From: Jerin Jacob Kollanukkaran To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe Thread-Index: AQHVPAb6qCgWM/GTZkyeh/ChsMRfsabRTkxQ Date: Fri, 19 Jul 2019 03:37:26 +0000 Message-ID: References: <20190716114730.4b928469@hermes.lan> In-Reply-To: <20190716114730.4b928469@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b512dba-b0a5-41a7-35d8-08d70bfa6b86 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2744; x-ms-traffictypediagnostic: BYAPR18MB2744: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:343; x-forefront-prvs: 01039C93E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(13464003)(189003)(199004)(81156014)(99286004)(8936002)(256004)(6116002)(25786009)(81166006)(14444005)(5024004)(2906002)(316002)(8676002)(68736007)(14454004)(33656002)(76176011)(486006)(6506007)(102836004)(229853002)(55236004)(53546011)(7696005)(4326008)(66066001)(86362001)(52536014)(71200400001)(66556008)(3846002)(26005)(66946007)(5660300002)(71190400001)(76116006)(66476007)(64756008)(66446008)(186003)(11346002)(446003)(476003)(55016002)(9686003)(6916009)(53936002)(7736002)(305945005)(6436002)(74316002)(6246003)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2744; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xLGcXt9QL3RPTbSRFfTLO+BlPV/gUFW54oZS9h2KcV87+GAjWSKPiw9aZx5MuJV7GPD8NOay42Me9RpRNkIawOQRe39WGg2voqiK9jkb/Ny0JgyfJWpdzAfLvdIaLVTAveOMHJ/RCnmzis5ySVxSiKsP+auI7Mo54ZI4MuCwUHwcV6JUapM9t9Odc6Q6R62+CfmR930m5gMDcqcqlr3e5s1whALS3x39YXNVA5MN+UCjWV1MVNxUkgF/8LghAlo677K0E7EukW8kagDNpw2HSEKdlhNDAUOOl8+5B/xY7lVaZxSnChbRX5to7LTcI6F7XQZXypN6pynqUH45rHGiHEVtY17SDQHlJIpKbR3/Ot9a2BrgEOFWWbsE59nxCHSlL43mhklp/gjxOqJBGM9R7JbcoZ1KO8GACEwCwvYYR0A= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5b512dba-b0a5-41a7-35d8-08d70bfa6b86 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2019 03:37:26.7882 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2744 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-19_03:2019-07-18,2019-07-19 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH] net/octeontx: use logtype_init for failed probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, July 17, 2019 12:18 AM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org > Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe > All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to > be deprecated in the future. >=20 > Signed-off-by: Stephen Hemminger > --- Please fix $ ./devtools/check-git-log.sh Wrong headline format: net/octeontx: use logtype_init for failed probe =09 =09 > drivers/net/octeontx/octeontx_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/octeontx/octeontx_ethdev.c > b/drivers/net/octeontx/octeontx_ethdev.c > index 1b853399dfe4..27eed47bb0cb 100644 > --- a/drivers/net/octeontx/octeontx_ethdev.c > +++ b/drivers/net/octeontx/octeontx_ethdev.c > @@ -1175,7 +1175,7 @@ octeontx_probe(struct rte_vdev_device *dev) > strlen(rte_vdev_device_args(dev)) =3D=3D 0) { > eth_dev =3D rte_eth_dev_attach_secondary(dev_name); > if (!eth_dev) { > - RTE_LOG(ERR, PMD, "Failed to probe %s\n", > dev_name); > + PMD_INIT_LOG(ERR, "Failed to probe %s", > dev_name); > return -1; > } > /* TODO: request info from primary to set up Rx and Tx */ > -- > 2.20.1