DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	"Amit Gupta" <agupta3@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and mempool driver
Date: Fri, 28 Jun 2019 06:14:54 +0000
Message-ID: <BYAPR18MB24243F17C202B8C3180A8317C8FC0@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
In-Reply-To: <BYAPR18MB2424F4ED2A8A683C24DDDF8EC8FD0@BYAPR18MB2424.namprd18.prod.outlook.com>



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Jerin Jacob Kollanukkaran
> Sent: Thursday, June 27, 2019 1:45 PM
> To: Ferruh Yigit <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Amit Gupta
> <agupta3@marvell.com>
> Subject: Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and
> mempool driver
> >
> > Hi Jerin,
> >
> > There are some build errors with ICC, there are multiple but mainly
> > two type of them [1a] & [1b].
> >
> > I think [1b] can be fixed quickly [2b] and what do you think about
> > ignoring the warning for [1a] as done in [2a]?
> >
> > If fix makes sense, can you please send a patch for it?
> 
> Will install ICC and send the patches(excluding
> http://mails.dpdk.org/archives/dev/2019-June/135950.html)

Not able to reproduce the issue with latest ICC compiler.
$ icc -v

icc version 19.0.4.235 (gcc version 8.3.1 compatibility)

If you think, it can happen with old ICC compiler. Then we will send a patch with
CFLAGS += -diag-disable 2259 for ICC.

Let us know

> 
> 
> >
> > Thanks,
> > ferruh
> >
> >
> >
> > [1a] error #2259
> > .../dpdk/drivers/common/octeontx2/otx2_mbox.c(47): error #2259: non-
> > pointer conversion from "unsigned long long" to "struct mbox_hdr *"
> > may lose significant bits
> >                 (struct mbox_hdr *)((uintptr_t)mdev->mbase + mbox->tx_start);
> >                 ^
> >
> >
> /tmp/dpdk_maintain/self/dpdk/drivers/mempool/octeontx2/otx2_mempo
> ol.h(
> > 9
> > 4): error
> > #2259: non-pointer conversion from "unsigned long long" to
> > "int64_t={__int64_t={signed long long}} *" may lose significant bits
> >
> >
> >                 (int64_t *)(npa_lf_aura_handle_to_base(aura_handle) +
> >
> >
> >
> >                 ^
> >
> > [1b] error #191
> > .../dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c(344): error
> #191:
> > type qualifier is meaningless on cast type
> >         int64_t * const addr = (int64_t * const)
> >                                 ^
> >
> >
> > [2a]
> >  diff --git a/drivers/common/octeontx2/Makefile
> > b/drivers/common/octeontx2/Makefile
> >  index fabc32537..b78995e12 100644
> >  --- a/drivers/common/octeontx2/Makefile
> >  +++ b/drivers/common/octeontx2/Makefile
> >  @@ -19,6 +19,10 @@ CFLAGS += -Wno-int-to-pointer-cast
> >   CFLAGS += -Wno-pointer-to-int-cast
> >   endif
> >
> >  +ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)  +CFLAGS += -diag-disable 2259
> > # non-pointer conversion may lose significant bits  +endif  +
> >   EXPORT_MAP := rte_common_octeontx2_version.map
> >
> >   LIBABIVER := 1
> >  diff --git a/drivers/mempool/octeontx2/Makefile
> > b/drivers/mempool/octeontx2 /Makefile  index b3568443e..37bcebdf3
> > 100644
> >  --- a/drivers/mempool/octeontx2/Makefile
> >  +++ b/drivers/mempool/octeontx2/Makefile
> >  @@ -20,6 +20,10 @@ CFLAGS += -Wno-int-to-pointer-cast
> >   CFLAGS += -Wno-pointer-to-int-cast
> >   endif
> >
> >  +ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)  +CFLAGS += -diag-disable 2259
> > # non-pointer conversion may lose significant bits  +endif  +
> >   EXPORT_MAP := rte_mempool_octeontx2_version.map
> >
> >   LIBABIVER := 1
> >
> >
> > [2b]
> >  -       int64_t * const addr = (int64_t * const)
> >  +       int64_t * const addr = (int64_t *)

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27  8:15 Jerin Jacob Kollanukkaran
2019-06-28  6:14 ` Jerin Jacob Kollanukkaran [this message]
2019-06-28  8:08   ` Ferruh Yigit
  -- strict thread matches above, loose matches on Subject: below --
2019-06-17 15:55 [dpdk-dev] [PATCH v3 " jerinj
2019-06-22 13:23 ` [dpdk-dev] [PATCH v4 " jerinj
2019-06-25 21:39   ` Thomas Monjalon
2019-06-26 23:10     ` Stephen Hemminger
2019-06-26 13:14   ` Ferruh Yigit

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR18MB24243F17C202B8C3180A8317C8FC0@BYAPR18MB2424.namprd18.prod.outlook.com \
    --to=jerinj@marvell.com \
    --cc=agupta3@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git