From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72BBC76186 for ; Wed, 17 Jul 2019 09:21:10 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 6940720818 for ; Wed, 17 Jul 2019 09:21:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="bFdXSkNP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="ZgS38tag" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6940720818 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DC3E1C01; Wed, 17 Jul 2019 11:21:09 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id C0EC714E8 for ; Wed, 17 Jul 2019 11:21:07 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6H9KEJO022290; Wed, 17 Jul 2019 02:21:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=wOmcEM8+8KboGcjZ5L2ZKICLrdzKmAqMWlzNk4DOTKQ=; b=bFdXSkNPXb28aRGeTYMyLQVCt26utSt0MF7Eo80zTGi6fzTl6lYhTfTZU501e9HEf2xE FHIth2s4pCt9r5fwHdC9kd+KFYVav78Ao+iQTmbPdeqQWmDjfX+qo/bDwTe8QTdgxhVZ 2SNwOmWbGydq2yFCtZjLhUbCzHK1RCCOwUBGpqy86TwxvBQFIMEZNuNQSo30uhYubDOp gKT9jJOIj0nyauNI9qvlvIUEjCOqVlTZNYb5Q/JYVZ8t7lgTDjC8kLRL519QN9bL8fkX j2gYW88NRy8ylmG+cBtllJdNubd6yABo/ynZPiTP5mD0xR+Yksdt3+COJYlQZlDu9HnN SQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2ts07vfj7k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 17 Jul 2019 02:21:05 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 17 Jul 2019 02:21:05 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.56) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 17 Jul 2019 02:21:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b5DtH9aITMr0MnzUQyvwfmXzrO06txEZ06WN/XNiI96gqa2iQqI6uEuk02/EQyLz+03Cnda8QoYgJoAyrlYHn4brYqhlhQAQFaMr1ZFZd6VBkwYaPHumFAw5a4798N9r8u4xdsD5SmTFNOa9HbNMJ6LpqtZRwHjOXG8z03j1tjzX9QJyW9y7E2d5f45c//awTBn8ssvq8lELX5CqCAbxMo36pJqwbtEIrwqEQA6rXEKhAR9bWpCh2UTNRD0b8F9gr9u4pma28uy9BqIHYB/TebF+6uwYN+mUYuxYjyMLCUzylr4yGDIKjGUTNh6gaRxD+m/6GCBNTFYYPQ9g/FTRxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wOmcEM8+8KboGcjZ5L2ZKICLrdzKmAqMWlzNk4DOTKQ=; b=RwDUGYnLbKkusD08mSjBwVCKICpItGO5ywHrj0u3HqVr0sw1XrLqXE0EjF5mNWiJlypeE6Asr8sJWUZJMbT090g4Y54EKEnuJWcX8PpjID5cJ2SgyluUwFlRS9B8oEm3ZHdEbTtY/BV4hfG3x4L7w7eca5y4eWpyuB/3Lg9hN5mUzo2qxrdn//fA6QStYQixvuJHtq4ZXEelG0EApf5OZCb7YGl1xybbidiSpFdyn+ZcqCEENMyExg0IsDO5kSq24Vo5sPh+86WKOcPy1Wdn5ZvhOgH7YqlBRuMkrtKHbkg0ez+Vu/EvcWsOXf1J3LIT25Dw50eH9iK9zkRhZnYv9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wOmcEM8+8KboGcjZ5L2ZKICLrdzKmAqMWlzNk4DOTKQ=; b=ZgS38tagpjrvc8X4Wnvj0zlam05f+ry/VBpAf43YwaZ4fnicETNieKoMM2lAIRV6eNVX8graZG+D1NMTxpKlJviClpjrSC8Y2A4uSHC8T501RrWbmZtJVywNCv/C6SEZArnOXuT1s7hVH78+IBk0cP8X2IGU5PZFTfw80RmPvo0= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2485.namprd18.prod.outlook.com (20.179.92.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Wed, 17 Jul 2019 09:20:55 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2073.012; Wed, 17 Jul 2019 09:20:55 +0000 From: Jerin Jacob Kollanukkaran To: "Hyong Youb Kim (hyonkim)" , Nithin Kumar Dabilpuram , David Marchand , "Thomas Monjalon" , Ferruh Yigit , "Bruce Richardson" CC: "John Daley (johndale)" , Shahed Shaikh , "dev@dpdk.org" Thread-Topic: [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs Thread-Index: AQHVO/XIb9GeLyW36Uqi1XtdG9Kqj6bOUK4AgAAD+yCAABCQAIAAChEggAAQ1wCAAAaUUA== Date: Wed, 17 Jul 2019 09:20:55 +0000 Message-ID: References: <20190716164424.16776-1-ndabilpuram@marvell.com> <20190716164424.16776-2-ndabilpuram@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d1d55069-e4c2-4e0c-784d-08d70a981251 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2485; x-ms-traffictypediagnostic: BYAPR18MB2485: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 01018CB5B3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(396003)(346002)(39850400004)(136003)(189003)(199004)(476003)(8676002)(7736002)(305945005)(102836004)(52536014)(3846002)(446003)(11346002)(486006)(6116002)(99286004)(25786009)(26005)(71190400001)(66066001)(54906003)(256004)(110136005)(186003)(14454004)(76176011)(86362001)(74316002)(33656002)(66476007)(66556008)(66446008)(6436002)(6246003)(5660300002)(64756008)(71200400001)(478600001)(76116006)(68736007)(55016002)(66946007)(7696005)(4326008)(81156014)(53936002)(229853002)(316002)(2906002)(81166006)(8936002)(9686003)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2485; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: bXCqnzlC3pfHKTYlha7oTjrb4VlUSdyAsdg2D2995ptVYGFuP8eANH90MmekCuAzugsCuGx2FzYIGirhLg1HLsRL9qIjyAvBZ2NXKOrD/u63u7ym5ec1YeVIU/p8bvmxIhqdI4KhO7tVlgb/VvjFb3CGC679v/bviOrUB1wkcgAAOiDkt8LA3A8mQ/7HEMvzUo+nB1xyZTuyMDA9OEdsTeGfXafb4WDbwiIM54o7S3fDCnUTktdaUyHEwenmU14ehcrWj/XKL//GdLTv8tO6U155ecoE7WrD5sx01WdLYwrWOOfVYFMp29jhq3migQzoL5PITUQKgG0hGXjPtbTozjhLSfG1WONBOv3gVcoFJu4Jk6gq9i714dBbyJyeAniWBQlpA5mBwft7e00Z43evwp8qvrV8mZoMqTRMnorqVtA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d1d55069-e4c2-4e0c-784d-08d70a981251 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2019 09:20:55.3381 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2485 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-17_03:2019-07-16,2019-07-17 signatures=0 Subject: Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > Not sure. I do not have a good suggestion here :-) Like to hear from > > > David when he comes back, as he spent most time on this issue.. > > > > Sure. He is on vacation. > > Any reason for thinking, rte_intr_ack() may not be semantically correc= t? > > I think, it is very much correct if there are no better suggestions. > > Anyway it the name, From VFIO perspective, we know what is expected so > > I think it is fine. > > > > > > > > Why not return -1 and let the caller deal with it? > > > > If we make it as rte_intr_ack() no need to return -1 for > > MSIX-VFIO+Linux as it is semantically correct. > > >=20 > Ack can be ambiguous. For INTx, ack usually means PIO to a NIC register, > saying "I got your interrupt, please de-assert irq". I think, it vary from the perspective of IRQ Chip(or controller) vs NIC reg= ister(Source) PoV. Since the API starts from rte_intr_* it is more of controller so _ack_ make= sense Other reason for ack: 1) It will enforce that it needs to be called form ISR 2) It would be have been really correct to unmask if VFIO+MSIx+Linux suppor= ts it 3) if it is ack, no need to add unmask counterpart, the _mask_ API >=20 > Besides the name, are we agreeing that we want these? > - Unmask if INTx Yes > - Nothing if MSI/MSI-X Yes for MSI over VFIO No for MSI over UIO/igb_uio I don't have very strong opinion unmask vs ack. I prefer to have ack due t= he reasons stated above. If you really have strong opinion on using unmask, we will stick with that = to make forward progress. Let us know. >=20 > So, really just "unmask if INTx". I am ok with rte_intr_unmask() if we ma= ke > this intention clear. rte_unmask_if_intx() looks messy. >=20 > Thanks.. > -Hyong