DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "xavier_huwei@163.com" <xavier_huwei@163.com>,
	"linuxarm@huawei.com" <linuxarm@huawei.com>,
	"forest.zhouchang@huawei.com" <forest.zhouchang@huawei.com>
Subject: Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files
Date: Mon, 2 Sep 2019 04:24:41 +0000
Message-ID: <BYAPR18MB2424817535322985B6C2EE9FC8BE0@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)

> -----Original Message-----
> From: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> Sent: Saturday, August 31, 2019 7:41 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; dev@dpdk.org
> Cc: xavier_huwei@163.com; linuxarm@huawei.com;
> forest.zhouchang@huawei.com
> Subject: [EXT] Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files
> 
> >>> +- Arch support: ARMv8.
> >> Is it an integrated NIC controller? Why it is supported only on ARMv8?
> >> The reason why I asking because, Enabling
> >> CONFIG_RTE_LIBRTE_HNS3_PMD=y only on arm64 will create a case
> where
> >> build fails for arm64 and passes for x86. I would like to avoid such
> >> disparity. If the build is passing on x86 make it enable in the common
> code, not in arm64 config.
> > Currently this network engine is integrated in the SoCs, the SoCs can
> > be used as a PCIe EP integrated NIC controllers or be used as
> > universal cpus on the device, such as servers. The network engine is
> > accessed by ARM cores in the SoCs.
> > We will enabling CONFIG_RTE_LIBRTE_HNS3_PMD=y in common_linux
> config in V2.
> > Thanks.
> Hi,  Jerin

Hi Xaiver,

> 
>     as a PCIe EP integrated NIC controllers -> as a PCIe EP Intelligent NIC
> controllers
> 
>     Since it is currently only accessed by ARM cores on SoCs,
>     maybe it is also reasonable to compile only on ARMv8, right?

Since it is using PCIe infra to probe the devices and it will be always
Probed only on the intended system and if there is no armv8 specific
Instructions used then I prefer to build it for all archs to avoid the case
where build fails only with arm64 and not with other arch incase
If there is build issue with this PMD.

             reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02  4:24 Jerin Jacob Kollanukkaran [this message]
2019-09-06 12:21 ` Wei Hu (Xavier)
  -- strict thread matches above, loose matches on Subject: below --
2019-08-23 13:46 [dpdk-dev] [PATCH 00/22] add hns3 ethernet PMD driver Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files Wei Hu (Xavier)
2019-08-23 14:08   ` Jerin Jacob Kollanukkaran
2019-08-30  3:22     ` Wei Hu (Xavier)
2019-08-31  2:10       ` Wei Hu (Xavier)
2019-08-30 14:57     ` Ferruh Yigit
2019-08-30  6:16   ` Stephen Hemminger
2019-08-31  8:46     ` Wei Hu (Xavier)
2019-08-30  6:17   ` Stephen Hemminger
2019-08-31  8:44     ` Wei Hu (Xavier)
2019-09-03 15:27     ` Ye Xiaolong
2019-09-11 11:36       ` Wei Hu (Xavier)
2019-08-30 14:58   ` Ferruh Yigit
2019-09-10 11:43     ` Wei Hu (Xavier)
2019-08-30 15:00   ` Ferruh Yigit
2019-08-31  8:07     ` Wei Hu (Xavier)
2019-08-30 15:12   ` Ferruh Yigit
2019-08-31  8:07     ` Wei Hu (Xavier)

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR18MB2424817535322985B6C2EE9FC8BE0@BYAPR18MB2424.namprd18.prod.outlook.com \
    --to=jerinj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=forest.zhouchang@huawei.com \
    --cc=linuxarm@huawei.com \
    --cc=xavier.huwei@huawei.com \
    --cc=xavier_huwei@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git