From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F70BC28CC7 for ; Mon, 10 Jun 2019 10:19:24 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C5BDC20859 for ; Mon, 10 Jun 2019 10:19:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="H29mXzns"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="pFER7qZp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5BDC20859 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 003061BFE3; Mon, 10 Jun 2019 12:19:22 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 980AD1BFE3 for ; Mon, 10 Jun 2019 12:19:21 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5AAF3t9025435; Mon, 10 Jun 2019 03:19:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=7V2ck+5xxmNs6dQBBiZ8rlzSusIJ9QofVItQFsfSFi0=; b=H29mXznsX2NwxqrDcc6BL2fwgJ7HzNF75HpVKJ+EcZ+8/7evZmjQYha4LUVeXE7qYnM8 jdoIzD5LMCgBqiCT/TnqGU2CXWTccwVWQkbtpRnq8v+nHvbk68u/I7LaXIAOmbftRgDi OIYbSDq5DP+aL+YspC0F6fYDlwepLD6NTafmsFOJN9uhrmqbFTqYTNNlLjiOKftRhGtp RiECQX32ViMMYMSGFy0mB9eMhvvzYVVTivFDfsuQOAE/en4+4ly5wNkQadw+Ba/Bj8mA 4XeLZ3YvjtoOXcl1JyOfVPLkgJ7S8Bl/ivA8mxJbYwsA0opLtrjdUJjFHohR0aCrG1mG Gg== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2t1hk6gv84-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 10 Jun 2019 03:19:20 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 10 Jun 2019 03:19:19 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.57) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 10 Jun 2019 03:19:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7V2ck+5xxmNs6dQBBiZ8rlzSusIJ9QofVItQFsfSFi0=; b=pFER7qZpjpnyfVkaLUVgN8tO7KyGxyvvqMLItmnhvA6a12YiLZHinDEpJR1dMy8tHH3JBbxDashfyjRv6GHLlpFwHK4rmN6BAOhzIr4hZT8waBcicxxZxM+K12lKvLIlohR4+NN1LfW0FVDpInsOD1lyxpThkG8K8Ge3jEfoHXU= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2632.namprd18.prod.outlook.com (20.179.94.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.17; Mon, 10 Jun 2019 10:19:16 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c%7]) with mapi id 15.20.1965.017; Mon, 10 Jun 2019 10:19:16 +0000 From: Jerin Jacob Kollanukkaran To: Anoob Joseph , Nikhil Rao , "Erik Gabriel Carrillo" , Abhinandan Gujjar , Bruce Richardson , Pablo de Lara CC: Anoob Joseph , Narayana Prasad Raju Athreya , "dev@dpdk.org" , Lukas Bartosik , Pavan Nikhilesh Bhagavatula , Hemant Agrawal , "Nipun Gupta" , Harry van Haaren , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Liang Ma Thread-Topic: [PATCH 16/39] eventdev: add eventmode CL options framework Thread-Index: AQHVGjLABNqJmUTC/kadL7BTK/rEa6aUtkvw Date: Mon, 10 Jun 2019 10:19:16 +0000 Message-ID: References: <1559583160-13944-1-git-send-email-anoobj@marvell.com> <1559583160-13944-17-git-send-email-anoobj@marvell.com> In-Reply-To: <1559583160-13944-17-git-send-email-anoobj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5291cc96-8691-4625-0c60-08d6ed8d17f3 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2632; x-ms-traffictypediagnostic: BYAPR18MB2632: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0064B3273C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(366004)(396003)(39850400004)(376002)(13464003)(189003)(199004)(6436002)(52536014)(5660300002)(68736007)(25786009)(229853002)(53936002)(55016002)(9686003)(3846002)(4326008)(7416002)(76116006)(14454004)(478600001)(66946007)(66476007)(66556008)(74316002)(6116002)(8676002)(81156014)(26005)(73956011)(81166006)(64756008)(66446008)(8936002)(99286004)(54906003)(110136005)(2906002)(305945005)(7696005)(71190400001)(186003)(102836004)(486006)(7736002)(76176011)(71200400001)(66066001)(86362001)(11346002)(6506007)(53546011)(55236004)(316002)(6246003)(476003)(33656002)(446003)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2632; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3wKYZC4Cq5yYctKg2roqS79HkeqQcvkwpifT2vNI7q4wrNpmjC+Kcab028NXfm8fmFFiAcj8r3D/liTi/SMFpPi17n61WlCuZOGGrJVDwUJgziTA8RJucr+AklKDSzMNj+u8i7i+KShNWk2firPYmgV1vO2/XyFTvIXcsVfUqtg3SBazsrJ5ZcSnedC1hi22lZ68czIPP7MFXCNXinaWVnrEdiDVGb33u1pIUQPKiMmVZn/abkCEthV4lZ3ps+kgwUPMI6Hh/7KJeAm85+yNx1VgOJtqpGOZEfWvpiPPd49B3vUkTDjXmrAfaiPEyFioRcXm3fnB1XA62t0OOWGZTAPYRdp0GYc6OviBsWNyjZ88wu7SUzKjXJYLZLFmcgtyrnVfyZbhx2/oaB566MtPbOIWl9QD6mMAHQh1g1h+7W0= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5291cc96-8691-4625-0c60-08d6ed8d17f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2019 10:19:16.5700 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2632 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-10_05:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH 16/39] eventdev: add eventmode CL options framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Anoob Joseph > Sent: Monday, June 3, 2019 11:02 PM > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > ; Erik Gabriel Carrillo = ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bartosik > ; Pavan Nikhilesh Bhagavatula > ; Hemant Agrawal > ; Nipun Gupta ; Harry > van Haaren ; Mattias R=F6nnblom > ; Liang Ma > Subject: [PATCH 16/39] eventdev: add eventmode CL options framework >=20 > Adding usage prints and CL parsing routines for eventmode. Option to sele= ct > packet transfer mode is also added. >=20 > Signed-off-by: Anoob Joseph > Signed-off-by: Lukasz Bartosik > --- > +#include > + > +/* Packet transfer mode of the application */ enum > +rte_eventmode_helper_pkt_transfer_mode { > + RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_POLL =3D 0, > + RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_EVENT, > +}; Need to mark all public structues as EXPERIMENTAL. Please grep for EXPERIMENTAL in libeventdev or any other library > +struct rte_eventmode_helper_conf { > + enum rte_eventmode_helper_pkt_transfer_mode mode; > + /**< Packet transfer mode of the application */ > + void *mode_params; > + /**< Mode specific parameters */ > +}; Please make this event_helper object as 'opaque' and move to internal so t= hat it does have ABI policies and future new features can be added.