From: Jerin Jacob Kollanukkaran <jerinj@marvell.com> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>, "Vamsi Krishna Attunuru" <vattunuru@marvell.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com> Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v6 0/4] add IOVA = VA support in KNI Date: Mon, 15 Jul 2019 04:54:05 +0000 Message-ID: <BYAPR18MB2424ECD51E61ABF231130079C8CF0@BYAPR18MB2424.namprd18.prod.outlook.com> (raw) In-Reply-To: <BYAPR18MB2424FA4FF79645370B570D5CC8F20@BYAPR18MB2424.namprd18.prod.outlook.com> > > >>>> (also, i don't really like the name NO_PAGE_BOUND since in > > >>>> memzone API there's a "bounded memzone" allocation API, and this > > >>>> flag's name reads like objects would not be bounded by page size, > > >>>> not that they won't cross page > > >>>> boundary) > > >>> > > >>> No strong opinion for the name. What name you suggest? > > >> > > >> How about something like MEMPOOL_F_NO_PAGE_SPLIT? > > > > > > Looks good to me. > > > > > > In summary, Change wrt existing patch" > > > - Change NO_PAGE_BOUND to MEMPOOL_F_NO_PAGE_SPLIT > > > - Set this flag in rte_pktmbuf_pool_create () when > > rte_eal_has_hugepages() || > > > rte_malloc_heap_socket_is_external(socket_id)) > > > > If we are to have a special KNI allocation API, would we even need that? > > Not need this change in rte_pktmbuf_pool_create () if we introduce a new > rte_kni_pktmbuf_pool_create () API. Ferruh, Olivier, Anatoly, Any objection to create new rte_kni_pktmbuf_pool_create () API to embedded MEMPOOL_F_NO_PAGE_SPLIT flag requirement for KNI + IOVA as VA > > > > > > > > > Olivier, Any objection? > > > Ref: http://patches.dpdk.org/patch/55277/ > > > > > > > > > > > -- > > Thanks, > > Anatoly
next prev parent reply index Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-12 11:37 [dpdk-dev] " Jerin Jacob Kollanukkaran 2019-07-12 12:09 ` Burakov, Anatoly 2019-07-12 12:28 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran 2019-07-15 4:54 ` Jerin Jacob Kollanukkaran [this message] 2019-07-15 9:38 ` Burakov, Anatoly 2019-07-16 8:46 ` Olivier Matz 2019-07-16 9:40 ` Vamsi Krishna Attunuru 2019-07-16 9:55 ` Olivier Matz 2019-07-16 10:07 ` Vamsi Krishna Attunuru
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BYAPR18MB2424ECD51E61ABF231130079C8CF0@BYAPR18MB2424.namprd18.prod.outlook.com \ --to=jerinj@marvell.com \ --cc=anatoly.burakov@intel.com \ --cc=arybchenko@solarflare.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=olivier.matz@6wind.com \ --cc=vattunuru@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git