DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] eventdev: replace mbufs with events in Rx callback
Date: Thu, 9 May 2019 07:53:43 +0000
Message-ID: <BYAPR18MB2424EEE84A857B1CCE4505F9C8330@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)

> -----Original Message-----
> From: Nikhil Rao <nikhil.rao@intel.com>
> Sent: Thursday, May 9, 2019 5:27 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org; Nikhil Rao <nikhil.rao@intel.com>
> Subject: [EXT] [RFC] eventdev: replace mbufs with events in Rx callback
> 
> Replace the mbuf pointer array in the event eth Rx adapter callback with an
> event array instead of an mbuf array. Using an event array allows the
> application to change attributes of the events enqueued by the SW adapter.

Looks good to me. If I understand it correctly, It is applicable only to SW adapter.
If not, let us know.

Please remove the EXPERIMENTAL tag after the change.

> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> 
> Hi All,
> 
> Please review the new interface proposed below.
> 
>  lib/librte_eventdev/rte_event_eth_rx_adapter.h | 57 +++++++++++++++--
> ---------
>  1 file changed, 34 insertions(+), 23 deletions(-)
> 
> 
> + *  Packets dropped by callback.
>   * @return
> - *  Returns the number of mbufs should be enqueued to eventdev
> + *  - The number of events to be enqueued by the SW adapter.
>   */
>  typedef uint16_t (*rte_event_eth_rx_adapter_cb_fn)(uint16_t
> eth_dev_id,
>  						uint16_t queue_id,
>  						uint32_t enqueue_buf_size,
>  						uint32_t
> enqueue_buf_count,
> -						struct rte_mbuf **mbuf,
> -						uint16_t nb_mbuf,
> +						struct rte_event *ev,
> +						uint16_t nb_event,
>  						void *cb_arg,
> -						struct rte_mbuf **enq_buf);
> +						uint16_t *nb_dropped);
> 
>  /**
>   * @warning
> --
> 1.8.3.1


             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09  7:53 Jerin Jacob Kollanukkaran [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-05-08 23:57 Nikhil Rao

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR18MB2424EEE84A857B1CCE4505F9C8330@BYAPR18MB2424.namprd18.prod.outlook.com \
    --to=jerinj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=nikhil.rao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox