From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F5B4C04AB1 for ; Thu, 9 May 2019 07:53:50 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id A069521019 for ; Thu, 9 May 2019 07:53:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="QlSDmKKy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="RCSE5G9y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A069521019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BCFC23977; Thu, 9 May 2019 09:53:48 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id E30B72B87 for ; Thu, 9 May 2019 09:53:46 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x497jheH026542; Thu, 9 May 2019 00:53:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=5SqvVliczkLNQyAGrGyxHRXduWmWNllKG3VsZmqgoW4=; b=QlSDmKKyjoA2ANpRDzz42v1AF4rgbm62dLOGMRRyMio4RIn5SSdXW0IOcyUtCTX8Amv9 n6y2adeIQRlr0w92Sad8S7PmPaLyczbkoXFpsh9aiV96zXUQiW9byzn8J7Klb45zpbVQ Kw0IQ/BD65tNKX/5ZWT4o6UVy18Dlvfcvh3nnn/Ga1KRKOLbzwdhaMaMrikNoO2pdCk8 rL6Qlswlon9P8fZR3Me7XP80qHshqERM4F2HO1DSyAjVzTnbDfcQ+k4rwJd+Ncv+rvQ6 upUsv8xTGR5Cp8mimakupNnfdF/DA2KMDAD55Plf6vPhjFWu3XL+7o4OMdhbt+5yulNv ig== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2scadr9dmn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 09 May 2019 00:53:46 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 9 May 2019 00:53:44 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.50) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 9 May 2019 00:53:44 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5SqvVliczkLNQyAGrGyxHRXduWmWNllKG3VsZmqgoW4=; b=RCSE5G9y0bx3pSl87FhpNq2xn3Q6/6EOaBBgVP83g+1NrKccJlzqnWVPoal3O9w8l50vC9pW6wV6xd8ETOZQLMiA/h+ZHTlTjSBKJOlRuIn9mdWyTi4kBe2NJlvfBGltFkwoy0SlkqjJ0wNzhyKtvC0HYTe0/tGn7LtXG+S9hx8= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2536.namprd18.prod.outlook.com (20.179.93.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.11; Thu, 9 May 2019 07:53:43 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5827:68d1:b66c:bd2d]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5827:68d1:b66c:bd2d%3]) with mapi id 15.20.1856.016; Thu, 9 May 2019 07:53:43 +0000 From: Jerin Jacob Kollanukkaran To: Nikhil Rao CC: "dev@dpdk.org" Thread-Topic: [RFC] eventdev: replace mbufs with events in Rx callback Thread-Index: AdUGNwsPgc+OTITLSJqwD09tcXAVbQ== Date: Thu, 9 May 2019 07:53:43 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ee622b6-6c25-4894-d0ec-08d6d453752d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2536; x-ms-traffictypediagnostic: BYAPR18MB2536: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 003245E729 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(366004)(136003)(39860400002)(346002)(199004)(189003)(53754006)(13464003)(7736002)(76116006)(4326008)(478600001)(66556008)(66476007)(74316002)(305945005)(5660300002)(66946007)(73956011)(476003)(81156014)(316002)(186003)(6246003)(256004)(486006)(8676002)(81166006)(64756008)(7696005)(229853002)(55016002)(6436002)(6916009)(99286004)(14444005)(52536014)(68736007)(71190400001)(3846002)(6116002)(2906002)(9686003)(53936002)(26005)(66446008)(86362001)(55236004)(6506007)(53546011)(8936002)(33656002)(71200400001)(66066001)(102836004)(25786009)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2536; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: KNq1km+8WQmlKq8Uo79fBpcILUBosFPx0t9DCOsZkHRbkQuChetTnX8RfAqpkDH6KFrb2ab9yhTlPbnZlUfnB4BzVsyt+7CEZcYbu+hCQuh2nxkJw7Wv5I7sWxuwTIrefk6F7NHdbvizN5ANq+iOfWZ8xyBysYJIAkDzMR/V4s9jlsHKGCwHxELn18aSaFOhPF6vT4AoCcZ9hnU6ItIEgDCFK95I9LWfrX/tWWFs5nTgl8svxY/pJgTWimYC9MkZV1QqKBSTbfF9S8utua2bmlrJZQmtDLO67N/sVQf7EclQ15dyGh0hTl6FWBiEYf2m4JhXffrVjg+wUIJMnXgy8eQEUPh/WNGt6b7xQp54Huoaj3270bhhbDJV4vH74YRR2C/3b0P6DBgP9hXFLuxGTO36eIHIXP+3cRaaSiGg0kk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9ee622b6-6c25-4894-d0ec-08d6d453752d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2019 07:53:43.1123 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2536 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-09_02:, , signatures=0 Subject: Re: [dpdk-dev] [RFC] eventdev: replace mbufs with events in Rx callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Nikhil Rao > Sent: Thursday, May 9, 2019 5:27 AM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Nikhil Rao > Subject: [EXT] [RFC] eventdev: replace mbufs with events in Rx callback >=20 > Replace the mbuf pointer array in the event eth Rx adapter callback with = an > event array instead of an mbuf array. Using an event array allows the > application to change attributes of the events enqueued by the SW adapter= . Looks good to me. If I understand it correctly, It is applicable only to SW= adapter. If not, let us know. Please remove the EXPERIMENTAL tag after the change. > Signed-off-by: Nikhil Rao > --- >=20 > Hi All, >=20 > Please review the new interface proposed below. >=20 > lib/librte_eventdev/rte_event_eth_rx_adapter.h | 57 +++++++++++++++-- > --------- > 1 file changed, 34 insertions(+), 23 deletions(-) >=20 >=20 > + * Packets dropped by callback. > * @return > - * Returns the number of mbufs should be enqueued to eventdev > + * - The number of events to be enqueued by the SW adapter. > */ > typedef uint16_t (*rte_event_eth_rx_adapter_cb_fn)(uint16_t > eth_dev_id, > uint16_t queue_id, > uint32_t enqueue_buf_size, > uint32_t > enqueue_buf_count, > - struct rte_mbuf **mbuf, > - uint16_t nb_mbuf, > + struct rte_event *ev, > + uint16_t nb_event, > void *cb_arg, > - struct rte_mbuf **enq_buf); > + uint16_t *nb_dropped); >=20 > /** > * @warning > -- > 1.8.3.1