From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9473BC7618F for ; Wed, 17 Jul 2019 17:18:39 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id EB64121841 for ; Wed, 17 Jul 2019 17:18:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="ZDzp4cby"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="Y2gUmCHU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB64121841 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1899D1B974; Wed, 17 Jul 2019 19:18:38 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 5F3951B956 for ; Wed, 17 Jul 2019 19:18:37 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6HHFNAY030128; Wed, 17 Jul 2019 10:18:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=/u9gwXIbJUR8xnjDN3pZytwGd74jGr4Pp9sH8m4MU2g=; b=ZDzp4cby176cV2huWdNTOt0rUDfwPsGrYkIvyGg3Ghc6YYtOO2Em3YKacfZTafRbG+h3 jgIRigiqBWHJCIchACNpwXy+6OZ9UN+7CZIfVxfRn0YAKT0p90kYjFjxO4IYh1oIk4bU ZvvreTNpRkyQ20VzObUWgI72LVe+LYhKQIft0X4cQNB/Bthjdww/6OlQ6i0BOyE/6XLs VVhEGVB5bGtu/94e023pzGJatdptqGaMISQajk6ZZ5XvYHeuqPOJVLGTwsDJaSiPvW1o 7A4ZmC+J3sx6R/5S/5e9JBY2BbiQlOmaRQA1mxML7zl4dzBg6s/Xcd8GfZy/aEfLW4Xu vw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2ts0a28jej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 17 Jul 2019 10:18:32 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 17 Jul 2019 10:18:30 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.58) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 17 Jul 2019 10:18:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NVK8e5ZjY8Bx/sfZKeo7adWsD2zKIFkagoU5vjG2MScJ97GIYSoJV+qlTYD4hGDcr+d48NqvtjD+3i15QWh9wsc48EKEUD6N0ih0egXmmgdnjlpi3j3TAqUAmsz30liqocuxdE3SdZ2Pggy8oQ67pv7Ny8YYUD8+1Te0mkAE85JqPY0coQPGqWKv2XK38Ks56RSF6Az+ZFMqYY/vE3MV+7s+6JTIeQCGg3b8XoAksTdX+Fq6ntKOlRrosLLiZNovywsTTZGtA6KbDdeTn8jr5T6MANyR6Ju80FkjI+Yds5lVXizdc3TJzwm/npiaPHOL7eI+4gm0Rpdv3o2qz72w2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/u9gwXIbJUR8xnjDN3pZytwGd74jGr4Pp9sH8m4MU2g=; b=nosBuc0P2EMH3hLGcfFsAVeS9OkIC8nzLZMcGCnjSaqJMU/9LE4rebVGqVI42T7HklnsdcyPvuh1WCRWcbczvffx/Xgm1xZkx6bOepaqarhoXlq0RNqSdyIWKsJNNTaYSOOHVdLGpCk+qmV/K8k+SDBramufmLZdHPOAKhdrF8gs9qzvaGCX+jT8D6IT3iKlRTR/OM21Q0JT6EkHtad3qjvuG73KHJMzx2KTl0K6coC//hceaS0Ng+bSidDAUSc6m6TFVTLl0Sha741blCCx0ne/kyM5FnTWdvW41ErOmWrgMTnrr61Vd9qAzcofvx+Td2HCPB3oIp6Tg/Nd1xK7Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/u9gwXIbJUR8xnjDN3pZytwGd74jGr4Pp9sH8m4MU2g=; b=Y2gUmCHUPU3D4TqW744i4Y7F/bVhm5J6HBMWcNXvdoN6WUhcRuM137QMJhVgZCGSPQWMbNS7pHf+v8qy0W8ZlpolsI9smqxywE5p+JcAPom8n6XVlbRFg4s8NWljm66tzvFuy7DdI3XuD01xvEzJIMNa3tXvIFGVPlv4Hxpcxg8= Received: from BYAPR18MB2696.namprd18.prod.outlook.com (20.178.207.225) by BYAPR18MB2998.namprd18.prod.outlook.com (20.179.94.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Wed, 17 Jul 2019 17:18:28 +0000 Received: from BYAPR18MB2696.namprd18.prod.outlook.com ([fe80::d09e:8c06:c6c4:ccd3]) by BYAPR18MB2696.namprd18.prod.outlook.com ([fe80::d09e:8c06:c6c4:ccd3%3]) with mapi id 15.20.2073.015; Wed, 17 Jul 2019 17:18:28 +0000 From: Shahed Shaikh To: Nithin Kumar Dabilpuram , Hyong Youb Kim , David Marchand , "Thomas Monjalon" , Ferruh Yigit , "Igor Russkikh" , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Rasesh Mody , Wenzhuo Lu , Qi Zhang , Xiao Wang , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Alejandro Lucero , Andrew Rybchenko , Maxime Coquelin , Tiwei Bie , Zhihong Wang , "Yong Wang" CC: Jerin Jacob Kollanukkaran , John Daley , "dev@dpdk.org" , Nithin Kumar Dabilpuram Thread-Topic: [PATCH 3/3] drivers/net: use ack API in interrupt handlers Thread-Index: AQHVPJdLnoSaQsCED0i1jN+8nLG+EKbPCoGQ Date: Wed, 17 Jul 2019 17:18:28 +0000 Message-ID: References: <20190717115852.171416-1-ndabilpuram@marvell.com> <20190717115852.171416-4-ndabilpuram@marvell.com> In-Reply-To: <20190717115852.171416-4-ndabilpuram@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [123.201.100.240] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2231c7bf-4113-4472-d2f1-08d70adac90c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2998; x-ms-traffictypediagnostic: BYAPR18MB2998: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 01018CB5B3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(366004)(346002)(39860400002)(396003)(136003)(13464003)(199004)(189003)(33656002)(6436002)(4326008)(110136005)(486006)(54906003)(52536014)(99286004)(6506007)(316002)(478600001)(5660300002)(81166006)(102836004)(68736007)(53546011)(7696005)(76176011)(186003)(229853002)(53936002)(6116002)(26005)(71200400001)(71190400001)(55016002)(107886003)(74316002)(81156014)(3846002)(476003)(2906002)(8676002)(14454004)(11346002)(66066001)(7736002)(7416002)(66446008)(66946007)(6246003)(66476007)(66556008)(76116006)(64756008)(86362001)(8936002)(256004)(305945005)(25786009)(9686003)(446003)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2998; H:BYAPR18MB2696.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 415T3jT4RhrY3tSNvyQtN64ertt3AYKw7RlmS/zp67TmfDIwZH8YrKKVduKvuIQr3DCPQPvNUSJv7D0twfztQnq5TgmrDwlRCBHomnzxOeERHs7AgUUbCrYn3gn2xXjKS7t4rlMvnwbnHWqZ4LSeFox1YmqDcMKNL+jQn6DLX/0MoRja2FAsjB2wiqQxpuBkNAMK6BqFMaAE7yoPIzociDvwGAg7rPQcWVQUNFxhSIHMa3OHk8m4ewgryKttmdexKHGlH3Y2BCwbPmur/v+nvrenUi+peLzljBESUU6UJk7yAP2pVuGP5ffnMWW5iQPhClY+LtSZ+K9qJz/LpQKer/X/9KedqEn1pPxD0DLDADd7aDw0CC/N9M77cY79GJNsDQh1jWLzFdzRGYcsIiQYwmzKRoGjNNfBaulWSaSrddg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2231c7bf-4113-4472-d2f1-08d70adac90c X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2019 17:18:28.5005 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shshaikh@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2998 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-17_07:2019-07-17,2019-07-17 signatures=0 Subject: Re: [dpdk-dev] [PATCH 3/3] drivers/net: use ack API in interrupt handlers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 5:29 PM > To: Hyong Youb Kim ; David Marchand > ; Thomas Monjalon ; > Ferruh Yigit ; Igor Russkikh > ; Pavel Belous ; > Allain Legacy ; Matt Peters > ; Ravi Kumar ; Rasesh > Mody ; Shahed Shaikh ; > Wenzhuo Lu ; Qi Zhang ; Xiao > Wang ; Beilei Xing ; Jingji= ng > Wu ; Qiming Yang ; > Konstantin Ananyev ; Alejandro Lucero > ; Andrew Rybchenko > ; Maxime Coquelin > ; Tiwei Bie ; Zhihong > Wang ; Yong Wang > Cc: Jerin Jacob Kollanukkaran ; John Daley > ; dev@dpdk.org; Nithin Kumar Dabilpuram > > Subject: [PATCH 3/3] drivers/net: use ack API in interrupt handlers >=20 > Replace rte_intr_enable() with rte_intr_ack() API for acking an interrupt= in > interrupt handlers and > rx_queue_intr_enable() callbacks of PMD's. >=20 > This is inline with original intent of this change in PMDs to ack interru= pts after > handling is completed if device is backed by UIO, IGB_UIO or VFIO(with IN= Tx). >=20 > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Jerin Jacob > --- > drivers/net/atlantic/Makefile | 1 + > drivers/net/atlantic/atl_ethdev.c | 2 +- > drivers/net/atlantic/meson.build | 2 ++ > drivers/net/avp/avp_ethdev.c | 2 +- > drivers/net/avp/meson.build | 1 + > drivers/net/axgbe/Makefile | 1 + > drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- > drivers/net/axgbe/meson.build | 1 + > drivers/net/bnx2x/bnx2x_ethdev.c | 2 +- > drivers/net/bnx2x/meson.build | 1 + > drivers/net/e1000/em_ethdev.c | 4 ++-- > drivers/net/e1000/igb_ethdev.c | 6 +++--- > drivers/net/fm10k/fm10k_ethdev.c | 6 +++--- > drivers/net/fm10k/meson.build | 1 + > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/iavf/iavf_ethdev.c | 2 +- > drivers/net/ice/Makefile | 1 + > drivers/net/ice/ice_ethdev.c | 4 ++-- > drivers/net/ice/meson.build | 1 + > drivers/net/ixgbe/ixgbe_ethdev.c | 6 +++--- > drivers/net/nfp/nfp_net.c | 2 +- > drivers/net/qede/Makefile | 1 + > drivers/net/qede/meson.build | 2 ++ > drivers/net/qede/qede_ethdev.c | 8 ++++---- > drivers/net/sfc/sfc_intr.c | 4 ++-- > drivers/net/virtio/virtio_ethdev.c | 16 +++++++++++++++- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- > 27 files changed, 56 insertions(+), 29 deletions(-) >=20 ... Hi Nithin, Jerin and Hyong,=20 I have tested this series with all igb_uio, vfio-pci and uio_pci_generic mo= dules which covers both MSIx and INTx modes and everything is working fine. > a/drivers/net/qede/meson.build b/drivers/net/qede/meson.build index > 12388a6..c8f9c6d 100644 > --- a/drivers/net/qede/meson.build > +++ b/drivers/net/qede/meson.build > @@ -10,3 +10,5 @@ sources =3D files( > 'qede_main.c', > 'qede_rxtx.c', > ) > + > +cflags +=3D '-DALLOW_EXPERIMENTAL_API' > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethde= v.c > index 82363e6..9ac9da3 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -248,8 +248,8 @@ qede_interrupt_handler_intx(void *param) > if (status & 0x1) { > qede_interrupt_action(ECORE_LEADING_HWFN(edev)); >=20 > - if (rte_intr_enable(eth_dev->intr_handle)) > - DP_ERR(edev, "rte_intr_enable failed\n"); > + if (rte_intr_ack(eth_dev->intr_handle)) > + DP_ERR(edev, "rte_intr_ack failed\n"); > } > } ACK for this change.=20 >=20 > @@ -261,8 +261,8 @@ qede_interrupt_handler(void *param) > struct ecore_dev *edev =3D &qdev->edev; >=20 > qede_interrupt_action(ECORE_LEADING_HWFN(edev)); > - if (rte_intr_enable(eth_dev->intr_handle)) > - DP_ERR(edev, "rte_intr_enable failed\n"); > + if (rte_intr_ack(eth_dev->intr_handle)) > + DP_ERR(edev, "rte_intr_ack failed\n"); > } >=20 I tried to remove rte_intr_ack() from MSIx interrupt handler in qede and de= vice still generates interrupts. That means in MSIx interrupt handler - qed= e_interrupt_handler(), we can remove rte_intr_ack()/rte_intr_enable() call= . So for qede PMD - Acked-by: Shahed Shaikh For whole series - Tested-by: Shahed Shaikh Thanks, Shahed .