Re: [dpdk-dev] [PATCH v2 01/10] net/bnxt: move tx bd checking to header file

[Lance Richardson <lance.richardson@broadcom.com>]

Apologies for the confusion.

Regards,

   Lance

On Mon, May 27, 2019 at 11:24 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 5/27/2019 10:36 AM, Ferruh Yigit wrote:
> > On 5/24/2019 3:49 PM, Lance Richardson wrote:
> >> To allow sharing of tx_bds_in_hw() and bnxt_tx_avail() between
> >> vector-mode and non-vector transmit functions, move these functions
> >> into bnxt_txr.h.
> >>
> >> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> >> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> >> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >> ---
> >>  drivers/net/bnxt/bnxt_txr.c | 15 ---------------
> >>  drivers/net/bnxt/bnxt_txr.h | 15 +++++++++++++++
> >>  2 files changed, 15 insertions(+), 15 deletions(-)
> >>
> >> diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c
> >> index 9de12e0d0..16598ba63 100644
> >> --- a/drivers/net/bnxt/bnxt_txr.c
> >> +++ b/drivers/net/bnxt/bnxt_txr.c
> >> @@ -103,21 +103,6 @@ int bnxt_init_tx_ring_struct(struct bnxt_tx_queue *txq, unsigned int socket_id)
> >>      return 0;
> >>  }
> >>
> >> -static inline uint32_t bnxt_tx_bds_in_hw(struct bnxt_tx_queue *txq)
> >> -{
> >> -    return ((txq->tx_ring->tx_prod - txq->tx_ring->tx_cons) &
> >> -            txq->tx_ring->tx_ring_struct->ring_mask);
> >> -}
> >
> > I can't find this function at all, am I doing something wrong?
> > Can you please confirm if this function is upstreamed at all?
> >
> > $ git co v19.05
> > $ git grep bnxt_tx_bds_in_hw
> > $ echo $?
> > 1
> >
>
> Ah, it is coming from "bnxt patchset for Tx performance optimization" patchset,
> I will check it first.
> (It is good to write dependency information clearly in the cover letter of the
> patchset)