From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BFD9C432C0 for ; Fri, 29 Nov 2019 12:03:50 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C71E720869 for ; Fri, 29 Nov 2019 12:03:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CGc3ekfv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C71E720869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ED8AD293C; Fri, 29 Nov 2019 13:03:47 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 483349E4 for ; Fri, 29 Nov 2019 13:03:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575029026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gFx5L3JU8EWtnG1ln/lmPvvwkyJXAQVduJb8xz8P4QM=; b=CGc3ekfvBPx115OAVU/VbyDHquty6D0tq8WTY7sui9IbF1zypVRKxJmWf9qws6b9MFPAFq snbtJ/khPOm8uYbgDRH5o86TKu7DPAVTXzKR+GDknDBZxPiysEB/AldD9zD+Y5aZRnJ/hD T/An9FCZTtllp8Qxx7m0DczpPU9VqjM= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-v1fA0cfDOhmCa8UI2RTAtg-1; Fri, 29 Nov 2019 07:03:45 -0500 Received: by mail-vk1-f199.google.com with SMTP id 128so9279959vka.12 for ; Fri, 29 Nov 2019 04:03:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kr8sUc2tkEou1MFUO7QThoDEbNGTru0vdgW4uq/GxQg=; b=GeApZ2HCKDME9sVDF6DyURkzxCzWpHPECQ+nBy3W/S8YEVz2URHcPr+IYDLddcBOQS Cc5omsPF3k+y1xcqT4sp1Uj6U7E9tONQCRXvogte+X/JeN41/He1b3ap3aV+qAwpDcjE qCC2st+35aKZAUO7+36QPyTWHdSIuLRv2IVdUy2w2W/s1yD+QBhEL0oIIjf8mnAyrQCI 8KueKOzfBQc4KeV0OTRQ5WrX0LaHbU9xvPcDtoASWyGlK9WjVn/LNuRWpmtNCdi1y7kS cmJfsa96taX3VyFXqMOHXzdtCyjw+HxrucseIXUgd+V1QkB7usWehz3H0jC49MSa2RCz lyJw== X-Gm-Message-State: APjAAAVwOYe6J8RZMD8/dwsJp6wDihy75F1vkR99x79it4gAstBI19rB 4Jb3dx+aqVQyypughGu6GCl615KFq/E4TD0fzpy9vjqGCYUvyneYW2teQAW3+xlimPZuAbtM1na 18Z1qsQA7kIMfaZqCGy8= X-Received: by 2002:a67:ee49:: with SMTP id g9mr32494834vsp.105.1575029024455; Fri, 29 Nov 2019 04:03:44 -0800 (PST) X-Google-Smtp-Source: APXvYqw82yeVrn78ASEUBbW6mEokFOC9E1vBToNGjOa9RXKx5fdktnux9XT6xmfb4CR/hXlOMLYDxe+YUKDJPxmv5qk= X-Received: by 2002:a67:ee49:: with SMTP id g9mr32494806vsp.105.1575029024049; Fri, 29 Nov 2019 04:03:44 -0800 (PST) MIME-Version: 1.0 References: <20191125161314.18804-1-david.marchand@redhat.com> <20191126142212.GC21200@hmswarspite.think-freely.org> <20191129114319.GA10923@hmswarspite.think-freely.org> In-Reply-To: <20191129114319.GA10923@hmswarspite.think-freely.org> From: David Marchand Date: Fri, 29 Nov 2019 13:03:33 +0100 Message-ID: To: Neil Horman Cc: dev , Thomas Monjalon , Andrew Rybchenko , dpdk stable , Ray Kinsella , John McNamara , Marko Kovacevic , Qiming Yang , Wenzhuo Lu , Declan Doherty , Adrien Mazarguil , Ferruh Yigit , Cristian Dumitrescu X-MC-Unique: v1fA0cfDOhmCa8UI2RTAtg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [RFC PATCH] mark experimental variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 29, 2019 at 12:43 PM Neil Horman wrote: > > On Wed, Nov 27, 2019 at 09:45:46PM +0100, David Marchand wrote: > > On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wro= te: > > > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote: > > > > So far, we did not pay attention to direct access to variables but = they > > > > are part of the API/ABI too and should be clearly identified. > > > > > > > > Introduce a __rte_experimental_var tag and mark existing variables. > > > > > > > > Fixes: a4bcd61de82d ("buildtools: add script to check experimental = API exports") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: David Marchand > > > > --- > > > > Quick patch to try to catch experimental variables. > > > > Not sure if we could use a single section, so please advise if ther= e is > > > > better to do about this. > > > > > > > I don't see any definition of __rte_experimental_var here, won't the > > > preprocessor choke on this when you try to compile without that? > > > > Sorry, not getting your point. > > If there is an issue, then it is the same as __rte_experimental. > > > No, there is no issue, I'm just blind. For some reason cscope wasn't fin= ding > the definition of __rte_experimental_var when I applied your patch for me= . Its > clear you have it below. Ok, thanks for confirming. > Acked-by: Neil Horman I will do an extra pass and submit a non RFC patch with your ack if I have no change. Thanks Neil. --=20 David Marchand