DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] devtools: move ABI scripts from buildtools
@ 2019-11-28 13:46 David Marchand
  2019-11-28 14:23 ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2019-11-28 13:46 UTC (permalink / raw)
  To: dev; +Cc: Thomas Monjalon, Neil Horman

Those scripts are only used by developers and not part of the build
process.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 MAINTAINERS                                        | 8 ++++----
 {buildtools => devtools}/check-abi-version.sh      | 0
 {buildtools => devtools}/update-abi.sh             | 2 +-
 {buildtools => devtools}/update_version_map_abi.py | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)
 rename {buildtools => devtools}/check-abi-version.sh (100%)
 rename {buildtools => devtools}/update-abi.sh (95%)
 rename {buildtools => devtools}/update_version_map_abi.py (99%)

diff --git a/MAINTAINERS b/MAINTAINERS
index b51059bc2..4395d8df1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -143,13 +143,13 @@ M: Neil Horman <nhorman@tuxdriver.com>
 F: lib/librte_eal/common/include/rte_compat.h
 F: lib/librte_eal/common/include/rte_function_versioning.h
 F: doc/guides/rel_notes/deprecation.rst
-F: devtools/validate-abi.sh
+F: devtools/check-abi-version.sh
 F: devtools/check-symbol-change.sh
-F: buildtools/check-abi-version.sh
+F: devtools/update-abi.sh
+F: devtools/update_version_map_abi.py
+F: devtools/validate-abi.sh
 F: buildtools/check-experimental-syms.sh
 F: buildtools/map-list-symbol.sh
-F: buildtools/update-abi.sh
-F: buildtools/update_version_map_abi.py
 
 Driver information
 M: Neil Horman <nhorman@tuxdriver.com>
diff --git a/buildtools/check-abi-version.sh b/devtools/check-abi-version.sh
similarity index 100%
rename from buildtools/check-abi-version.sh
rename to devtools/check-abi-version.sh
diff --git a/buildtools/update-abi.sh b/devtools/update-abi.sh
similarity index 95%
rename from buildtools/update-abi.sh
rename to devtools/update-abi.sh
index 15bc6feab..b9b859a3e 100755
--- a/buildtools/update-abi.sh
+++ b/devtools/update-abi.sh
@@ -42,5 +42,5 @@ echo "Path to update:" $update_path
 echo $abi_version > $abi_version_file
 
 find $update_path -name  \*version.map -exec \
-      ./buildtools/update_version_map_abi.py {} \
+      devtools/update_version_map_abi.py {} \
       $abi_version \; -print
diff --git a/buildtools/update_version_map_abi.py b/devtools/update_version_map_abi.py
similarity index 99%
rename from buildtools/update_version_map_abi.py
rename to devtools/update_version_map_abi.py
index 6b9aff7a4..616412a1c 100755
--- a/buildtools/update_version_map_abi.py
+++ b/devtools/update_version_map_abi.py
@@ -6,7 +6,7 @@
 A Python program that updates and merges all available stable ABI versions into
 one ABI version, while leaving experimental ABI exactly as it is. The intended
 ABI version is supplied via command-line parameter. This script is to be called
-from the buildtools/update-abi.sh utility.
+from the devtools/update-abi.sh utility.
 """
 
 from __future__ import print_function
-- 
2.23.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] devtools: move ABI scripts from buildtools
  2019-11-28 13:46 [dpdk-dev] [PATCH] devtools: move ABI scripts from buildtools David Marchand
@ 2019-11-28 14:23 ` Thomas Monjalon
  2019-11-28 15:21   ` David Marchand
  2019-11-28 15:36   ` David Marchand
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-11-28 14:23 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Neil Horman

28/11/2019 14:46, David Marchand:
> Those scripts are only used by developers and not part of the build
> process.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

I hesitated to accept these scripts in buildtools.
I agree it is better in devtools, and not installed.

Acked-by: Thomas Monjalon <thomas@monjalon.net>




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] devtools: move ABI scripts from buildtools
  2019-11-28 14:23 ` Thomas Monjalon
@ 2019-11-28 15:21   ` David Marchand
  2019-11-28 15:36   ` David Marchand
  1 sibling, 0 replies; 4+ messages in thread
From: David Marchand @ 2019-11-28 15:21 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Neil Horman, Luca Boccassi

On Thu, Nov 28, 2019 at 3:23 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 28/11/2019 14:46, David Marchand:
> > Those scripts are only used by developers and not part of the build
> > process.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> I hesitated to accept these scripts in buildtools.
> I agree it is better in devtools, and not installed.

Yes, forgot to mention that update_version_map_abi.py raised an issue
in the Centos 8 packaging test in OBS.
Relooking at those scripts, there is no reason to install them as part
of a dpdk package.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] devtools: move ABI scripts from buildtools
  2019-11-28 14:23 ` Thomas Monjalon
  2019-11-28 15:21   ` David Marchand
@ 2019-11-28 15:36   ` David Marchand
  1 sibling, 0 replies; 4+ messages in thread
From: David Marchand @ 2019-11-28 15:36 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Neil Horman, Thomas Monjalon

On Thu, Nov 28, 2019 at 3:23 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> 28/11/2019 14:46, David Marchand:
> > Those scripts are only used by developers and not part of the build
> > process.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-28 13:46 [dpdk-dev] [PATCH] devtools: move ABI scripts from buildtools David Marchand
2019-11-28 14:23 ` Thomas Monjalon
2019-11-28 15:21   ` David Marchand
2019-11-28 15:36   ` David Marchand

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git