dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: dev <dev@dpdk.org>, Aaron Conole <aconole@redhat.com>,
	 Michael Santana <msantana@redhat.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests
Date: Thu, 1 Aug 2019 15:26:33 +0200	[thread overview]
Message-ID: <CAJFAV8wWEgZHzpiHgz4FdNV3dQ2maJUV5_Lz9wzn0Jf8UCBYeg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8yF5E1qdb0V+mfYzkXTjEjSUXAbrVhe99ncuHGfzrzPYw@mail.gmail.com>

On Thu, Aug 1, 2019 at 3:24 PM David Marchand <david.marchand@redhat.com> wrote:
>
> Hey Gaëtan,
>
> On Thu, Aug 1, 2019 at 3:22 PM Gaëtan Rivet <gaetan.rivet@6wind.com> wrote:
> >
> > On Thu, Aug 01, 2019 at 02:29:21PM +0200, David Marchand wrote:
> > > On Thu, Aug 1, 2019 at 2:28 PM David Marchand <david.marchand@redhat.com> wrote:
> > > >
> > > > The memory tests currently check that, for normal mode (not legacy mode),
> > > > there is no memory left behind when exiting.
> > > >
> > > > The problem is that if a ethdev port is allocated when scanning pci
> > > > devices (even if the driver probe fails like when you have a virtio
> > > > management interface attached to the kernel), on exit, dpdk won't free
> > > > the associated memory since ethdev never frees the ethdev memzone.
> > > >
> > > > Workaround this by disabling pci scan.
> > >
> > > Not entirely happy with this patch.
> > > I am open to suggestions :-)
> > >
> >> Why not cleanup on .fini the ethdev subsystem?
>
> I had this in mind, tried it quickly, but it still failed.
> So I suppose .fini is executed after rte_eal_cleanup (where the
> freeing of the hugepages happens).

Or we move rte_eal_cleanup in a .fini and play with priorities... too
dangerous for 19.08, from my pov.


-- 
David Marchand

  reply	other threads:[~2019-08-01 13:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 12:27 [dpdk-dev] [PATCH] test/eal: do not scan PCI devices for memory tests David Marchand
2019-08-01 12:29 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-08-01 13:22   ` Gaëtan Rivet
2019-08-01 13:24     ` David Marchand
2019-08-01 13:26       ` David Marchand [this message]
2019-08-02 11:13   ` David Marchand
2019-08-02 13:37   ` Aaron Conole
2019-08-02 13:45     ` David Marchand
2019-08-02 20:57 ` Thomas Monjalon
2019-08-03  9:51   ` David Marchand
2019-08-05 10:19     ` Thomas Monjalon
2019-08-08 11:23       ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wWEgZHzpiHgz4FdNV3dQ2maJUV5_Lz9wzn0Jf8UCBYeg@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=aconole@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=msantana@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).